Re: [SeaBIOS] [PATCH 2/2] Allow using full io region on q35

[Peter Stuge]

Gerd Hoffmann wrote:
> +++ b/src/fw/pciinit.c
> ...
> @@ -721,16 +728,11 @@ static int pci_bios_init_root_regions_io(struct pci_bus *bus)
>      if (sum < 0x4000) {
>          /* traditional region is big enougth, use it */
>          r_io->base = 0xc000;
> -    } else if (sum < 0x9000) {
> +    } else if (sum < pci_io_low_end - 0x1000) {
>          /* use the larger region at 0x1000 */
>          r_io->base = 0x1000;
>      } else {
> -        /*
> -         * Not enougth io address space -> error out.
> -         *
> -         * TODO: on q35 we can move PORT_ACPI_PM_BASE out of
> -         * the way, then use the whole 1000 -> ffff region.
> -         */
> +        /* Not enougth io address space -> error out. */

Typo here           ---^


//Peter