thanks for upstreaming these Paul. IIRC, it was some Asus models, the C200/C300, which prompted this change, but I know it improved the reliability of detection on quite a few others as well
On Mon, Mar 16, 2020 at 4:41 AM Paul Menzel pmenzel@molgen.mpg.de wrote:
From: Matt DeVillier matt.devillier@gmail.com Date: Fri, 14 Dec 2018 01:20:31 -0600
This helps card detection on some Chromebooks.
Signed-off-by: Matt DeVillier matt.devillier@gmail.com Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de
Upstream from https://github.com/MrChromebox/SeaBIOS/
Matt, it’d be great if you could list the affected Chromebooks you know of.
src/hw/sdcard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index 97517f4..2cd4e3d 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -128,7 +128,7 @@ struct sdhci_s {
// SDHCI timeouts #define SDHCI_POWER_OFF_TIME 1 -#define SDHCI_POWER_ON_TIME 5 +#define SDHCI_POWER_ON_TIME 25 #define SDHCI_CLOCK_ON_TIME 1 // 74 clock cycles #define SDHCI_POWERUP_TIMEOUT 1000
#define SDHCI_PIO_TIMEOUT 1000 // XXX - this is just made up
2.25.1