Re: [SeaBIOS] [PATCH 3/6] vgabios: vbe 15h func returns constructed EDID

[Hiroshi Miura]

On 2012年09月08日 23:38, Hiroshi Miura wrote:
> On 2012年09月03日 06:10, Kevin O'Connor wrote:
> > > { 0x187, { MM_DIRECT, 1920, 1200, 16, 8, 16, SEG_GRAPH } },
> > > { 0x188, { MM_DIRECT, 1920, 1200, 24, 8, 16, SEG_GRAPH } },
> > > { 0x189, { MM_DIRECT, 1920, 1200, 32, 8, 16, SEG_GRAPH } },
> > > { 0x18a, { MM_DIRECT, 2560, 1600, 16, 8, 16, SEG_GRAPH } },
> > > { 0x18b, { MM_DIRECT, 2560, 1600, 24, 8, 16, SEG_GRAPH } },
> > > { 0x18c, { MM_DIRECT, 2560, 1600, 32, 8, 16, SEG_GRAPH } },
> > > { 0x187, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } },
> > > { 0x188, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } },
> > > { 0x189, { MM_DIRECT, 1920, 1080, 32, 8, 16, SEG_GRAPH } },
> > > { 0x18a, { MM_DIRECT, 1920, 1200, 16, 8, 16, SEG_GRAPH } },
> > > { 0x18b, { MM_DIRECT, 1920, 1200, 24, 8, 16, SEG_GRAPH } },
> > > { 0x18c, { MM_DIRECT, 1920, 1200, 32, 8, 16, SEG_GRAPH } },
> > > { 0x18d, { MM_DIRECT, 2560, 1600, 16, 8, 16, SEG_GRAPH } },
> > > { 0x18e, { MM_DIRECT, 2560, 1600, 24, 8, 16, SEG_GRAPH } },
> > > { 0x18f, { MM_DIRECT, 2560, 1600, 32, 8, 16, SEG_GRAPH } },
> >
> > This appears to be adding three new 1080 height modes.  Unless this
> > is somehow tied to the edid support, I suggest moving this change to a
> > separate patch.
>
> But now I'd like to add EDID for 1920x1200.

A patch I resend ([PATCH 2/3] bochsvga: Implement vbe 15h function) now provide
EDID for 1920x1200 resolution that make this part of modification is not needed.

Thank you for your suggestion.

Hiroshi