On Sun, 24 Jan 2010 17:45:25 +0100 Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
That looks like a bug. If you're talking about an ISA device, the LFB must be smaller than 16 MB and its upper end must be at 16 MB or below. If you only allow power-of-two sizes, the maximum LFB size is 8 MB located at 8 MB. (LFB size of 16 MB is not allowed because it would mean the lowest 640 kB are part of the LFB.) If the device is EISA (instead of ISA) it can work, but I think you need the full PNPBIOS extensions for it to work (AFAIK isapnptools have readable docs/code and could help to find out what is needed).
I think this code probably fall into the eisa catagory, But I am confused about what the direction you offer to solve this problem.
The acpi spec does mention that PNP devices does not have to be reported.
But considering the qemu code we have right now I think this is the only right fix to make the isa_sta_vga safe.
Thanks.
#endif /* ROM BIOS */ rom_add_vga(VGABIOS_FILENAME); return 0; }
Thanks for quoting that code.
Regards, Carl-Daniel