Re: [SeaBIOS] [PATCH 2/3] xhci: disable for QEMU_128K

[Gerd Hoffmann]

On Mi, 2013-09-25 at 12:36 +0300, Michael S. Tsirkin wrote:
> QEMU 1.6 and earlier didn't have XHCI so we
> can safely disable that for QEMU_128K.
> Signed-off-by: Michael S. Tsirkin
>
> src/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Kconfig b/src/Kconfig
> index d6b6608..f753170 100644
> --- a/src/Kconfig
> +++ b/src/Kconfig
> @@ -235,7 +235,7 @@ menu "Hardware support"
>          help
>              Support USB EHCI controllers.
>      config USB_XHCI
>    depends on USB && QEMU_HARDWARE
>    depends on USB && QEMU_HARDWARE && !QEMU_128K
>    bool "USB XHCI controllers"
>    default y
>    help

I still think this is a bad idea.

In any case you should not add a dependency but flip the default for the
small rom, using "default n if QEMU_128K"

cheers,
  Gerd