On Tue, Aug 26, 2014 at 10:42:31AM -0400, Stefan Berger wrote:
On 08/26/2014 10:01 AM, Kevin O'Connor wrote:
On Mon, Aug 25, 2014 at 05:18:49PM -0400, Stefan Berger wrote:
We now have ACPI support in QEMU as well. In SeaBIOS the TPM patches add the TPM ACPI tables (SSDT, TCPA) if SeaBIOS is building ACPI tables. I suppose this is still the correct thing to do.
I'd prefer to keep the ACPI code unchanged. New users that want TPM functionality on QEMU can use a newer machine type, and users that want to use an older machine type for compatibility reasons should not see changes to the ACPI definitions.
So there is no existing use case where SeaBIOS is the only firmware on a platform (other than on QEMU)? I know coreboot can run SeaBIOS as a payload and therefore I would agree that in this case coreboot should handle the ACPI tables.
The acpi code in SeaBIOS was only ever used by QEMU. Other users (coreboot and CSM) always created the acpi tables and passed them to SeaBIOS.
-Kevin