Re: [SeaBIOS] The cbfs header for a payloads dest addr is a u64, use ntohll instead of ntohl

[Dave Frodin]

Kevin,

Thanks, your patch works for me.

Dave

----- Original Message -----
> From: "Kevin O'Connor" 
> To: "Dave Frodin" 
> Cc: "Peter Stuge" , [e-mail]
> Sent: Tuesday, August 14, 2012 7:20:01 PM
> Subject: Re: [SeaBIOS] The cbfs header for a payloads dest addr is a u64, use ntohll instead of ntohl
>
> On Wed, Aug 08, 2012 at 12:07:50PM -0600, Dave Frodin wrote:
> > Peter,
> >
> > You're right, that u64 cast wasn't needed, but I needed to cast the
> > result to u32.
> > The (void*) is evidently expecting a u32. Is that correct? Would
> > SeaBIOS always be
> > expecting a u32 for an address to execute from?
> >
> > I also cleaned up the macro to use the existing ntohl.
> > The new patch is below. I also tested it.
>
> Thanks for catching this.  I think it would be worthwhile to clean up
> the byteorder calls - see a patch I've sent in a separate email.
>
> -Kevin