On Tue, Mar 17, 2020 at 08:30:32PM -0400, Kevin O'Connor wrote:
On Mon, Mar 16, 2020 at 10:38:25AM +0100, Paul Menzel wrote:
From: Matt DeVillier matt.devillier@gmail.com Date: Fri, 12 Aug 2016 14:21:58 -0500
PS/2 keyboards on Chromebooks with upstream coreboot + SeaBIOS often fail to init properly / register keystrokes. Modify ps2port init to match that of TianoCore, which doesn't have said issues.
Signed-off-by: Matt DeVillier matt.devillier@gmail.com Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de
Upstream from https://github.com/MrChromebox/SeaBIOS/
src/hw/ps2port.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/hw/ps2port.c b/src/hw/ps2port.c index 88b1059..2c334c0 100644 --- a/src/hw/ps2port.c +++ b/src/hw/ps2port.c @@ -465,6 +465,14 @@ ps2_keyboard_setup(void *data) if (ret) return;
- // Disable KB/mouse interfaces
- ret = i8042_command(I8042_CMD_KBD_DISABLE, NULL);
- if (ret)
return;- ret = i8042_command(I8042_CMD_AUX_DISABLE, NULL);
- if (ret)
return;I do not think this change is correct. My recollection is that the underlying bug that led to non-functioning keyboards was fixed as of dbf9dd27f. Can someone confirm that the underlying problem is still present after dbf9dd27f?
FYI, I reverted this patch.
-Kevin