On Fri, Aug 24, 2018 at 09:12:47AM +0200, Laszlo Ersek wrote:
On 08/24/18 04:23, Liu, Jing2 wrote:
Hi Laszlo,
On 8/22/2018 5:13 PM, Laszlo Ersek wrote:
On 08/16/18 12:43, Liu, Jing2 wrote:
On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
Hi,
+ if (pci_config_readw(bdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_REDHAT) { + dprintf(1, "PCI: QEMU resource reserve cap vendor ID doesn't match.\n");
I'd suggest to use a higher debug level for this one, 3 would be a good pick I think. level 1 messages are printed by default, and we should not spam the log just because there is a non-qemu bridge present in the system.
OK. Will do that.
With the debug level update, I'm ready to give my R-b for this series.
Thanks for your feedback! So do I need update another version and with your R-b?
I imagine you'd post v3 with the update Gerd requested for the debug level(s), and then I'd respond with my R-b. (Obviously I'm not a SeaBIOS maintainer so that'll not be "decisive" by any means.)
Yep, I've expected you post a v3 with the debug level change (whole series).
cheers, Gerd