Re: [SeaBIOS] [PATCH 1/2] Boot up with a splash picture configurable,

[Kevin O'Connor]

On Wed, Jun 22, 2011 at 08:24:16PM +0800, Wayne Xia wrote:
> Signed-off-by: Wayne Xia

Thanks.  See my comments below.

[...]
> +void raw_data_format_adjust_24bpp(u8 *src, u8 *dest, int width, int height,
>        int bytes_per_line_src, int bytes_per_line_dest, u8 switch_flag)
>
> +{

It's still not clear to me what this function does.  It seems like it
is adjusting for extra space in the framebuffer at the end of every
horizontal line.  However, it's unclear why BMP would use SWITCH_LINE
and JPEG would use SWITCH_RGB or why either is needed.

The purpose of jpeg_show (and bmp_show) is to decode the picture - if
the picture isn't decoded properly then I think the xxx_show()
function should be fixed instead of re-copying the picture to correct
the decoding.

[...]
> +typedef struct tagBITMAPFILEHEADER {
> +u8 bfType[2];
> +u8 bfSize[4];

Indentation.
> void
>  enable_bootsplash(void)
>  {
> if (!CONFIG_BOOTSPLASH)
> if (!CONFIG_BOOTSPLASH) {
>     return;
> }

Unneeded style change.

[...]
> int width, height;
> jpeg_get_size(jpeg, &width, &height);
> bpp_require = 24;/* for better vision effect, use 24 bpp mode */

This could break existing users that use 16bit or 32bit modes.

-Kevin