Re: [SeaBIOS] [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4

[Jan Kiszka]

On 2012-01-24 13:52, Andreas Färber wrote:
> Am 24.01.2012 11:28, schrieb Jan Kiszka:
> > On 2012-01-24 11:10, Vasilis Liaskovitis wrote:
> > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> > > index ac251c6..6d61567 100644
> > > --- a/hw/pc_piix.c
> > > +++ b/hw/pc_piix.c
> > > @@ -380,6 +380,14 @@ static QEMUMachine pc_machine_v1_1 = {
> > >      .desc = "Standard PC",
> > >      .init = pc_init_pci,
> > >      .max_cpus = 255,
> > > .compat_props = (GlobalProperty[]) {
> > >    {
> > >        .driver   = "PIIX4_PM",
> > >        .property = "cpu_acpi_eject",
> > >        .value    = stringify(1),
> >
> > Such things are usually handled the other way around: define
> > no_cpu_acpi_eject and set it in all legacy machines.
>
> Either way reminds me that qdev bool support never got merged. I'll dig
> it out and rebase.

Perfect! I really hate to model bool via bit.

Jan