On Fri, Dec 11, 2020 at 10:46:00AM -0500, Kevin O'Connor wrote:
On Thu, Dec 10, 2020 at 04:26:21PM -0500, Eduardo Habkost wrote:
This series implements support for SMBIOS 3.0 entry points in
SeaBIOS.
The main advantage of SMBIOS 3.0 entry points is the higher limit for total table size. The SMBIOS 2.1 64435 bytes limit can be easily hit in QEMU if creating virtual machines with more than 720 VCPUs.
Thanks. The series looks good to me.
What is the integration plan for merging this and making the associated changes to QEMU? Are you looking to merge this first?
The QEMU part will be based on this patch by Daniel; https://lore.kernel.org/qemu-devel/20200908165438.1008942-6-berrange@redhat....
I'm looking to merge this before the QEMU option, so non-working configurations (VM configured with SMBIOS 3.0 + lack of SeaBIOS support for SMBIOS 3.0) are less likely.
I noticed that the new code only has a single qemu smbios "anchor" file - does that mean qemu will only ever use smbios3 or smbios2 and never need to export both simultaneously?
QEMU doesn't need to export both simultaneously, as both entry points would contain redundant information. It would be possible to add code to SeaBIOS to generate both entry points for compatibility, but I'm not sure how useful that would be (as compatibility with SMBIOS 2.1 could be easily achieved by simply changing the QEMU configuration).