SeaBIOS August 2024

seabios@seabios.org

3 participants
3 discussions

[PATCH] esp-scsi: indicate acceptance of MESSAGE IN phase data
by Mark Cave-Ayland 04 Sep '24

04 Sep '24

When the target has sent its MESSAGE IN phase data to the initiator, it waits for the initiator to release the ACK signal before disconnecting from the bus. Send a MSG_ACC command to the ESP so that the initiator releases the ACK signal to allow the target to disconnect, and also return the ASC back to the disconnected state. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> --- src/hw/esp-scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) [MCA: this is required for an upcoming QEMU ESP patch series which enforces the commands that can be executed in each internal ESP state. Without this fix SeaBIOS doesn't return the ESP back to its disconnected state after the SCSI transfer, causing subsequent ESP commands to fail.] diff --git a/src/hw/esp-scsi.c b/src/hw/esp-scsi.c index 8612069f..e1bee545 100644 --- a/src/hw/esp-scsi.c +++ b/src/hw/esp-scsi.c @@ -50,6 +50,7 @@ #define ESP_CMD_RESET 0x02 #define ESP_CMD_TI 0x10 #define ESP_CMD_ICCS 0x11 +#define ESP_CMD_MSGACC 0x12 #define ESP_CMD_SELATN 0x42 #define ESP_STAT_DI 0x01 @@ -159,11 +160,12 @@ esp_scsi_process_op(struct disk_op_s *op) continue; } - /* Finally read data from the message in phase. */ + /* Finally read data from the message in phase and accept. */ if (state == 3 && (stat & ESP_STAT_MSG)) { state++; status = inb(iobase + ESP_FIFO); inb(iobase + ESP_FIFO); + outb(ESP_CMD_MSGACC, iobase + ESP_CMD); break; } usleep(5); -- 2.39.2

2 1

[PATCH] Major bug in src/farptr.h
by william pecnik 05 Aug '24

05 Aug '24

the patch is in attach file to apply use "*patch src/farptr.h < farptr.patch*" from seabios directory This will fix the problem of calling bios service int 0x13 AH=0x42 when the drive is a ATAPI (because Outs should use DS:SI and not ES:DI) This bug affect all Outs() when called from real mode 16bits ! i save DS and restore it after, because Seabios use it

2 1

Major bug in src/farptr.h
by william pecnik 04 Aug '24

04 Aug '24

inlines outsb_fl() outsw_fl and outsl_fl are broken when used from real mode 16bits Outs use segment DS:SI not ES, so here is the fix: (assuming we save DS and restore it because Seabios use it) static inline void outsb_fl(u16 port, void *ptr_fl, u16 count) { u16 ds = GET_SEG(DS); SET_SEG(DS, FLATPTR_TO_SEG(ptr_fl)); outsb(port, (u8*)FLATPTR_TO_OFFSET(ptr_fl), count); SET_SEG(DS, ds); } static inline void outsw_fl(u16 port, void *ptr_fl, u16 count) { u16 ds = GET_SEG(DS); SET_SEG(DS, FLATPTR_TO_SEG(ptr_fl)); outsw(port, (u16*)FLATPTR_TO_OFFSET(ptr_fl), count); SET_SEG(DS, ds); } static inline void outsl_fl(u16 port, void *ptr_fl, u16 count) { u16 ds = GET_SEG(DS); SET_SEG(DS, FLATPTR_TO_SEG(ptr_fl)); outsl(port, (u32*)FLATPTR_TO_OFFSET(ptr_fl), count); SET_SEG(DS, ds); }

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS August 2024