SeaBIOS April 2021

seabios@seabios.org

10 participants
14 discussions

[PATCH] boot: add config option for fast device init
by Gerd Hoffmann 14 Apr '21

14 Apr '21

Add a config option for fast device init (i.e. skip non-bootable devices). This optimization breaks boot in some rare configurations, specifically in case the boot loader needs access to secondary disks. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/boot.c | 2 ++ src/Kconfig | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/src/boot.c b/src/boot.c index 1effd802ce06..771d2382e38f 100644 --- a/src/boot.c +++ b/src/boot.c @@ -299,6 +299,8 @@ u8 is_bootprio_strict(void) { static int prio_halt = -2; + if (!CONFIG_BOOT_FAST_INIT) + return 0; if (prio_halt == -2) prio_halt = find_prio("HALT"); return prio_halt >= 0; diff --git a/src/Kconfig b/src/Kconfig index 3a8ffa15fded..6b750a41b42c 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -72,6 +72,16 @@ endchoice help Support controlling of the boot order via the fw_cfg/CBFS "bootorder" file. + config BOOT_FAST_INIT + depends on BOOTORDER + bool "Fast boot device init" + default y + help + Skip initialization for devices without bootindex. Speeds + up boot and reduced memory footprint, but may cause boot + problems in case the bootloader needs access to secondary + disks. + config HOST_BIOS_GEOMETRY depends on BOOT bool "Boot device bios geometry override" -- 2.30.2

3 5

SeaBIOS debugging - breakpoint placement problems
by Krzysztof Bordon 14 Apr '21

14 Apr '21

Hello, I am experiencing problems with effective breakpoint setting at particular addresses while debugging Seabios with GNU GDB. The problem is that placing a breakpoint at an address (i.e.) *0xc3a8a, which belongs to vgabios region, and specifying an ignore count say 5 should make the gdb stop at it after it hits 5 times the address (on the 6th hit), but it never does - it seems to ignore the "ignore count" and stop on the next crossing instead. The same happens with some other addresses, like 0xf732a. What's more - the output of "info b" command shows that ignore counter is not updated after a hit. I suppose the reason for this misbehavior might be that those addresses belong to regions that are read only - the 0xc3a8a is a vga rom address and the 0xf732a lies somewhere in the rodata section. But if that was the case, hardware breakpoints could work, but neither those can. This is the example session showing the problem: $ ./qemu-system-x86_64 -s -S -singlestep -machine type=q35 -m 4096 -bios ~/Pobrane/seabios_1.14.0.orig/seabios-1.14.0/out/bios.bin $ $ gdb -q (gdb) target remote localhost:1234 Remote debugging using localhost:1234 warning: No executable has been specified and target does not support determining executable automatically. Try using the "file" command. 0x000000000000fff0 in ?? () (gdb) b *0xf732a Breakpoint 1 at 0xf732a (gdb) ignore 1 5 Will ignore next 5 crossings of breakpoint 1. (gdb) c Continuing. Program received signal SIGTRAP, Trace/breakpoint trap. 0x000000000000732a in ?? () (gdb) info b Num Type Disp Enb Address What 1 breakpoint keep y 0x00000000000f732a ignore next 5 hits (gdb) c Continuing. Program received signal SIGTRAP, Trace/breakpoint trap. 0x000000000000732a in ?? () (gdb) info b Num Type Disp Enb Address What 1 breakpoint keep y 0x00000000000f732a ignore next 5 hits I am using qemu 5.2.0, GNU gdb (Ubuntu 9.2-0ubuntu2) 9.2, and SeaBIOS 1.14.0 Is it possible to set a bp on any of the mentioned addresses so that their ignore counters are taken into account ?

1 0

Bump max MPTABLE and SMBIOS sizes from 600 to 768
by Mike Banon 04 Apr '21

04 Apr '21

There are plenty of coreboot platforms whose MPTABLE size is just slightly larger than the current uneven limit of 600 bytes, which prevents these important tables from being copied. For example, G505S has 628 bytes and A88XM-E has 740 bytes. I propose 768 bytes as a new saner default for MPTABLE size, to replace the current uneven limit of 600. SMBIOS size should be bumped the similar way as well. Signed-off-by: Mike Banon <mikebdp2 at gmail.com> --- diff --git a/src/config.h b/src/config.h index 93c8dbc..71333f8 100644 --- a/src/config.h +++ b/src/config.h @@ -21,9 +21,9 @@ // Largest supported externaly facing drive id #define BUILD_MAX_EXTDRIVE 16 // Number of bytes the smbios may be and still live in the f-segment -#define BUILD_MAX_SMBIOS_FSEG 600 +#define BUILD_MAX_SMBIOS_FSEG 768 // Maximum number of bytes the mptable may be and still be copied to f-segment -#define BUILD_MAX_MPTABLE_FSEG 600 +#define BUILD_MAX_MPTABLE_FSEG 768 #define BUILD_MODEL_ID 0xFC #define BUILD_SUBMODEL_ID 0x00

2 5

[PATCH] malloc: Add check to avoid dereference NULL pointer.
by likejun (A) 03 Apr '21

03 Apr '21

From: Kejun Li <likejun6(a)huawei.com<mailto:likejun6@huawei.com>> Date: Mon, 22 Mar 2021 14:03:10 +0800 Subject: [PATCH] malloc: Add check to avoid dereference NULL pointer. info = alloc_find_lowest() may return NULL, should check before dereference it to avoid potential coredump. Signed-off-by: Kejun Li <likejun6(a)huawei.com<mailto:likejun6@huawei.com>> --- src/malloc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/malloc.c b/src/malloc.c index 3733855..d355b77 100644 --- a/src/malloc.c +++ b/src/malloc.c @@ -544,10 +544,12 @@ malloc_prepboot(void) // Clear unused f-seg ram. struct allocinfo_s *info = alloc_find_lowest(&ZoneFSeg); - u32 size = info->range_end - info->range_start; - memset(memremap(info->range_start, size), 0, size); - dprintf(1, "Space available for UMB: %x-%x, %x-%x\n" - , RomEnd, base, info->range_start, info->range_end); + if (info) { + u32 size = info->range_end - info->range_start; + memset(memremap(info->range_start, size), 0, size); + dprintf(1, "Space available for UMB: %x-%x, %x-%x\n" + , RomEnd, base, info->range_start, info->range_end); + } // Give back unused high ram. info = alloc_find_lowest(&ZoneHigh); -- 2.19.1

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS April 2021