SeaBIOS August 2016

seabios@seabios.org

14 participants
25 discussions

[PATCH 1/2] swcursor: Move swcursor code from vgafb.c to new file swcursor.c
by Kevin O'Connor 05 Aug '16

05 Aug '16

Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- Makefile | 2 +- vgasrc/swcursor.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ vgasrc/vgabios.h | 2 ++ vgasrc/vgafb.c | 57 ------------------------------------------------ 4 files changed, 68 insertions(+), 58 deletions(-) create mode 100644 vgasrc/swcursor.c diff --git a/Makefile b/Makefile index 4930b3a..41bfcf4 100644 --- a/Makefile +++ b/Makefile @@ -207,7 +207,7 @@ $(OUT)bios.bin.elf: $(OUT)rom.o $(OUT)bios.bin.prep # VGA src files SRCVGA=src/output.c src/string.c src/hw/pci.c src/hw/serialio.c \ - vgasrc/vgainit.c vgasrc/vgabios.c vgasrc/vgafb.c \ + vgasrc/vgainit.c vgasrc/vgabios.c vgasrc/vgafb.c vgasrc/swcursor.c \ vgasrc/vgafonts.c vgasrc/vbe.c \ vgasrc/stdvga.c vgasrc/stdvgamodes.c vgasrc/stdvgaio.c \ vgasrc/clext.c vgasrc/bochsvga.c vgasrc/geodevga.c \ diff --git a/vgasrc/swcursor.c b/vgasrc/swcursor.c new file mode 100644 index 0000000..35f857a --- /dev/null +++ b/vgasrc/swcursor.c @@ -0,0 +1,65 @@ +// Virtual software based cursor support +// +// Copyright (C) 2014-2016 Kevin O'Connor <kevin(a)koconnor.net> +// +// This file may be distributed under the terms of the GNU LGPLv3 license. + +#include "biosvar.h" // GET_BDA +#include "vgabios.h" // handle_gfx_op + +// Draw/undraw a cursor on the framebuffer by xor'ing the cursor cell +static void +gfx_set_swcursor(struct vgamode_s *vmode_g, int enable, struct cursorpos cp) +{ + u16 cursor_type = get_cursor_shape(); + u8 start = cursor_type >> 8, end = cursor_type & 0xff; + struct gfx_op op; + init_gfx_op(&op, vmode_g); + op.x = cp.x * 8; + int cheight = GET_BDA(char_height); + op.y = cp.y * cheight + start; + + int i; + for (i = start; i < cheight && i <= end; i++, op.y++) { + op.op = GO_READ8; + handle_gfx_op(&op); + int j; + for (j = 0; j < 8; j++) + op.pixels[j] ^= 0x07; + op.op = GO_WRITE8; + handle_gfx_op(&op); + } +} + +// Draw/undraw a cursor on the screen +void +vgafb_set_swcursor(int enable) +{ + if (!vga_emulate_text()) + return; + u8 flags = GET_BDA_EXT(flags); + if (!!(flags & BF_SWCURSOR) == enable) + // Already in requested mode. + return; + struct vgamode_s *vmode_g = get_current_mode(); + if (!vmode_g) + return; + struct cursorpos cp = get_cursor_pos(GET_BDA(video_page)); + if (cp.x >= GET_BDA(video_cols) || cp.y > GET_BDA(video_rows) + || GET_BDA(cursor_type) >= 0x2000) + // Cursor not visible + return; + + SET_BDA_EXT(flags, (flags & ~BF_SWCURSOR) | (enable ? BF_SWCURSOR : 0)); + + if (GET_GLOBAL(vmode_g->memmodel) != MM_TEXT) { + gfx_set_swcursor(vmode_g, enable, cp); + return; + } + + // In text mode, swap foreground and background attributes for cursor + void *dest_far = text_address(cp) + 1; + u8 attr = GET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far); + attr = (attr >> 4) | (attr << 4); + SET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far, attr); +} diff --git a/vgasrc/vgabios.h b/vgasrc/vgabios.h index 9fbfb14..9764020 100644 --- a/vgasrc/vgabios.h +++ b/vgasrc/vgabios.h @@ -132,6 +132,8 @@ void vgafb_write_char(struct cursorpos cp, struct carattr ca); struct carattr vgafb_read_char(struct cursorpos cp); void vgafb_write_pixel(u8 color, u16 x, u16 y); u8 vgafb_read_pixel(u16 x, u16 y); + +// swcursor.c void vgafb_set_swcursor(int enable); // vbe.c diff --git a/vgasrc/vgafb.c b/vgasrc/vgafb.c index bd1c8dd..46a1ab8 100644 --- a/vgasrc/vgafb.c +++ b/vgasrc/vgafb.c @@ -497,30 +497,6 @@ fail: return (struct carattr){0, 0, 0}; } -// Draw/undraw a cursor on the framebuffer by xor'ing the cursor cell -void -gfx_set_swcursor(struct vgamode_s *vmode_g, int enable, struct cursorpos cp) -{ - u16 cursor_type = get_cursor_shape(); - u8 start = cursor_type >> 8, end = cursor_type & 0xff; - struct gfx_op op; - init_gfx_op(&op, vmode_g); - op.x = cp.x * 8; - int cheight = GET_BDA(char_height); - op.y = cp.y * cheight + start; - - int i; - for (i = start; i < cheight && i <= end; i++, op.y++) { - op.op = GO_READ8; - handle_gfx_op(&op); - int j; - for (j = 0; j < 8; j++) - op.pixels[j] ^= 0x07; - op.op = GO_WRITE8; - handle_gfx_op(&op); - } -} - // Set the pixel at the given position. void vgafb_write_pixel(u8 color, u16 x, u16 y) @@ -686,36 +662,3 @@ vgafb_read_char(struct cursorpos cp) u16 v = GET_FARVAR(GET_GLOBAL(vmode_g->sstart), *dest_far); return (struct carattr){v, v>>8, 0}; } - -// Draw/undraw a cursor on the screen -void -vgafb_set_swcursor(int enable) -{ - if (!vga_emulate_text()) - return; - u8 flags = GET_BDA_EXT(flags); - if (!!(flags & BF_SWCURSOR) == enable) - // Already in requested mode. - return; - struct vgamode_s *vmode_g = get_current_mode(); - if (!vmode_g) - return; - struct cursorpos cp = get_cursor_pos(GET_BDA(video_page)); - if (cp.x >= GET_BDA(video_cols) || cp.y > GET_BDA(video_rows) - || GET_BDA(cursor_type) >= 0x2000) - // Cursor not visible - return; - - SET_BDA_EXT(flags, (flags & ~BF_SWCURSOR) | (enable ? BF_SWCURSOR : 0)); - - if (GET_GLOBAL(vmode_g->memmodel) != MM_TEXT) { - gfx_set_swcursor(vmode_g, enable, cp); - return; - } - - // In text mode, swap foreground and background attributes for cursor - void *dest_far = text_address(cp) + 1; - u8 attr = GET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far); - attr = (attr >> 4) | (attr << 4); - SET_FARVAR(GET_GLOBAL(vmode_g->sstart), *(u8*)dest_far, attr); -} -- 2.5.5

1 1

[PATCH v2 0/6] tpm: Extend PCRs in all available PCR banks
by Stefan Berger 04 Aug '16

04 Aug '16

This series of patches extends the TPM2 code to extend the BIOS related PCRs 0-7 in all available banks. This prevents that these PCRs remain untouched and filled with bogus values by applications. For example, the SHA1 hash is extended into the SHA256 bank. The value that is extended into this bank is essentially a SHA1 with zero bytes used for filling it to the size of a sha256 hash. This is done for all PCR banks of the TPM2 where these PCRs are available. In v2 of this series I also extended the log functions for logging the additional hashes. So there are more patches now. Regards, Stefan Stefan Berger (6): tpm: Retrieve the PCR Bank configuration tpm: Restructure tpm20_extend to use buffer and take hash as parameter tpm: Extend tpm20_extend to support extending to multiple PCR banks tpm: Move tpm_log_init to a later point tpm: Adjust the TPM2 log header to show all hashes tpm: Append to TPM2 log the hashes used for PCR extension src/std/tcg.h | 78 +++++++++++-- src/tcgbios.c | 348 ++++++++++++++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 371 insertions(+), 55 deletions(-) -- 2.5.5

2 10

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm can not be reset any more
by Kevin O'Connor 03 Aug '16

03 Aug '16

On Tue, Aug 02, 2016 at 04:18:30AM +0000, Xulei (Stone) wrote: > >On Fri, Jul 29, 2016 at 04:04:59AM +0000, Xulei (Stone) wrote: > >> After one day, the vm is stuck. Looking from the following seabios log, > >> it seems seabios stops at "PCI: Using 00:02.0 for primary VGA", and can > >> not execute handle_smp() any more. > >> What may be the reason? > > > >More debugging info would be necessary to find this problem. You > >could try reproducing and attaching gdb ( > >http://www.seabios.org/Debugging#Debugging_with_gdb_on_QEMU ). > >Alternatively, a kvm trace log may help. > > > kvm trace (seems useful) indicates that cpu 0 keeps always to access 0x00b3 ioport. > 0x00b3 is PORT_SMI_STATUS, so i guess my bios is stuck in the function > smm_relocate_and_restore > { > ... > /* wait until SMM code executed */ > while (inb(PORT_SMI_STATUS) != 0x00) > ... > } I'd try adding dprintf() statements around all the code at the top of smm_relocate_and_restore() and enable the dprintf() at the top of handle_smi(). It would also be useful if you can extract the log from the last two working reboots to compare it to the failed case. -Kevin

2 1

[BUG?] Doesn't retrieve control after coreboot payload return
by Antonello Dettori 02 Aug '16

02 Aug '16

Hi everyone. I'm currently working on coreboot but I stumbled on a strange SeaBIOS behaviour. After executing a payload and returning control to the caller SeaBIOS crashes. The problem is currently solved by rebooting before the payload returns but doing so also makes chaining multiple payloads impossible so I'm trying to look into a solution. I tried to increment the debug level to 8 to get more information and the attached log is what I got. I also attached a build of coreboot with this problem if someone wants to try it in QEMU. I'm not terribly knowledgeable about SeaBIOS so I'm a bit lost. Could anyone point me where the problem could be originating from? Thanks in advance, Antonello Dettori

2 4

Re: [SeaBIOS] [QUESTION]stuck in SeaBIOS and vm can not be reset any more
by Kevin O'Connor 02 Aug '16

02 Aug '16

On Fri, Jul 29, 2016 at 04:04:59AM +0000, Xulei (Stone) wrote: > Hi, all: > Recently when i try to reset a vm, I find it may be stuck in SeaBIOS. > I use a shell script to continuously reset a vm to see what may happen. > > #!/bin/bash > while((1)) > do > virsh reset VMNAME > sleep 1 > done > > After one day, the vm is stuck. Looking from the following seabios log, > it seems seabios stops at "PCI: Using 00:02.0 for primary VGA", and can > not execute handle_smp() any more. > What may be the reason? More debugging info would be necessary to find this problem. You could try reproducing and attaching gdb ( http://www.seabios.org/Debugging#Debugging_with_gdb_on_QEMU ). Alternatively, a kvm trace log may help. -Kevin

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS August 2016