SeaBIOS March 2014

seabios@seabios.org

10 participants
17 discussions

[PATCH] smbios: Default all values to zero.
by Kevin O'Connor 11 Mar '14

11 Mar '14

Make sure to initialize the entire smbios area to zero so that any field not explicitly initialized does not have random values. (It was found that the memory_error_information_handle field in smbios_type_17 was not being set.) Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/fw/smbios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/fw/smbios.c b/src/fw/smbios.c index 55c662a..0c6a5b2 100644 --- a/src/fw/smbios.c +++ b/src/fw/smbios.c @@ -522,6 +522,7 @@ smbios_setup(void) warn_noalloc(); return; } + memset(start, 0, TEMPSMBIOSSIZE); u32 nr_structs = 0, max_struct_size = 0; char *q, *p = start; -- 1.8.5.3

1 0

SeaBios for Stout Lenovo X131e chromebook
by Inez G 11 Mar '14

11 Mar '14

My apologies for posting, if this is the wrong forum. I would like to add SeaBios to my coreboot.rom (google_stout.2817.52.0) for a Lenovo X131e chromebook (Celeron 1007u cpu, 4 GB ram, 8 MB Winbond bios flash chip). I was thinking of building seabios using the repository at https://chromium.googlesource.com/chromiumos/third_party/seabios/+/master/s… and come up with a SeaBios.CBFS file as suggested in the 15th post in https://plus.google.com/117057264318218846563/posts/FXn39JtNUAa Since the above article is for a Pixel chromebook, where would I insert/merge this SeaBios file with the backup.bin file that I read from the Winbond chip with flashrom -p internal -r backup.bin -o backup.log The merged file would be "newrom.bin" which I can then hopefully write with flashrom -w newrom.bin In the linked article they suggested flashrom -w image.rom -i RW_LEGACY but that is for the Pixel chromebook (which has the legacy boot). The Lenovo X131e does not have legacy boot (so there is no RW_LEGACY section, just "fallback/payload". Should I replace the "fallback/payload"section in my current backup.bin file with the new SeaBios??

2 1

Re: [SeaBIOS] Does seabios support USB device hot plug?
by Kevin O'Connor 11 Mar '14

11 Mar '14

On Tue, Mar 11, 2014 at 06:11:19PM +0800, WANG Siyuan wrote: > Hi > I use seabios as coreboot payload. It seems that seabios does not support > USB device hot plug. > For example, I use a USB keyboard connect to a mainboard. When booting to > GRUB, keyboard works. If I unplug the USB keyboard and plug it again, the > keyboard doesn't work. > > Does seabios support USB device hot plug? As you stated, SeaBIOS does not support USB devices that are plugged in after boot up. -Kevin

1 0

Does seabios support USB device hot plug?
by WANG Siyuan 11 Mar '14

11 Mar '14

Hi I use seabios as coreboot payload. It seems that seabios does not support USB device hot plug. For example, I use a USB keyboard connect to a mainboard. When booting to GRUB, keyboard works. If I unplug the USB keyboard and plug it again, the keyboard doesn't work. Does seabios support USB device hot plug? Yours sincerely, WANG Siyuan

1 0

[PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2
by Gabriel L. Somlo 06 Mar '14

06 Mar '14

Add v2.3 fields to Type 17 (Memory Device) structure. Add Type 2 (Baseboard) structure. "About This Mac" on OS X guests will crash and restart the GUI if Type 17 structures are not compliant with at least v2.3 of the SMBIOS/DMI spec. OS X 10.7 and 10.8 will panic during boot if a Type 2 (Baseboard) structure is not present in the SMBIOS. Signed-off-by: Gabriel Somlo <somlo(a)cmu.edu> --- On Fri, Feb 07, 2014 at 04:37:58PM +0100, Paolo Bonzini wrote: >Il 06/02/2014 14:38, Gabriel L. Somlo ha scritto: >>On Wed, Feb 05, 2014 at 08:02:25PM -0500, Kevin O'Connor wrote: >>> Thanks. In general, though, it is preferred to make smbios changes at >>> the QEMU layer. Indeed, going forward, I'd like to see all the smbios >>> stuff moved up to QEMU. >>> >>> Is there something in these two patches that can't be done in QEMU? >> >> But anyhow, right now QEMU seems to be making relatively minor tweaks >> to something that's firmly at home in SeaBIOS, which is why I sent my >> patches to the latter... > >Yeah, that's correct. There's really no particular hook in QEMU to do this. Would it be OK to apply this in SeaBIOS now, so that 1. it can be useful until whenever SMBIOS gets transferred/absorbed into QEMU, and 2. it won't fall through the cracks when that transition happens ? Thanks much, Gabriel src/fw/smbios.c | 42 ++++++++++++++++++++++++++++++++++++++++++ src/std/smbios.h | 22 ++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/src/fw/smbios.c b/src/fw/smbios.c index 55c662a..5b76468 100644 --- a/src/fw/smbios.c +++ b/src/fw/smbios.c @@ -251,6 +251,41 @@ smbios_init_type_1(void *start) return end; } +/* Type 2 -- Base Board */ +static void * +smbios_init_type_2(void *start) +{ + struct smbios_type_2 *p = (struct smbios_type_2 *)start; + char *end = (char *)start + sizeof(struct smbios_type_2); + size_t size; + int str_index = 0; + + p->header.type = 2; + p->header.length = sizeof(struct smbios_type_2); + p->header.handle = 0x200; + + load_str_field_with_default(2, manufacturer_str, BUILD_APPNAME); + load_str_field_or_skip(2, product_str); + load_str_field_or_skip(2, version_str); + load_str_field_or_skip(2, serial_number_str); + load_str_field_or_skip(2, asset_tag_number_str); + load_str_field_or_skip(2, location_str); + + set_field_with_default(2, feature_flags, 0x01); /* Motherboard */ + set_field_with_default(2, chassis_handle, 0x300); /* T3 System Enclosure */ + set_field_with_default(2, board_type, 0x0a); /* Motherboard */ + set_field_with_default(2, contained_element_count, 0); + + *end = 0; + end++; + if (!str_index) { + *end = 0; + end++; + } + + return end; +} + /* Type 3 -- System Enclosure */ static void * smbios_init_type_3(void *start) @@ -417,6 +452,12 @@ smbios_init_type_17(void *start, u32 size_mb, int instance) set_field_with_default(17, memory_type, 0x07); /* RAM */ set_field_with_default(17, type_detail, 0); + set_field_with_default(17, speed, 0); /* unknown */ + load_str_field_or_skip(17, manufacturer_str); + load_str_field_or_skip(17, serial_number_str); + load_str_field_or_skip(17, asset_tag_number_str); + load_str_field_or_skip(17, part_number_str); + *end = 0; end++; if (!str_index) { @@ -540,6 +581,7 @@ smbios_setup(void) add_struct(0, p); add_struct(1, p); + add_struct(2, p); add_struct(3, p); int cpu_num; diff --git a/src/std/smbios.h b/src/std/smbios.h index 0513716..86a4c57 100644 --- a/src/std/smbios.h +++ b/src/std/smbios.h @@ -59,6 +59,22 @@ struct smbios_type_1 { u8 family_str; } PACKED; +/* SMBIOS type 2 - Base Board */ +struct smbios_type_2 { + struct smbios_structure_header header; + u8 manufacturer_str; + u8 product_str; + u8 version_str; + u8 serial_number_str; + u8 asset_tag_number_str; + u8 feature_flags; + u8 location_str; + u16 chassis_handle; + u8 board_type; + u8 contained_element_count; + // contained elements follow +} PACKED; + /* SMBIOS type 3 - System Enclosure (v2.3) */ struct smbios_type_3 { struct smbios_structure_header header; @@ -127,6 +143,12 @@ struct smbios_type_17 { u8 bank_locator_str; u8 memory_type; u16 type_detail; + /* v2.3 fields: */ + u16 speed; + u8 manufacturer_str; + u8 serial_number_str; + u8 asset_tag_number_str; + u8 part_number_str; } PACKED; /* SMBIOS type 19 - Memory Array Mapped Address */ -- 1.8.1.4

4 23

[PATCH] vga: rework bar detection, add virtio-vga
by Gerd Hoffmann 06 Mar '14

06 Mar '14

Replace the heuristic which checks the bar 0 attributes to figure whenever bar 0 or bar 1 has the linear framebuffer with a vendor id check. Add support for virtio-vga which uses bar 2 for the linear framebuffer. Cc: Dave Airlie <airlied(a)redhat.com> Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- vgasrc/bochsvga.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/vgasrc/bochsvga.c b/vgasrc/bochsvga.c index 6da9d5d..b802be1 100644 --- a/vgasrc/bochsvga.c +++ b/vgasrc/bochsvga.c @@ -402,12 +402,20 @@ bochsvga_setup(void) u32 lfb_addr = VBE_DISPI_LFB_PHYSICAL_ADDRESS; int bdf = GET_GLOBAL(VgaBDF); if (CONFIG_VGA_PCI && bdf >= 0) { - int barid = 0; - u32 bar = pci_config_readl(bdf, PCI_BASE_ADDRESS_0); - if ((bar & PCI_BASE_ADDRESS_SPACE) != PCI_BASE_ADDRESS_SPACE_MEMORY) { + u16 vendor = pci_config_readw(bdf, PCI_VENDOR_ID); + int barid; + switch (vendor) { + case 0x15ad: /* qemu vmware vga */ barid = 1; - bar = pci_config_readl(bdf, PCI_BASE_ADDRESS_1); + break; + case 0x1af4: /* virtio-vga */ + barid = 2; + break; + default: /* stdvga, qxl */ + barid = 0; + break; } + u32 bar = pci_config_readl(bdf, PCI_BASE_ADDRESS_0 + barid * 4); lfb_addr = bar & PCI_BASE_ADDRESS_MEM_MASK; dprintf(1, "VBE DISPI: bdf %02x:%02x.%x, bar %d\n", pci_bdf_to_bus(bdf) , pci_bdf_to_dev(bdf), pci_bdf_to_fn(bdf), barid); -- 1.8.3.1

2 2

Re: [SeaBIOS] [PATCH] vgabios: Fix PMM allocation request size.
by Kevin O'Connor 05 Mar '14

05 Mar '14

On Tue, Feb 18, 2014 at 01:53:08PM -0500, Kevin O'Connor wrote: > The size of a PMM memory request is in "paragraphs" so the size needs > to be divided by 16. Fix the request so only the desired 512 bytes is > allocated instead of 8K. FYI, I have pushed this change. -Kevin

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS March 2014