SeaBIOS February 2014

seabios@seabios.org

20 participants
31 discussions

PC-BSD installer does not boot with 1.7.4 (bisected)
by Michael Tokarev 17 Feb '14

17 Feb '14

We have a bugreport in debian, http://bugs.debian.org/737142, stating that PC-BSD does not work with seabios-1.7.4 anymore. I digged in, and found out that it fails only with -vga std (cirrus works fine). So I bisected the issue - only changing vgabios-stdvga.bin, and found this: 9332f9b172dd59253365a83b5f1c0e40c5f6f66d is the first bad commit commit 9332f9b172dd59253365a83b5f1c0e40c5f6f66d Author: Kevin O'Connor <kevin(a)koconnor.net> Date: Sat Nov 30 12:52:44 2013 -0500 vgabios: Work around lack of support for "calll" in x86emu emulation. Replace 32 bit call instructions with 16 bit call instructions in the vgabios to workaround problems in old versions of x86emu. This change allows fc13 and fc14 to boot. (Other x86emu emulation bugs still prevent fc11 and fc12 from booting.) I'm not sure what is better - to have semi-working FC13 or non-working PC-BSD ;) Seriously, I don't really have any expirience in this area to understand what's going on. Note that PC-BSD fails clearly in some VGA-related code, and this is trivially reproducible. Thanks, /mjt

3 7

[PATCH 1/2] Add config option to move PORT_ACPI_PM_BASE out of the way
by Gerd Hoffmann 17 Feb '14

17 Feb '14

Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/Kconfig | 7 +++++++ src/fw/paravirt.h | 9 +++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index cce3ad8..df3512d 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -309,6 +309,13 @@ menu "Hardware support" default y help Initialize the Memory Type Range Registers (on emulators). + config PMBASE_LOW + depends on QEMU + bool "Map ACPI PM below 0x1000" + default n + help + Map ACPI PM bar below 0x1000. This makes room in the io address + space for PCI bridges, but requires qemu 1.4+ to work correctly. config PMTIMER bool "Use ACPI timer" default y diff --git a/src/fw/paravirt.h b/src/fw/paravirt.h index 69d7248..64fe4c6 100644 --- a/src/fw/paravirt.h +++ b/src/fw/paravirt.h @@ -29,8 +29,13 @@ static inline int runningOnKVM(void) { #define PORT_SMI_STATUS 0x00b3 #define PORT_QEMU_CFG_CTL 0x0510 #define PORT_QEMU_CFG_DATA 0x0511 -#define PORT_ACPI_PM_BASE 0xb000 -#define PORT_SMB_BASE 0xb100 +#ifdef CONFIG_PMBASE_LOW +# define PORT_ACPI_PM_BASE 0x0600 +# define PORT_SMB_BASE 0x0700 +#else +# define PORT_ACPI_PM_BASE 0xb000 +# define PORT_SMB_BASE 0xb100 +#endif #define PORT_BIOS_APM 0x8900 void qemu_preinit(void); -- 1.8.3.1

2 7

[PATCH 0/4] SeaVGABIOS for native coreboot vga init
by Kevin O'Connor 12 Feb '14

12 Feb '14

This patch series enables support for writing to a framebuffer that has been setup by coreboot using its native VGA initialization. This may be a good solution for those wishing to run standard boot loaders and common operating systems without having to run a third part vgabios (on those systems where coreboot supports native vga init). -Kevin Kevin O'Connor (4): vgabios: Add option to control use of standard VGA IO ports and ranges. vgabios: Add support for writing text to framebuffers in high memory. coreboot: Make coreboot table searching available to other code. vgabios: Initial support for coreboot native vga vgabios. Makefile | 5 +- src/fw/coreboot.c | 58 ++++++++++-------- src/util.h | 3 + vgasrc/Kconfig | 26 +++++++++ vgasrc/cbvga.c | 169 +++++++++++++++++++++++++++++++++++++++++++++++++++++ vgasrc/cbvga.h | 20 +++++++ vgasrc/vgabios.c | 44 ++++++++++---- vgasrc/vgabios.h | 8 +++ vgasrc/vgafb.c | 40 +++++++++++-- vgasrc/vgahighfb.c | 154 ++++++++++++++++++++++++++++++++++++++++++++++++ vgasrc/vgahw.h | 27 +++++++++ vgasrc/vgainit.c | 3 +- 12 files changed, 514 insertions(+), 43 deletions(-) create mode 100644 vgasrc/cbvga.c create mode 100644 vgasrc/cbvga.h create mode 100644 vgasrc/vgahighfb.c -- 1.8.5.3

1 4

[PATCH] vgabios: Make sure stdvga_list_modes() doesn't overrun the buffer.
by Kevin O'Connor 12 Feb '14

12 Feb '14

Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- vgasrc/stdvgamodes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vgasrc/stdvgamodes.c b/vgasrc/stdvgamodes.c index a97c85f..8436729 100644 --- a/vgasrc/stdvgamodes.c +++ b/vgasrc/stdvgamodes.c @@ -336,7 +336,7 @@ void stdvga_list_modes(u16 seg, u16 *dest, u16 *last) { int i; - for (i = 0; i < ARRAY_SIZE(vga_modes); i++) { + for (i = 0; i < ARRAY_SIZE(vga_modes) && dest < last; i++) { struct stdvga_mode_s *stdmode_g = &vga_modes[i]; u16 mode = GET_GLOBAL(stdmode_g->mode); if (mode == 0xffff) -- 1.8.5.3

1 0

Re: [SeaBIOS] WfW setup and DOS display.sys hanging
by Gerd Hoffmann 10 Feb '14

10 Feb '14

[ adding seabios list ] On Di, 2014-02-04 at 20:47 +0100, Kevin Wolf wrote: > Hi Gerd, > > Am 09.01.2014 um 00:20 hat Sebastian geschrieben: > > Hi, > > > > I noticed in newer versions of Qemu (Debian Jessie) a regression > > causing DISPLAY.SYS from MS-DOS 6.22 to hang the system as soon as > > loaded. > > now that you sent a pull request for a SeaBIOS update, I tried what > would happen with this one. Sadly, while it does fix my hanging Win 7 > boot, DOS still hangs while loading display.sys. [ This is http://www.kraxel.org/cgit/qemu/tag/?id=pull-roms-1 with the 1.7.4 update ] Digged out my prehistoric msdos floppy images. Can confirm the hang. Using default vga (i.e. cirrus). Switching back to lgplvgabios ("make -C roms lgplvgabios" in qemu src tree) makes the hang go away. > Any ideas where to look, or are you going to have a look yourself? When > I tried to debug it a while ago, I didn't see anything obvious, but then > I didn't invest that much time for it either. "perf kvm stat live" shows tons of NMIs: VM-EXIT Samples Samples% Time% Min Time Max Time Avg time EXCEPTION_NMI 660538 99.82% 99.40% 0us 183us 0.67us ( +- 0.14% ) EXTERNAL_INTERRUPT 1133 0.17% 0.58% 0us 43us 2.25us ( +- 4.86% ) IO_INSTRUCTION 18 0.00% 0.01% 1us 5us 3.39us ( +- 6.50% ) PENDING_INTERRUPT 17 0.00% 0.01% 1us 11us 2.15us ( +- 26.24% ) How can one get a trace log of all the kvm tracepoints these days? 'perf list' shows a bunch of kvm trace events, but "perf trace -e '*kvm*' doesn't show me anything ... cheers, Gerd > I haven't tried out any of the other cases described below. [ keeping full quote for seabios list ] > > > > The Windows for Workgroups 3.11 SETUP.EXE file hangs with a cleared > > screen and the cursor blinking in the top left of the screen. The > > DOSIDLE.EXE[1] file hangs after printing out some system > > information. > > > > Git-Bisecting returned "roms: update vgabios binaries" (commit > > 6eefccc0bb9c34051b1e21880fc3a1c1c8686edd) as the bad commit. > > > > I tested the i386-softmmu target on Debian 7.3 (wheezy), x86_64 host > > and gcc 4.7.2 (Debian 4.7.2-5) without KVM support. > > > > [1] Source and binary are available e.g. at > > http://maribu.home.xs4all.nl/zeurkous/download/mirror/dosidle/ > > > > Best Regards, > > Sebastian

3 8

Re: [SeaBIOS] [PATCH] vgabios: Simplify save/restore mechanism.
by Kevin O'Connor 10 Feb '14

10 Feb '14

On Wed, Feb 05, 2014 at 08:59:39PM -0500, Kevin O'Connor wrote: > Reorganize the save/restore functions to eliminate some boilerplate > code. FYI, I have pushed this patch and the other VGABIOS patches. -Kevin

1 0

Re: [SeaBIOS] SeaBIOS causing Xen HVM VCPU Triple fault
by Michael Tokarev 10 Feb '14

10 Feb '14

07.02.2014 01:20, Moyer, Keith пишет: > Thank you all for your quick, helpful replies! > This was about to become a headache for us, so the identification of a fix so quickly is fantastic. > > On Thu, 2014-02-06 at 02:31 -0600, Gerd Hoffmann wrote: >> That commit made seabios size (default qemu config, gcc 4.7+) jump >> from 128k to 256k in size because the code didn't fit into 128k any more. > > Makes sense. Thanks for the explanation. > > On Thu, 2014-02-06 at 02:37 -0600, Ian Campbell wrote: >> I think this was fixed in Xen with >> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=5f2875739beef3a75c7a7e8… > > I have confirmed that applying that patch to our Xen sources fixes the problem. > > I've filed a bug with Debian's Xen package on this matter, with the hope they'll backport that commit. > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737905 Meanwhile I just uploaded another release of seabios to Debian archive which brings size of bios.bin back to 128Kb, by disabling XCHI (usb3.0) and PVSCSI -- 1.7.4-3. So things should be working fine on debian side again now (at least on sid), even without patching xen. And it looks like we should re-think what we remove from our (qemu) "stripped-down" bios - as it turns out, Xen actually uses bios from qemu unchanged... But it is really really fragile - on my build (gcc 4.7), with 2 options removed, 128Kb is 99.7% used ;) Thanks, /mjt

2 5

Re: [SeaBIOS] [coreboot] Setting up build environment
by Peter Stuge 10 Feb '14

10 Feb '14

Idwer Vollering wrote: > Actually, this happens when you clone coreboot into a dir where its > parent dir has a dot in it, and compile for any board without touching > the payload defaults: > > python ./tools/acpi_extract.py > /home/idwer/tmp/coreboot.fresh/build/seabios/out/acpi-dsdt.lst > > /home/idwer/tmp/coreboot.fresh/build/seabios/out/acpi-dsdt.off > Traceback (most recent call last): > File "./tools/acpi_extract.py", line 221, in <module> > for line in fileinput.input(): > File "/usr/lib/python2.7/fileinput.py", line 252, in next > line = self.readline() > File "/usr/lib/python2.7/fileinput.py", line 344, in readline > self._file = open(self._filename, self._mode) > IOError: [Errno 2] No such file or directory: > '/home/idwer/tmp/coreboot.fresh/build/seabios/out/acpi-dsdt.lst' The path isn't mangled in any way so the problem must be a dependency in the Makefile. Perhaps there's a pattern substitution which doesn't do greedy patterh matching where that's what would be needed. //Peter

1 0

Re: [SeaBIOS] [coreboot] Setting up build environment
by Idwer Vollering 10 Feb '14

10 Feb '14

Adding seabios at seabios dot org to the recipients. 2014-02-10 0:47 GMT+01:00 Andy Pont <andy.pont(a)sdcsystems.com>: > Hello! > >> Apparently CentOS installs, or will install, a really old version of >> iasl; here you'll see that they (still) use >> iasl-20090123-3.1.el6.x86_64: >> http://mirror.centos.org/centos/6.5/os/x86_64/Packages/ while the xgcc >> version is 20130626. > > After doing some poking around it appears that IASL doesn't like the fact > that my home directory is /home/andy.pont and I assume that it is the dot > that is upsetting it as if I clone coreboot into a subdirectory under > /home/andy then the default configuration builds correctly. > > Thanks for your help and guidance, it is much appreciated. > > Andy. > Actually, this happens when you clone coreboot into a dir where its parent dir has a dot in it, and compile for any board without touching the payload defaults: python ./tools/acpi_extract.py /home/idwer/tmp/coreboot.fresh/build/seabios/out/acpi-dsdt.lst > /home/idwer/tmp/coreboot.fresh/build/seabios/out/acpi-dsdt.off Traceback (most recent call last): File "./tools/acpi_extract.py", line 221, in <module> for line in fileinput.input(): File "/usr/lib/python2.7/fileinput.py", line 252, in next line = self.readline() File "/usr/lib/python2.7/fileinput.py", line 344, in readline self._file = open(self._filename, self._mode) IOError: [Errno 2] No such file or directory: '/home/idwer/tmp/coreboot.fresh/build/seabios/out/acpi-dsdt.lst' make[2]: *** [/home/idwer/tmp/coreboot.fresh/build/seabios/out/acpi-dsdt.hex] Error 1 make[1]: *** [build] Error 2 make: *** [seabios] Error 2 rm build/cbfs/fallback/romstage_null.elf build/util/sconfig/sconfig.tab.c build/cbfs/fallback/bootblock.elf build/util/sconfig/lex.yy.c

1 0

[PATCH] vgabios: Don't interpret TAB character.
by Kevin O'Connor 08 Feb '14

08 Feb '14

Several sources document that the Bell, Backspace, newline, and carriage return characters are interpreted by int 10/0e. There does not seem to be any references to that function interpreting tab. The original "lgpl vgabios" has code for interpreting tab, but the code is incorrect. Finally, tests on an ATI vgabios indicate that tab is not interpreted. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- vgasrc/vgabios.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/vgasrc/vgabios.c b/vgasrc/vgabios.c index b6d9dc2..65d325a 100644 --- a/vgasrc/vgabios.c +++ b/vgasrc/vgabios.c @@ -203,13 +203,6 @@ write_teletype(struct cursorpos *pcp, struct carattr ca) case '\n': cp.y++; break; - case '\t': - ca.car = ' '; - do { - vgafb_write_char(cp, ca); - cp.x++; - } while (cp.x < nbcols && cp.x % 8); - break; default: vgafb_write_char(cp, ca); cp.x++; -- 1.8.5.3

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS February 2014