SeaBIOS August 2013

seabios@seabios.org

24 participants
40 discussions

Re: [SeaBIOS] [PATCH v4] apm: fix shutdown
by Sebastian Herbszt 20 Aug '13

20 Aug '13

I wrote: > Can we get this change into SeaBIOS 1.7.2.x and 1.7.3.x? > It needs to end up in QEMU 1.4.x, 1.5.x and 1.6.0. Ping? Sebastian

2 1

Re: [SeaBIOS] Adapt SeaBIOS USB to my own OS
by Kevin O'Connor 19 Aug '13

19 Aug '13

On Tue, Aug 06, 2013 at 10:09:32PM +0200, dunedain1990 wrote: > Hi, > > I'm doing my own OS and i'm booting it from USB uhci. When it boots and it > arrives to the system code i want reading and writing from USB. > > First of all i take the usb.c, util.c, usb.h, usb_uhci.c, usb_uhci.h, > pci.c, pci.h, pciinit.c,... and put it into my sources and i compile it but > i need the romlayout.S that depends directly from bios's idt and not from > the idt from my OS. > > How can i do that? > > Do i need to call pci_setup() or something in the initialization of my own > OS? > > Are there some documentation to know how are the files connected and what > do the functions do? The SeaBIOS code isn't intended to be pulled out and used in other projects - there is a lot of code to handle BIOS quirks. I'm not sure why you'd want to re-use this code either - if you're working on code that will run in 16bit mode, you might as well just call the bios for read/writes to the disk, and if you're working on 32bit code, there are probably better references (eg, linux, freebsd, etc.). -Kevin

2 1

Re: [SeaBIOS] Configuring boot order
by Gerd Hoffmann 19 Aug '13

19 Aug '13

On Fr, 2013-08-16 at 18:35 +0000, Davidson Hom wrote: > I tried following the directions to configure the boot order at > http://www.coreboot.org/SeaBIOS#Configuring_boot_order. > > > > Testing with QEMU it did not appear to make a difference. Anyone have > any suggestions? CONFIG_QEMU_HARDWARE=n Otherwise the boot order configuration from qemu will overwrite your bootorder file in cbfs. cheers, Gerd

1 0

[PATCH] Minor - simplify rom_reserve().
by Kevin O'Connor 17 Aug '13

17 Aug '13

Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/pmm.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/pmm.c b/src/pmm.c index 1c8da1e..9ea4313 100644 --- a/src/pmm.c +++ b/src/pmm.c @@ -348,17 +348,14 @@ rom_get_last(void) struct rom_header * rom_reserve(u32 size) { - if (!CONFIG_MALLOC_UPPERMEMORY) { - if (RomEnd + size > rom_get_max()) - return NULL; - return (void*)RomEnd; - } - u32 newend = ALIGN(RomEnd + size, OPTION_ROM_ALIGN) + OPROM_HEADER_RESERVE; - if (newend > (u32)RomBase->allocend) + u32 newend = ALIGN(RomEnd + size, OPTION_ROM_ALIGN); + if (newend > rom_get_max()) return NULL; - if (newend < (u32)zonelow_base + OPROM_HEADER_RESERVE) - newend = (u32)zonelow_base + OPROM_HEADER_RESERVE; - RomBase->data = RomBase->dataend = (void*)newend; + if (CONFIG_MALLOC_UPPERMEMORY) { + if (newend < (u32)zonelow_base) + newend = (u32)zonelow_base; + RomBase->data = RomBase->dataend = (void*)newend + OPROM_HEADER_RESERVE; + } return (void*)RomEnd; } -- 1.7.11.7

1 0

Configuring boot order
by Davidson Hom 16 Aug '13

16 Aug '13

I tried following the directions to configure the boot order at http://www.coreboot.org/SeaBIOS#Configuring_boot_order. Testing with QEMU it did not appear to make a difference. Anyone have any suggestions?

1 0

Re: [SeaBIOS] [Qemu-devel] Test report for xen-unstable and qemu-xen
by Laszlo Ersek 16 Aug '13

16 Aug '13

CC'ing Gerd and the seabios list: On 08/13/13 11:16, Fabio Fantoni wrote: > Il 12/08/2013 17:04, Fabio Fantoni ha scritto: >> Dom0: >> Wheezy 64 bit with kernel from package linux-image-3.2.0-4-amd64 >> version 3.2.46-1 and all dependency packages for xen, spice and usb >> redirection. >> Seabios 1.7.3-1, qemu 1.5.0+dfsg-5 (1.5.1), spice 0.12.4-0nocelt1 and >> usbredir 0.6-2 compiled from debian unstable sources. >> ------------------------- >> git clone git://xenbits.xen.org/xen.git (in this build commit is >> 73f18583dd824f0e49f65149ef603600ce31b8ee) >> ------------------------- >> Added some patches: >> - tools-configure-qemu-for-spice-and-usbredir >> - libxl-Add-spice-vdagent-support-for-upstream-qemu v3 >> - libxl: usb2 and usb3 controller support for upstream qemu v4 >> - tools-firmware-seabios-packaged >> - tools: Improve make deb v3 >> - tools: remove or disable old/useless/unused/unmainted stuff (the >> whole series of 9 patches) >> ------------------------- >> ./configure --prefix=/usr --disable-xend >> ------------------------- >> make debball >> >> ------------------------- >> New issue: >> - domU not start with qemu 1.5.1 and more that 2 gb of ram: >> tested on w7 64 bit domU with 4 gb of ram, with built-in qemu 1.3 it >> works, >> while with qemu 1.5.1 doesn't (stops at the beginning, spice client >> show only the lines of seabios version and machine UUID; >> qemu log show nothing more that 2 gb test), while with 2 gb of ram >> works also with qemu 1.5.1 >> ------------------------- > > Added qemu-devel and debian maintainers to cc for this regression about > upstream qemu. > If you need more details and tests tell me and I'll do/post them. As a superficial guess, this could be fixed by the seabios-1.7.3.1 release: http://thread.gmane.org/gmane.comp.emulators.qemu/227536 http://code.coreboot.org/p/seabios/source/commit/2a9aeabdfb34374ecac25e7a8d… Laszlo > >> >> ------------------------- >> Old issue: >> - Network is not working after restore on Windows domU with qemu-xen >> and gplpv >> Workaround: fixed mac address >> ------------- >> - Starting xendomain with "xl create" show some debug options: >> Starting auto Xen domains: W7.cfgxc: info: VIRTUAL MEMORY ARRANGEMENT: >> Loader: 0000000000100000->000000000019eb68 >> Modules: 0000000000000000->0000000000000000 >> TOTAL: 0000000000000000->000000007f000000 >> ENTRY ADDRESS: 0000000000100000 >> xc: info: PHYSICAL MEMORY ALLOCATION: >> 4KB PAGES: 0x0000000000000200 >> 2MB PAGES: 0x00000000000003f7 >> 1GB PAGES: 0x0000000000000000 >> [done]. >> I think it is would be better hiding them here >> ------------- >> - on W7 pro 64 bit domU error in the begin of qemu log, while domU >> seem to work: >> xc: error: linux_gnttab_set_max_grants: ioctl SET_MAX_GRANTS failed >> (22 = Invalid argument): Internal error >> xen be: qdisk-832: xc_gnttab_set_max_grants failed: Invalid argument >> ------------- >> - nested hvm was bugged: started test it on windows 7 pro 64 domU on >> qemu-xen, >> xpmode crashed on install without show error, no error on logs and >> havdetection works >> Now xpmode install and start correctly except integration features >> (disks,printers,clipboard sharing) and usb passthrough (of xpmode) >> -------------------------

4 12

[PATCH] acpi: hide 64-bit PCI hole for Windows XP
by Igor Mammedov 14 Aug '13

14 Aug '13

Windows XP (32 and 64 bit) crashes if 64-bit PCI hole is present. Use _OSI ACPI method to blacklist it and hide 64-bit PCI hole. _OSI strings reported by XP are taken from here: http://msdn.microsoft.com/library/windows/hardware/gg463275 Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- src/acpi-dsdt.dsl | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 158f6b4..7b55636 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -33,6 +33,31 @@ DefinitionBlock ( /**************************************************************** + * OS detection + ****************************************************************/ + + Scope(\_SB) { + External(\P1V, IntObj) + + Method(_INI) { + If (CondRefOf (\_OSI, Local0)) { + /* disable 64-bit PCI window for Windows XP and its variants */ + If (\_OSI ("Windows 2001")) { + Store (Zero, P1V) + } + + If (\_OSI ("Windows 2001 SP1")) { + Store (Zero, P1V) + } + + If (\_OSI ("Windows 2001 SP2")) { + Store (Zero, P1V) + } + } + } + } + +/**************************************************************** * PCI Bus definition ****************************************************************/ -- 1.7.1

7 51

[PATCH v4] apm: fix shutdown
by Gerd Hoffmann 12 Aug '13

12 Aug '13

Qemu commit 9ee59f3 removed the bochs bios apm interface emulation at port 0x8900. That broke poweroff via APM. Fix it by powering off the machine using the acpi pm control register. Old code is left in, so seabios wil try both poweroff methods. Cleaning that eventually up is left for another patch, after checking it isn't needed. Qemu never implemented "Standby" and "Suspend", only "Shutdown", so it looks like there might be non-qemu use cases (bochs probably). Easiest way to test this is the syslinux poweroff module; modern linux distros usually have CONFIG_APM turned off. Reported-by: Sebastian Herbszt <herbszt(a)gmx.de> Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/acpi.c | 5 +++++ src/acpi.h | 1 + src/apm.c | 5 +++++ src/pciinit.c | 3 +++ 4 files changed, 14 insertions(+) diff --git a/src/acpi.c b/src/acpi.c index 3699898..1994838 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -18,6 +18,8 @@ #include "acpi-dsdt.hex" +u32 acpi_pm1a_cnt VARFSEG; + static void build_header(struct acpi_table_header *h, u32 sig, int len, u8 rev) { @@ -730,9 +732,12 @@ find_acpi_features(void) if (!fadt) return; u32 pm_tmr = le32_to_cpu(fadt->pm_tmr_blk); + u32 pm1a_cnt = le32_to_cpu(fadt->pm1a_cnt_blk); dprintf(4, "pm_tmr_blk=%x\n", pm_tmr); if (pm_tmr) pmtimer_setup(pm_tmr, 3579); + if (pm1a_cnt) + acpi_pm1a_cnt = pm1a_cnt; // Theoretically we should check the 'reset_reg_sup' flag, but Windows // doesn't and thus nobody seems to *set* it. If the table is large enough diff --git a/src/acpi.h b/src/acpi.h index 5d1e104..f0d24d4 100644 --- a/src/acpi.h +++ b/src/acpi.h @@ -36,6 +36,7 @@ struct rsdp_descriptor { /* Root System Descriptor Pointer */ }; extern struct rsdp_descriptor *RsdpAddr; +extern u32 acpi_pm1a_cnt; /* Table structure from Linux kernel (the ACPI tables are under the BSD license) */ diff --git a/src/apm.c b/src/apm.c index b2eac6d..de6bd99 100644 --- a/src/apm.c +++ b/src/apm.c @@ -12,6 +12,7 @@ #include "config.h" // CONFIG_* #include "biosvar.h" // GET_GLOBAL #include "paravirt.h" // runningOnQEMU +#include "acpi.h" // acpi_pm_ctl static void out_str(const char *str_cs) @@ -108,7 +109,11 @@ handle_155306(struct bregs *regs) void apm_shutdown(void) { + u16 pm1a_cnt = GET_GLOBAL(acpi_pm1a_cnt); + irq_disable(); + if (pm1a_cnt) + outw(0x2000, pm1a_cnt); out_str("Shutdown"); for (;;) hlt(); diff --git a/src/pciinit.c b/src/pciinit.c index 8370b96..0c6b0cb 100644 --- a/src/pciinit.c +++ b/src/pciinit.c @@ -15,6 +15,7 @@ #include "paravirt.h" // RamSize #include "dev-q35.h" // Q35_HOST_BRIDGE_PCIEXBAR_ADDR #include "list.h" // struct hlist_node +#include "acpi.h" // acpi_pm1a_cnt /* PM Timer ticks per second (HZ) */ #define PM_TIMER_FREQUENCY 3579545 @@ -194,6 +195,7 @@ void mch_isa_bridge_setup(struct pci_device *dev, void *arg) /* acpi enable, SCI: IRQ9 000b = irq9*/ pci_config_writeb(bdf, ICH9_LPC_ACPI_CTRL, ICH9_LPC_ACPI_CTRL_ACPI_EN); + acpi_pm1a_cnt = PORT_ACPI_PM_BASE + 0x04; pmtimer_setup(PORT_ACPI_PM_BASE + 0x08, PM_TIMER_FREQUENCY / 1000); } @@ -238,6 +240,7 @@ static void piix4_pm_setup(struct pci_device *pci, void *arg) pci_config_writel(bdf, 0x90, PORT_SMB_BASE | 1); pci_config_writeb(bdf, 0xd2, 0x09); /* enable SMBus io space */ + acpi_pm1a_cnt = PORT_ACPI_PM_BASE + 0x04; pmtimer_setup(PORT_ACPI_PM_BASE + 0x08, PM_TIMER_FREQUENCY / 1000); } -- 1.7.9.7

3 2

seabios 1.7.3.1 released
by Gerd Hoffmann 12 Aug '13

12 Aug '13

Hi, The seabios 1.7.3.1 bugfix release is out of the door. Here is the shortlog: Kevin O'Connor (2): Fix USB EHCI detection that was broken in hlist conversion of PCIDevices. Fix bug in CBFS file walking with compressed files. Michael S. Tsirkin (1): acpi: sync FADT flags from PIIX4 to Q35 cheers, Gerd

1 0

[PATCH] don't expose pvpanic device in the UI
by Hu Tao 12 Aug '13

12 Aug '13

pvpanic device is an internal default device in qemu. It may cause problem when upgrading qemu from a version without pvpanic. for example: in Windows(let's say XP) the Device manager will open a "new device" wizard and the device will appear as an unrecognized device. On a cluster with hundreds of such VMs, If that cluster has a health monitoring service it may show all the VMs in a "not healthy" state. This patch is a workaround to not show pvpanic in UI to avoid the problem in Windows. Cc: Marcel Apfelbaum <marcel.a(a)redhat.com> Cc: "Michael S. Tsirkin" <mst(a)redhat.com> Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: Gerd Hoffmann <kraxel(a)redhat.com> Cc: Eric Blake <eblake(a)redhat.com> Cc: "Daniel P. Berrange" <berrange(a)redhat.com> Cc: Andreas Färber <afaerber(a)suse.de> Signed-off-by: Hu Tao <hutao(a)cn.fujitsu.com> --- See discussion at: http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00036.html and follow-ups. src/ssdt-misc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ssdt-misc.dsl b/src/ssdt-misc.dsl index acc850e..19a2058 100644 --- a/src/ssdt-misc.dsl +++ b/src/ssdt-misc.dsl @@ -75,7 +75,7 @@ DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1) If (LEqual(Local0, Zero)) { Return (0x00) } Else { - Return (0x0F) + Return (0x0B) } } -- 1.8.1.4

11 73

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS August 2013