SeaBIOS July 2013

seabios@seabios.org

16 participants
34 discussions

[PATCH v3 0/2] pci: load memory window setup from host
by Michael S. Tsirkin 25 Jul '13

25 Jul '13

This is a refactoring of patch PATCH v2: pci: load memory window setup from host. Please note qemu merged the required interface already. Please review, and consider for release. Changes from v2: - address comments by Kevin: avoid dynamic memory allocation refactor code to avoid special-casing loaded windows - split out to two patch series Changes from v1: - fix bug in 64 bit range check - address Kevin's comments: move file load into pciinit.c dont reorder initialization sizeof style fix Michael S. Tsirkin (2): pciinit: refactor mem init code pci: load memory window setup from host src/pciinit.c | 145 ++++++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 121 insertions(+), 24 deletions(-) -- MST

1 2

Call for Proposals: 2013 Linux Plumbers Virtualization Microconference
by Alex Williamson 24 Jul '13

24 Jul '13

The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans, Louisiana, USA September 18-20th and is co-located with LinuxCon North America. For more information see: http://www.linuxplumbersconf.org/2013/ The tentative deadline for proposals is August 1st. To submit a topic please email a brief abstract to lpc2013-virt-mc(a)codemonkey.ws If you require travel assistance (extremely limited) in order to attend, please note that in your submission. Also, please keep an eye on: http://www.linuxplumbersconf.org/2013/submitting-topic/ http://www.linuxplumbersconf.org/2013/participate/ We've setup the above email submission as an interim approach until the LPC program committee brings the official submission tool online. I'll send a follow-up message when that occurs, but please send your proposals as soon as possible. Thanks, Alex

1 2

[PATCH v2 0/4] qemu: generate acpi tables for the guest
by Michael S. Tsirkin 24 Jul '13

24 Jul '13

This patchset moves all generation of ACPI tables from guest BIOS to the hypervisor. Please review, and consider for 1.6. Changes from v1 RFC: - added code to address cross version compatibility - rebased to latest bits - updated acpi tables to latest seabios bits (added pvpanic device) Comments: Although ACPI tables come from a system BIOS on real hw, it makes sense that the ACPI tables are coupled with the virtual machine, since they have to abstract the x86 machine to the OS's. This is widely desired as a way to avoid the churn and proliferation of QEMU-specific interfaces associated with ACPI tables in bios code. An RFC patchset adding support for hotplug of devices behind PCI to PCI bridges on top of this infrastructure was sent to the list a while ago. Latest version of that patchset will also be re-sent soon. If you look at the actual code: i386: imports ACPI table generation code from seabios you will see that it's more complex than it needs to be, with lots of low level casts and similar tricks. There's also a bit of duplication where we already declare similar acpi structures in qemu. This is the result of code being a direct port from seabios. Laszlo's patch (build ACPI MADT (APIC) for fw_cfg) shows how this will be cleaned up by follow-up work. I think it's best to do it in this order: port code directly, and apply cleanups and reduce duplication that results, on top. This way it's much easier to see that we don't introduce regressions. In particular, for a simple VM with piix, I booted a guest on qemu with and without the change, and verified that ACPI tables are unchanged except for trivial pointer address changes. Such binary compatibility makes it easier to be confident that this change won't break things. Michael S. Tsirkin (4): loader: support for unmapped ROM blobs loader: allow adding ROMs in done callbacks i386: generate pc guest info i386: ACPI table generation code from seabios hw/acpi/ich9.c | 7 +- hw/acpi/piix4.c | 44 ++- hw/core/loader.c | 38 ++- hw/i386/Makefile.objs | 4 + hw/i386/acpi-build.c | 723 +++++++++++++++++++++++++++++++++++++++++++ hw/i386/acpi-defs.h | 327 +++++++++++++++++++ hw/i386/pc.c | 43 ++- hw/i386/pc_piix.c | 18 +- hw/i386/pc_q35.c | 13 +- hw/i386/ssdt-misc.dsl | 46 +++ hw/isa/lpc_ich9.c | 11 +- hw/lm32/lm32_hwsetup.h | 2 +- hw/mips/mips_malta.c | 2 +- hw/misc/pvpanic.c | 12 +- hw/pci-host/q35.c | 1 + include/hw/acpi/ich9.h | 2 +- include/hw/i386/acpi-build.h | 9 + include/hw/i386/ich9.h | 3 +- include/hw/i386/pc.h | 38 ++- include/hw/loader.h | 5 +- vl.c | 3 + 21 files changed, 1321 insertions(+), 30 deletions(-) create mode 100644 hw/i386/acpi-build.c create mode 100644 hw/i386/acpi-defs.h create mode 100644 include/hw/i386/acpi-build.h -- MST

6 18

Re: [SeaBIOS] Commit b98a4b1 prevents USB drives from being detected
by Dave Frodin 22 Jul '13

22 Jul '13

Kevin, Your patch does fix the problem with USB thumbdrives. I tested on a Gizmo (Family14/SB800) board. Thanks, Dave ----- Original Message ----- > From: "Kevin O'Connor" <kevin(a)koconnor.net> > To: "Dave Frodin" <dave.frodin(a)se-eng.com> > Cc: "seabios" <seabios(a)seabios.org> > Sent: Sunday, July 14, 2013 11:59:11 AM > Subject: Re: [SeaBIOS] Commit b98a4b1 prevents USB drives from being detected > > On Fri, Jul 12, 2013 at 03:22:43PM -0500, Dave Frodin wrote: > > > I'm using the current seabios (master or stable) as a payload for > > coreboot. If I build the current seabios I've found that commit > > b98a4b1 "Convert PCIDevices list to use standard list manipultion > > code." prevents the system from finding USB thumbdrives. The USB > > keyboard and mouse still work. > > Thanks. The PCI list changes broke the ordering of the PCIDevices > list. Can you confirm the patch below fixes it for you? > > -Kevin > > > commit 2a9aeabdfb34374ecac25e7a8d21c9e368618cd4 > Author: Kevin O'Connor <kevin(a)koconnor.net> > Date: Sun Jul 14 13:55:52 2013 -0400 > > Fix USB EHCI detection that was broken in hlist conversion of PCIDevices. > > Make sure the PCI device list is ordered in bus order. > > Don't iterate past the end of the list when detecting EHCI devices. > > Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> > > diff --git a/src/pci.c b/src/pci.c > index 6163a29..dc62c5c 100644 > --- a/src/pci.c > +++ b/src/pci.c > @@ -122,6 +122,7 @@ pci_probe_devices(void) > } > memset(dev, 0, sizeof(*dev)); > hlist_add(&dev->node, pprev); > + pprev = &dev->node.next; > count++; > > // Find parent device. > diff --git a/src/usb.c b/src/usb.c > index ecccd75..42541ff 100644 > --- a/src/usb.c > +++ b/src/usb.c > @@ -444,7 +444,7 @@ usb_setup(void) > } > if (ehcipci->class == PCI_CLASS_SERIAL_USB) > found++; > - ehcipci = container_of( > + ehcipci = container_of_or_null( > ehcipci->node.next, struct pci_device, node); > if (!ehcipci || (pci_bdf_to_busdev(ehcipci->bdf) > != pci_bdf_to_busdev(pci->bdf))) >

1 0

[PATCH] Add missing mathcp_setup() call to CSM code.
by Kevin O'Connor 21 Jul '13

21 Jul '13

It looks like when mathcp_setup() got moved from interface_init() to platform_hardware_setup() in 3a735baa the corresponding change was not made to the CSM code. Update it now. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/csm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/csm.c b/src/csm.c index e855d2c..2021701 100644 --- a/src/csm.c +++ b/src/csm.c @@ -169,6 +169,7 @@ handle_csm_0002(struct bregs *regs) struct bios_data_area_s *bda = MAKE_FLATPTR(SEG_BDA, 0); bda->hdcount = 0; + mathcp_setup(); timer_setup(); clock_setup(); device_hardware_setup(); -- 1.7.11.7

1 0

[PATCH] Default unused UMB areas to be read-only.
by Kevin O'Connor 21 Jul '13

21 Jul '13

It looks like MSDOS 6 wants the UMB area to be read-only in order for it to use it. FreeDOS doesn't care, but it always maps a page from high mem when it does use the area. So, add an option to control whether unused UMB ram is marked read-only and default it to read-only as that seems to be more compatible. This also fixes an off-by-one bug in the shadow range checking code. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/Kconfig | 12 ++++++++++++ src/shadow.c | 8 +++++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index 5e2db8b..3a4d580 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -362,6 +362,18 @@ menu "BIOS interfaces" default n help Disable A20 on 16bit boot. + + config WRITABLE_UPPERMEMORY + depends on QEMU + bool "Make unused UMB memory read/writeable." + default n + help + When selected, the "Upper Memory Block" area + (0x90000-0xa0000) that is not used for option roms will be + made writable. This allows the ram to be directly + modified by programs. However, some old DOS high memory + managers may require the UMB region to be read-only. + endmenu menu "BIOS Tables" diff --git a/src/shadow.c b/src/shadow.c index 967eb8e..242f220 100644 --- a/src/shadow.c +++ b/src/shadow.c @@ -80,13 +80,15 @@ make_bios_readonly_intel(u16 bdf, u32 pam0) wbinvd(); // Write protect roms from 0xc0000-0xf0000 - u32 romend = rom_get_last(), romtop = rom_get_max(); + u32 romlast = BUILD_BIOS_ADDR, rommax = rom_get_max(); + if (CONFIG_WRITABLE_UPPERMEMORY) + romlast = rom_get_last(); int i; for (i=0; i<6; i++) { u32 mem = BUILD_ROM_START + i * 32*1024; u32 pam = pam0 + 1 + i; - if (romend <= mem + 16*1024 || romtop <= mem + 32*1024) { - if (romend > mem && romtop > mem + 16*1024) + if (romlast < mem + 16*1024 || rommax < mem + 32*1024) { + if (romlast >= mem && rommax >= mem + 16*1024) pci_config_writeb(bdf, pam, 0x31); break; } -- 1.7.11.7

1 0

[PATCH 00/10] Timer enhancements and cleanups
by Kevin O'Connor 20 Jul '13

20 Jul '13

This patch series improves the accuracy of the internal timers. It also refactors a bit of the code and makes it a little cleaner. -Kevin Kevin O'Connor (10): Move internal timer code from clock.c to a new file timer.c. Don't pass khz to pmtimer_setup - it's always PM_TIMER_FREQUENCY. Add helper functions to convert timer irqs to milliseconds. Improve accuracy of internal timers. Rename cpu_khz to TimerKHz. Shift CPU TSC down to reduce need for 64bit variables. Rename check_timer() function (and similar) to irqtimer_check(). Rename check_tsc() (and similar) to timer_check() and use u32. Separate out timer setup code. Unify pmtimer_read() and pittimer_read() code. Makefile | 2 +- src/acpi.c | 2 +- src/ahci.c | 19 ++--- src/ata.c | 18 ++--- src/biosvar.h | 3 + src/blockcmd.c | 6 +- src/boot.c | 4 +- src/clock.c | 249 ++------------------------------------------------------- src/csm.c | 1 + src/floppy.c | 8 +- src/megasas.c | 10 +-- src/pciinit.c | 7 +- src/pit.h | 29 +++++++ src/post.c | 1 + src/ps2port.c | 8 +- src/serial.c | 12 +-- src/timer.c | 244 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/usb-ehci.c | 16 ++-- src/usb-hub.c | 8 +- src/usb-ohci.c | 18 ++--- src/usb-uhci.c | 14 ++-- src/util.c | 4 +- src/util.h | 29 ++++--- 23 files changed, 374 insertions(+), 338 deletions(-) create mode 100644 src/pit.h create mode 100644 src/timer.c -- 1.7.11.7

1 10

[PATCH] acpi: sync FADT flags from PIIX4 to Q35
by Michael S. Tsirkin 18 Jul '13

18 Jul '13

The following commits updated the FADT flags for PIIX4: commit c7be281b3be0f2013aa4b5d5f400981a1adb6e63 Drop FIX_RTC flag from FADT. commit a4e2b9adbba95c2d783761e84444bbb3c8d6107b enable USE_PLATFORM_CLOCK bit in FADT flags Q35 support was originally written before these commits in seabios, PIIX got updated, Q35 didn't. QEMU uses the same clock for both so there's no reason for these bits to differ. Sync them up. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- src/acpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index 3fe5e36..6df2971 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -99,9 +99,9 @@ void ich9_lpc_fadt_setup(struct pci_device *dev, void *arg) fadt->gpe0_blk_len = ICH9_PMIO_GPE0_BLK_LEN; fadt->plvl2_lat = cpu_to_le16(0xfff); // C2 state not supported fadt->plvl3_lat = cpu_to_le16(0xfff); // C3 state not supported - /* WBINVD + PROC_C1 + SLP_BUTTON + FIX_RTC + RTC_S4 */ - fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 6) | - (1 << 7)); + /* WBINVD + PROC_C1 + SLP_BUTTON + RTC_S4 + USE_PLATFORM_CLOCK */ + fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 7) | + (1 << 15)); } static const struct pci_device_id fadt_init_tbl[] = { -- MST

3 2

[PATCH] Add CONFIG_DEBUG_COREBOOT config option
by Gerd Hoffmann 17 Jul '13

17 Jul '13

Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/Kconfig | 10 ++++++++++ src/coreboot.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/Kconfig b/src/Kconfig index 5882d11..5e2db8b 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -433,4 +433,14 @@ menu "Debugging" information by outputing strings in a special port present in the IO space. + config DEBUG_COREBOOT + depends on COREBOOT && DEBUG_LEVEL != 0 + bool "coreboot cbmem debug logging" + default y + help + Send debugging information to the coreboot cbmem console buffer. + Needs CONFIG_CONSOLE_CBMEM in coreboot. You can read the log + after boot using 'cbmem -c'. Only 32bit code (basically every- + thing before booting the OS) writes to the log buffer. + endmenu diff --git a/src/coreboot.c b/src/coreboot.c index c66e6e3..7f7b322 100644 --- a/src/coreboot.c +++ b/src/coreboot.c @@ -206,7 +206,7 @@ fail: void debug_cbmem(char c) { - if (!CONFIG_COREBOOT) + if (!CONFIG_DEBUG_COREBOOT) return; if (!cbcon) return; -- 1.7.9.7

2 1

Re: [SeaBIOS] "ata_piix device not availabile cannot reserve io" issue
by Kevin O'Connor 16 Jul '13

16 Jul '13

On Mon, Jul 15, 2013 at 11:41:02AM +0200, Riccardo Schirone wrote: > Hi, i use seabios on qemu with Linux as guest OS and i am not able to boot > my machine because kernel says > > ata_piix 0000:00:01.1: device not available (can't reserve [io > 0x0000-0x0007]) > > i try with qemu v1.5.50 and v.1.4.2 and i have the same error. > > Bisecting seabios i found that the error was introduced with this commit > > 76e58028d28e78431f9de3cee0b3c88d807fa39d - acpi: Eliminate BDAT parameter > passing to DSDT code. This looks like the bios.rom file was updated while the acpi-dsdt.aml file was not. The two files must be kept in sync. -Kevin

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS July 2013