SeaBIOS August 2011

seabios@seabios.org

24 participants
33 discussions

Time to cut a new release?
by Gerd Hoffmann 05 Aug '11

05 Aug '11

Hi, A bunch of new stuff has been added to master since the last version, time to release a new one? Especially I'd like to see qemu get a seabios update, and anthony prefers a release instead of a git snapshot for that. cheers, Gerd

4 3

Re: [SeaBIOS] usb boot issue
by Marc Jones 04 Aug '11

04 Aug '11

On Thu, Aug 4, 2011 at 4:07 PM, Marc Jones <marcj303(a)gmail.com> wrote: > On Wed, Aug 3, 2011 at 5:22 PM, Kevin O'Connor <kevin(a)koconnor.net> wrote: >> On Wed, Aug 03, 2011 at 02:47:19PM -0600, Marc Jones wrote: >>> I'm having a problem with booting a usb flash key that worked >>> previously in version 0.6.2. The USB device is identified but then >>> gets a read error when booting from it. This is the Persimmon, sb800 >>> platform. Any thoughts on what might have changed to cause this? >> >> Could it be just a sporatic failure? The only real USB changes since >> v0.6.2 were book keeping changes for 'struct pcidevice' - I don't >> think they would cause drive read errors. Can you post the log? >> >> -Kevin >> > > > This is the error I am getting: > > enter handle_13: > a=00204280 b=00002400 c=0000000a d=00000080 ds=0000 es=07c0 ss=0000 > si=00007ba2 di=00002000 bp=000007be sp=00007ba2 cs=07c0 ip=0147 f=0202 > disk_op d=0x0000d5e0 lba=2097280 buf=0x0000a000 count=1 cmd=2 > ehci_send_bulk qh=0x0009ff00 dir=0 data=0x0009fad8 size=31 > ehci_send_bulk qh=0x0009ff80 dir=128 data=0x0000a000 size=512 > ehci_send_bulk qh=0x0009ff80 dir=128 data=0x0009faf7 size=13 > enter handle_13: > a=00204281 b=00002400 c=00000000 d=00000780 ds=0000 es=07e0 ss=0000 > si=00007ba2 di=00002000 bp=000007be sp=00007ba2 cs=07c0 ip=0147 f=0206 > disk_op d=0x0000d5e0 lba=2097281 buf=0x0000a200 count=1 cmd=2 > ehci_send_bulk qh=0x0009ff00 dir=0 data=0x0009fad8 size=31 > WARNING - Timeout at ehci_wait_td:570! > ehci_send_bulk failed > USB transmission failed > invalid extended_access:143: > a=00204281 b=00002400 c=00000000 d=00000780 ds=0000 es=07e0 ss=0000 > si=00007ba2 di=00002000 bp=000007be sp=00007ba2 cs=07c0 ip=0147 f=0206 > > I now suspect that this is a coreboot problem. The old working seabios > with current coreboot fails as well. I bisected it to this change in coreboot: 8fed77ae4c46122859d0718678e54546e126d4bc is the first bad commit commit 8fed77ae4c46122859d0718678e54546e126d4bc Author: Scott Duplichan <scott(a)notabs.org> Date: Sat Jun 18 10:46:45 2011 -0500 ASRock E350M1: Configure SB800 GPP ports to support onboard pcie nic Scott Duplichan's patch from the mailing list: sb800 cimx wrapper: Run the complete sb800 cimx sbBeforePciInit() function once, after determining device 0x15 function enables. 1) Update the asrock e350m1 devicetree.cb to match the hardware. 2) Change the way the sb800 cimx wrapper code works. The original cimx code calls sb800 cimx function sbBeforePciInit() once. When ported to coreboot, the gpp component of this function was called once for each gpp port, as the gpp port's enable/disable state became known. A 05/15/2011 change makes the early gpp code run only once, triggered by processing the 4th gpp port. This method is not general enough because the 4th gpp port is not enabled on all boards. With the current change, the early gpp code runs when the first gpp port is processed. If any gpp ports are enabled, the first must be enabled. Tested with Win7 and linux on asrock e350m1. This change will also affect amd inagua, and has not been tested on that board. Change-Id: I93d44c216bfcab3c3a8fbb79d23dab43a65850e6 Signed-off-by: Scott Duplichan <scott(a)notabs.org> Acked-by: Marshall Buschman <mbuschman(a)lucidmachines.com> Reviewed-on: http://review.coreboot.org/44 Tested-by: build bot (Jenkins) Reviewed-by: Cristian Măgherușan-Stanciu <cristi.magherusan(a)gmail.com> I'll see if I can figure out why it breaks stuff. Marshall, Can you try before and after this change? Marc -- http://se-eng.com

1 0

Re: [SeaBIOS] usb boot issue
by Kevin O'Connor 04 Aug '11

04 Aug '11

On Wed, Aug 03, 2011 at 02:47:19PM -0600, Marc Jones wrote: > I'm having a problem with booting a usb flash key that worked > previously in version 0.6.2. The USB device is identified but then > gets a read error when booting from it. This is the Persimmon, sb800 > platform. Any thoughts on what might have changed to cause this? Could it be just a sporatic failure? The only real USB changes since v0.6.2 were book keeping changes for 'struct pcidevice' - I don't think they would cause drive read errors. Can you post the log? -Kevin

2 1

[PATCH] ahci: enable by default
by Gerd Hoffmann 04 Aug '11

04 Aug '11

Lack of real hardware testing was the main reason to turn it off by default. The AHCI has been fixed to work on both qemu and real hardware, so lets flip the switch now. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index 81acc1c..338f51a 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -104,7 +104,7 @@ menu "Hardware support" config AHCI depends on DRIVES bool "AHCI controllers" - default n + default y help Support for AHCI disk code. config VIRTIO_BLK -- 1.7.1

1 0

[PATCH V5 0/9] Add TPM support to SeaBIOS
by Stefan Berger 04 Aug '11

04 Aug '11

The following set of patches add TPM and Trusted Computing support to SeaBIOS. In particular the patches add: - a TPM driver for the Qemu's TPM TIS emulation (not yet in Qemu git) - ACPI support for the TPM device (SSDT table) - ACPI support for measurement logging (TCPA table) - Support for initialzation of the TPM - Support for the TCG BIOS extensions (1ah handler [ah = 0xbb]) (used by trusted grub; http://trousers.sourceforge.net/grub.html) - Static Root of Trusted for Measurement (SRTM) support - Support for S3 resume (sends command to TPM upon resume) - TPM-specific menu for controlling aspects of the TPM - [An optional test suite for the TIS interface] All implementations necessarily follow specifications. When all patches are applied the following services are available - SSDT ACPI table for TPM support - initialization of the TPM upon VM start and S3 resume - Static root of trust for measurements (SRTM) that measures (some) data of SeaBIOS in TCPA ACPI table - 1ah interrupt handler offering APIs for measuring and sending commands to the TPM (trusted grub uses them) - User menu for controlling aspects of the state of the TPM v5: - adapted patches to checkout of 76b5e71 (June 21) - bugfixes (see individual patches) - added patch to support the transfer of Qemu-provided measurements via firmware interface v4: - if ! has_working_tpm() now returns error code everywhere - tis_test.c now also under LGPLv3 - in inthandler, pulled set_cf() out of switch and then only call it in the default case where we need to indicate that a function is not implemented v3: - some nits here and there - calling timer_setup now after S3 resume v2: - following Kevin's comment - refactoring code so that every patch compiles Regards, Stefan

3 15

[PATCH 0/7] ahci update
by Gerd Hoffmann 04 Aug '11

04 Aug '11

Hi, Finally the update for the ahci code, featuring: * A bunch of bugfixes, which makes the code work on real hardware (additionally to the qemu emulated ahci adapter). * Better timeout handling. * Support for unaligned access. * Support for boot ordering. cheers, Gerd The following changes since commit 77b8536e5c9908fbe99c88d01462a36a3deb05b1: pci: set BUILD_PCIMEM_START to 0xe0000000 (2011-07-12 21:14:53 -0400) are available in the git repository at: git://git.kraxel.org/seabios ahci Gerd Hoffmann (6): ahci/sata: Fix FIS setup. ahci: use interrupt status register ahci: add error recovery code ahci: don't expect ATA_CB_STAT_DRQ being clear ahci: rework init workflow & fix timeout handling ahci: bootprio support Scott Duplichan (1): ahci: handle unaligned buffers. src/ahci.c | 350 +++++++++++++++++++++++++++++++++++++++++++++--------------- src/ahci.h | 3 +- 2 files changed, 264 insertions(+), 89 deletions(-)

3 12

Re: [SeaBIOS] [PATCH] cpu hotplug issue
by Gleb Natapov 04 Aug '11

04 Aug '11

On Wed, Aug 03, 2011 at 06:25:07PM +0200, Vasilis Liaskovitis wrote: > On Wed, Aug 03, 2011 at 12:42:11PM +0200, Jan Kiszka wrote: > > >> Why can't Seabios read to true number online CPUs from the PIIX4 device? > > >> The information is there already, no need for addition PV here. > > >> > > > Where is it in PIIX4 device? > > > > PROC registers (or however they are called). > > In qemu-kvm, the cpus_sts bitmap array in PIIX4PMState/ACPIGPE has the true > number of online CPUS. This is accessed from the DSDT hotplug method in Seabios > as "OperationRegion SystemIO" with address 0xaf00. Is this i/o address in the > piix4 spec? How can it be accessed from the rest of SeaBIOS? It seems to reside > in ACPI_PM space. > 0xaf00 is not part of PIIX4. PIIX4 supports nor cpu host plug neither pci hot plug. I haven't found any PROC register in PIIX4 spec so far. -- Gleb.

2 1

Re: [SeaBIOS] SeaBIOS error with Juniper FreeBSD kernel
by Bjørn Mork 04 Aug '11

04 Aug '11

Brandon Bennett <bennetb(a)gmail.com> writes: >> Are all versions based on FreeBSD 4.11? >> Are newer versions still affected? > > Newer versions should be based on 6.1 but there are a lot of changes. > I haven't had a chance to test with something newer yet. Sorry for the delay due to vacation... I just confirmed the issue running "JUNOS 11.1R3.5 built 2011-06-25 00:17:21 UTC" which is as new as it officially gets at the moment. I don't think the FreeBSD version really matters. I believe the issue is related to the "platform_early_bootinit", whatever that is, which is Juniper specific code. I assume they are checking the SMBIOS for some data which is present on the real hardware, and this check triggers the crash. >From the 11.1R3.5 boot: Hit [Enter] to boot immediately, or space bar for command prompt. Booting [/kernel]... platform_early_bootinit: M/T Series Early Boot Initialization kernel trap 12 with interrupts disabled Fatal trap 12: page fault while in kernel mode fault virtual address = 0xbff3fffc fault code = supervisor write, page not present instruction pointer = 0x20:0xc0a22377 stac Fatal trap 30: reserved (unknown) fault while in kernel mode instruction pointer = 0x20:0xc09f4e66 stack pointer = 0x28:0xc1021a00 frame pointer = 0x28:0xc1021a10 code segment = base 0x0, limit 0xfffff, type 0x1b = DPL 0, pres 1, def32 1, gran 1 processor eflags = interrupt enabled, IOPL = 0 current process = 0 () trap number = 30 dog: ERROR - reset of uninitialized watchdog panic: reserved (unknown) fault (null)(c0c4f4a0,c0c4f4a0,c0be3672,c1021948,a) at 0xc0a14867 (null)(c0be3672,1e,c10219c0,1,1) at 0xc05a723e (null)(a,0,a,ffff7fff,ffffffff) at 0xc0a289dd (null)(c10219c0) at 0xc0a29921 (null)(0,c021b4b,3030000,c0c22a00,c0c54400) at 0xc0a15e7b (null)(c0c22a00,63,5,c1021bac,63) at 0xc09f50c2 (null)(63,10,1000000,1,c0bbe530) at 0xc05e66f3 (null)(63,c1021bac,c0be340e,3f8,1002580) at 0xc05c7ca5 (null)(c0bbe52c,c05c7c45,c1021bac,a,c1021bcc) at 0xc05c7df5 (null)(c0bbe52c,28,c1021cc4,c0be33fe,a) at 0xc05c8f73 (null)(c0c4d0a0,c1021c84,c1021c38,c05c8f73,c0bbe604) at 0xc0a287da (null)(c0bbe604,c,0,0,0) at 0xc0a28c2a (null)(c1021c84) at 0xc0a296e8 (null)(cffffef0,ffffef0,4,c00e0000,c00e0000) at 0xc0a15e7b (null)(0,c0bc71c6,4,10,0) at 0xc0a0f7df (null)(c0be5837,c1021d34,c1021d30,a,c1021d54) at 0xc0a0f8ed (null)(c0bc1e40,c0b6f924,c1021d84,c0a1e5a9,80) at 0xc0b3a694 (null)(80,c0a15ec0,f,3,20) at 0xc0b3ad7b (null)(1026000) at 0xc0a1e5a9 (null)() at 0xc04aa67d dog: ERROR - reset of uninitialized watchdog dog: ERROR - reset of uninitialized watchdog Uptime: 1s Also confirmed that 11.1R3.5 is working with SeaBIOS modified as follows: diff --git a/src/smbios.c b/src/smbios.c index 8df0f2d..c96deb5 100644 --- a/src/smbios.c +++ b/src/smbios.c @@ -17,7 +17,7 @@ smbios_entry_point_init(u16 max_structure_size, u16 number_of_structures) { struct smbios_entry_point *ep = malloc_fseg(sizeof(*ep)); - void *finaltable = malloc_high(structure_table_length); + void *finaltable = malloc_fseg(structure_table_length); if (!ep || !finaltable) { warn_noalloc(); free(ep); Bjørn

5 11

[PATCH 2/2] Allow allocation of SMBIOS table in f-segment if it is small.
by Kevin O'Connor 04 Aug '11

04 Aug '11

If the SMBIOS is small (less than 600 bytes) allow it to be allocated in the f-segment. This works around a bug in JunOS - it crashes on SMBIOS tables located in high memory. --- src/config.h | 2 ++ src/smbios.c | 11 +++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/config.h b/src/config.h index f2fce89..d182b13 100644 --- a/src/config.h +++ b/src/config.h @@ -51,6 +51,8 @@ #define BUILD_SMM_ADDR 0xa8000 #define BUILD_SMM_SIZE 0x8000 +#define BUILD_MAX_SMBIOS_FSEG 600 + // Important real-mode segments #define SEG_IVT 0x0000 #define SEG_BDA 0x0040 diff --git a/src/smbios.c b/src/smbios.c index 8df0f2d..7db8cce 100644 --- a/src/smbios.c +++ b/src/smbios.c @@ -17,7 +17,13 @@ smbios_entry_point_init(u16 max_structure_size, u16 number_of_structures) { struct smbios_entry_point *ep = malloc_fseg(sizeof(*ep)); - void *finaltable = malloc_high(structure_table_length); + void *finaltable; + if (structure_table_length <= BUILD_MAX_SMBIOS_FSEG) + // Table is small enough for f-seg - allocate there. This + // works around a bug in JunOS (at least for small SMBIOS tables). + finaltable = malloc_fseg(structure_table_length); + else + finaltable = malloc_high(structure_table_length); if (!ep || !finaltable) { warn_noalloc(); free(ep); @@ -44,7 +50,8 @@ smbios_entry_point_init(u16 max_structure_size, ep->intermediate_checksum -= checksum((void*)ep + 0x10, ep->length - 0x10); - dprintf(1, "SMBIOS ptr=%p table=%p\n", ep, finaltable); + dprintf(1, "SMBIOS ptr=%p table=%p size=%d\n" + , ep, finaltable, structure_table_length); } #define load_str_field_with_default(type, field, def) \ -- 1.7.4.4

2 1

[PATCH 1/2] Allow free space in f-segment to be used by malloc_fseg().
by Kevin O'Connor 04 Aug '11

04 Aug '11

--- src/optionroms.c | 2 +- src/pmm.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/optionroms.c b/src/optionroms.c index be02f2a..2832eab 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@ -483,7 +483,7 @@ vga_setup(void) init_optionrom((void*)BUILD_ROM_START, 0, 1); } else { // Clear option rom memory - memset((void*)RomEnd, 0, _max_rom() - RomEnd); + memset((void*)RomEnd, 0, max_rom() - RomEnd); // Find and deploy PCI VGA rom. struct pci_device *pci; diff --git a/src/pmm.c b/src/pmm.c index b812515..82a0b1d 100644 --- a/src/pmm.c +++ b/src/pmm.c @@ -216,6 +216,13 @@ malloc_fixupreloc(void) struct zone_s *zone = Zones[i]; zone->info->pprev = &zone->info; } + + // Add space free'd during relocation in f-segment to ZoneFSeg + extern u8 code32init_end[]; + if ((u32)code32init_end > BUILD_BIOS_ADDR) { + memset((void*)BUILD_BIOS_ADDR, 0, (u32)code32init_end - BUILD_BIOS_ADDR); + addSpace(&ZoneFSeg, (void*)BUILD_BIOS_ADDR, code32init_end); + } } void -- 1.7.4.4

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS August 2011