coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Shelley Chen, Subrata Banik. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 ) Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup ...................................................................... Patch Set 10: (3 comments) File src/mainboard/google/poppy/variants/nami/mainboard.c: https://review.coreboot.org/c/coreboot/+/68820/comment/b8912c13_e8674649 PS9, Line 309: switch(sku_id) > > space required before the open parenthesis '(' […] Done https://review.coreboot.org/c/coreboot/+/68820/comment/3725fa7b_79f8cb82 PS9, Line 309: switch(sku_id) > > that open brace { should be on the previous line […] Done https://review.coreboot.org/c/coreboot/+/68820/comment/461db535_a222c11e PS9, Line 330: gpio_output(GPP_C9,0); > > space required after that ',' (ctx:VxV) […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91 Gerrit-Change-Number: 68820 Gerrit-PatchSet: 10 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 17:35:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Shelley Chen, Subrata Banik. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 ) Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup ...................................................................... Patch Set 9: (3 comments) File src/mainboard/google/poppy/variants/nami/mainboard.c: https://review.coreboot.org/c/coreboot/+/68820/comment/c314c858_102b3e83 PS9, Line 309: switch(sku_id) > that open brace { should be on the previous line Please fix. https://review.coreboot.org/c/coreboot/+/68820/comment/b448ef38_83080e2d PS9, Line 309: switch(sku_id) > space required before the open parenthesis '(' Please fix. https://review.coreboot.org/c/coreboot/+/68820/comment/09cacb89_d904fd3a PS9, Line 330: gpio_output(GPP_C9,0); > space required after that ',' (ctx:VxV) Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/68820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91 Gerrit-Change-Number: 68820 Gerrit-PatchSet: 9 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 17:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

1 0

[S] Change in coreboot[master]: mb/google/poppy: Add support for a variant finalize function
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 ) Change subject: mb/google/poppy: Add support for a variant finalize function ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/70319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635 Gerrit-Change-Number: 70319 Gerrit-PatchSet: 2 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 17:29:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...
by Mike Banon (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Martin L Roth. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58748 ) Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Obviously this patch can't be merged. […] Good day, Martin! Thank you for your message, I understand the need to reduce the load on coreboot infrastructure and just replied here - https://review.coreboot.org/c/coreboot/+/58745/comments/5317bf46_d9bcae15 ; although only 8 changes of csb_patcher's 24 are "useless" to build - like this one above - I will be happy to do my part by cancelling their builds (if the git pushes won't be blocked by the lack of "signed-off-by-line"). Speaking of a fork idea: To ensure the best possible user experience of "opensource AGESA board" users I am caring about, my intention - instead of traditional forking (the forks are always outdated) - is to stay as-close-as-possible to coreboot master to enjoy the benefits such as the improvements to common PCI-handling code and the updated payloads. To do that, I am going to "semi-fork" by composing a long list of "git revert's" (to remove the commits which drop our boards or somehow break them) . Although the users will have to apply all these git reverts (in addition to two current ones which downgrade a GCC to 8.3.0 version that is stable for us - see CB:59636 for more info), and I will have to do the additional maintenance of this list to stay compatible with the new commits arriving, in return the "opensource AGESA board" users will have a much fresher coreboot, so I am ready to volunteer for this during my free time. I have been supporting our community for many years already and can't let the people down, even though the unfortunate removal of our boards is making the things more time-consuming and tricky... -- To view, visit https://review.coreboot.org/c/coreboot/+/58748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5de87f3c1e054da146ebb58b441e433700f94e45 Gerrit-Change-Number: 58748 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 15:57:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: G505S dGPU support: scripts for applying the unofficial (not-merged-y...
by Mike Banon (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Martin L Roth. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58745 ) Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Maybe mark them as WIP or even abandon them so that people don't spend time reviewing them as well.. […] Good day, Martin! Thank you for your attention, I just discovered that - out of 24 changes used directly/indirectly by csb_patcher.sh - these 8 changes (1/3 of 24) don't change the coreboot sources themselves - and therefore (unlike the other 16 "worthy" changes), building these 8 won't provide any new information and is useless: CB:64873 (csb_patcher.sh itself), CB:58745 (..._dgpu_....sh), CB:58748 (..._atombios_....sh), CB:48427 (..._irq_....sh), CB:44638 (..._cfgsb_....sh) , CB:64829 (config.lenovo_g505s...), CB:64831 (config.asus_am1i-a), CB:64832 (config.asus_a88xm-e) I am sorry for the inconvenience - and, to help to reduce the workload on coreboot infrastracture, if removing a "signed-off-by" line won't block the git pushes (i.e. in a case when a fresh re-upload is needed) - of course I will do for these patches the next time. Unfortunately, the build queue at https://qa.coreboot.org/ is too long recently, i.e. at the moment it's 72 and I haven't even done anything yet... Thank you and have a nice weekends -- To view, visit https://review.coreboot.org/c/coreboot/+/58745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e1ec5e8bd32cf32d606e5272a4d0383a57ba81 Gerrit-Change-Number: 58745 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 15:35:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/crossgcc: Update binutils from 2.37 to 2.39
by Felix Singer (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Julius Werner, Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66920 ) Change subject: util/crossgcc: Update binutils from 2.37 to 2.39 ...................................................................... Patch Set 23: Code-Review-2 (1 comment) Patchset: PS21: > Let give a try to CB:70252 […] Afaik binutils 2.39 is required. -- To view, visit https://review.coreboot.org/c/coreboot/+/66920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34a20a999f7ea624c1add4750fcd116166953dd8 Gerrit-Change-Number: 66920 Gerrit-PatchSet: 23 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 03 Dec 2022 13:27:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [For test]: Ignore RWX segment warning
by Elyes Haouas (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Jakub Czapiga. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70252 ) Change subject: [For test]: Ignore RWX segment warning ...................................................................... Patch Set 3: (1 comment) File tests/Makefile.common: https://review.coreboot.org/c/coreboot/+/70252/comment/9e27d275_3ea07c78 PS2, Line 69: TEST_LDFLAGS += --no-warn-rwx-segments > And, you will have to use `-Wl,... […] Thank you -- To view, visit https://review.coreboot.org/c/coreboot/+/70252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I593eea3bcac8e9e46883b73b25a31e20b4c27c51 Gerrit-Change-Number: 70252 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 13:12:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cbmem_top: Change the return value to uintptr_t
by Elyes Haouas (Code Review) 03 Dec '22

03 Dec '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69163 ) Change subject: cbmem_top: Change the return value to uintptr_t ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/69163 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib757c0548f6f643747ba8d70228b3d6dfa5182cd Gerrit-Change-Number: 69163 Gerrit-PatchSet: 14 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: sb/amd/pi/hudson: Use {read,write}16/32p()
by Elyes Haouas (Code Review) 03 Dec '22

03 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70290 ) Change subject: sb/amd/pi/hudson: Use {read,write}16/32p() ...................................................................... sb/amd/pi/hudson: Use {read,write}16/32p() Change-Id: Ic8621a18a1b3c299c3d6eb7b4bff39f1ff7d8492 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/southbridge/amd/pi/hudson/early_setup.c 1 file changed, 28 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/70290/1 diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c index 5e3f760..1e1a2f4 100644 --- a/src/southbridge/amd/pi/hudson/early_setup.c +++ b/src/southbridge/amd/pi/hudson/early_setup.c @@ -210,40 +210,40 @@ void hudson_set_spi100(u16 norm, u16 fast, u16 alt, u16 tpm) { uintptr_t base = hudson_spibase(); - write16((void *)(base + SPI100_SPEED_CONFIG), - (norm << SPI_NORM_SPEED_NEW_SH) | - (fast << SPI_FAST_SPEED_NEW_SH) | - (alt << SPI_ALT_SPEED_NEW_SH) | - (tpm << SPI_TPM_SPEED_NEW_SH)); - write16((void *)(base + SPI100_ENABLE), SPI_USE_SPI100 | - read16((void *)(base + SPI100_ENABLE))); + write16p(base + SPI100_SPEED_CONFIG, + (norm << SPI_NORM_SPEED_NEW_SH) | + (fast << SPI_FAST_SPEED_NEW_SH) | + (alt << SPI_ALT_SPEED_NEW_SH) | + (tpm << SPI_TPM_SPEED_NEW_SH)); + write16p(base + SPI100_ENABLE, SPI_USE_SPI100 | + read16p(base + SPI100_ENABLE)); } void hudson_disable_4dw_burst(void) { uintptr_t base = hudson_spibase(); - write16((void *)(base + SPI100_HOST_PREF_CONFIG), - read16((void *)(base + SPI100_HOST_PREF_CONFIG)) - & ~SPI_RD4DW_EN_HOST); + write16p(base + SPI100_HOST_PREF_CONFIG, + read16p(base + SPI100_HOST_PREF_CONFIG) + & ~SPI_RD4DW_EN_HOST); } /* Hudson 1-3 only. For Hudson 1, call with fast=1 */ void hudson_set_readspeed(u16 norm, u16 fast) { uintptr_t base = hudson_spibase(); - write16((void *)(base + SPI_CNTRL1), - (read16((void *)(base + SPI_CNTRL1)) - & ~SPI_CNTRL1_SPEED_MASK) - | (norm << SPI_NORM_SPEED_SH) - | (fast << SPI_FAST_SPEED_SH)); + write16p(base + SPI_CNTRL1, + (read16p(base + SPI_CNTRL1) + & ~SPI_CNTRL1_SPEED_MASK) + | (norm << SPI_NORM_SPEED_SH) + | (fast << SPI_FAST_SPEED_SH)); } void hudson_read_mode(u32 mode) { uintptr_t base = hudson_spibase(); - write32((void *)(base + SPI_CNTRL0), - (read32((void *)(base + SPI_CNTRL0)) - & ~SPI_READ_MODE_MASK) | mode); + write32p(base + SPI_CNTRL0, + (read32p(base + SPI_CNTRL0) + & ~SPI_READ_MODE_MASK) | mode); } void hudson_tpm_decode_spi(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/70290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8621a18a1b3c299c3d6eb7b4bff39f1ff7d8492 Gerrit-Change-Number: 70290 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022