coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6824 discussions

[S] Change in coreboot[master]: nb/intel/sandybridge: Use read{8,32}p()
by Elyes Haouas (Code Review) 03 Dec '22

03 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70285 ) Change subject: nb/intel/sandybridge: Use read{8,32}p() ...................................................................... nb/intel/sandybridge: Use read{8,32}p() Change-Id: I3bbb2f02a2dc182956deffc554a6b161a93ad963 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/sandybridge/raminit.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/70285/1 diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c index 5044512..7beaa9b 100644 --- a/src/northbridge/intel/sandybridge/raminit.c +++ b/src/northbridge/intel/sandybridge/raminit.c @@ -31,11 +31,11 @@ return; /* Some TXT public bit */ - if (!(read32((void *)0xfed30010) & 1)) + if (!(read32p(0xfed30010) & 1)) return; /* Wait for TXT clear */ - while (!(read8((void *)0xfed40000) & (1 << 7))) + while (!(read8p(0xfed40000) & (1 << 7))) ; } -- To view, visit https://review.coreboot.org/c/coreboot/+/70285 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3bbb2f02a2dc182956deffc554a6b161a93ad963 Gerrit-Change-Number: 70285 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Drop casts around `soc_read_pmc_base()`
by Elyes Haouas (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Kapil Porwal. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70272 ) Change subject: soc/intel/meteorlake: Drop casts around `soc_read_pmc_base()` ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I914190f2d2d0507c84b19340159990f9b62ce101 Gerrit-Change-Number: 70272 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 12:19:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/intel/fsp2_0/memory_init: Inform user of memory training
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans, Andrey Petrov, Zhixing Ma, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70300 ) Change subject: drivers/intel/fsp2_0/memory_init: Inform user of memory training ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70300/comment/5a698f09_6e984bcf PS2, Line 20: systematically defined. Missing TEST and BUG lines File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/c/coreboot/+/70300/comment/6d52a243_fce27ec5 PS2, Line 330: /* Memory training is over, clear the end-user notification. */ Is this strictly needed with GRAPHICS_OFF_BEFORE_RAMSTAGE ? -- To view, visit https://review.coreboot.org/c/coreboot/+/70300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ea15123eed1a4355c5ff7d815925032d4151de0 Gerrit-Change-Number: 70300 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 12:05:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/pc80/vga: Display a string centered on a line
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70277 ) Change subject: drivers/pc80/vga: Display a string centered on a line ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70277/comment/283d83a1_cb631c7d PS2, Line 15: TEST=TO-BE-COMPLETED For all these CLs, can we not state that this is functionally working on Skolas, Anahera? File src/drivers/pc80/vga/vga.c: https://review.coreboot.org/c/coreboot/+/70277/comment/f6cbf659_24b01df3 PS2, Line 278: * The string is truncated it exceeds 80 characters. nit: "truncated if it" -- To view, visit https://review.coreboot.org/c/coreboot/+/70277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie742795bb44bbea8cf24222e7bd4f355a6fece2f Gerrit-Change-Number: 70277 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 12:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/pc80/vga: Add romstage support
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70278 ) Change subject: drivers/pc80/vga: Add romstage support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81309871e8db71657b2a9816708141f121d767d3 Gerrit-Change-Number: 70278 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 11:58:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Add option to use Ada code in romstage
by Tarun Tuli (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Nico Huber, Michał Żygowski, Martin L Roth, Subrata Banik, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70274 ) Change subject: Add option to use Ada code in romstage ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74f0460f6b14fde2b4bd6391e1782b2e5b217707 Gerrit-Change-Number: 70274 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 11:54:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/cavium/cn81xx: Use read64p()
by Elyes Haouas (Code Review) 03 Dec '22

03 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70284 ) Change subject: soc/cavium/cn81xx: Use read64p() ...................................................................... soc/cavium/cn81xx: Use read64p() Change-Id: Ia79816ccc230d17dd1ce2bde7a185b4d502ad107 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/cavium/cn81xx/clock.c M src/soc/cavium/cn81xx/cpu.c 2 files changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/70284/1 diff --git a/src/soc/cavium/cn81xx/clock.c b/src/soc/cavium/cn81xx/clock.c index e415a85..0aafefc 100644 --- a/src/soc/cavium/cn81xx/clock.c +++ b/src/soc/cavium/cn81xx/clock.c @@ -46,7 +46,7 @@ { union cavm_rst_boot rst_boot; - rst_boot.u = read64((void *)RST_PF_BAR0); + rst_boot.u = read64p(RST_PF_BAR0); return ((u64)rst_boot.s.pnr_mul) * PLL_REF_CLK; } @@ -58,7 +58,7 @@ { union cavm_rst_boot rst_boot; - rst_boot.u = read64((void *)RST_PF_BAR0); + rst_boot.u = read64p(RST_PF_BAR0); return ((u64)rst_boot.s.c_mul) * PLL_REF_CLK; } diff --git a/src/soc/cavium/cn81xx/cpu.c b/src/soc/cavium/cn81xx/cpu.c index bb85029..14aff58 100644 --- a/src/soc/cavium/cn81xx/cpu.c +++ b/src/soc/cavium/cn81xx/cpu.c @@ -11,7 +11,7 @@ uint64_t cpu_get_available_core_mask(void) { - return read64((void *)RST_PP_AVAILABLE); + return read64p(RST_PP_AVAILABLE); } size_t cpu_get_num_available_cores(void) @@ -75,7 +75,7 @@ write64((void *)MIO_BOOT_AP_JUMP, (uintptr_t)secondary_init); /* Get coremask of cores in reset */ - const uint64_t reset = read64((void *)RST_PP_RESET); + const uint64_t reset = read64p(RST_PP_RESET); printk(BIOS_INFO, "CPU: Cores currently in reset: 0x%llx\n", reset); /* Setup entry for secondary core */ @@ -93,7 +93,7 @@ stopwatch_init_usecs_expire(&sw, 1000000); do { - pending = read64((void *)RST_PP_PENDING); + pending = read64p(RST_PP_PENDING); } while (!stopwatch_expired(&sw) && (pending & coremask)); if (stopwatch_expired(&sw)) { -- To view, visit https://review.coreboot.org/c/coreboot/+/70284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia79816ccc230d17dd1ce2bde7a185b4d502ad107 Gerrit-Change-Number: 70284 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: coreboot_tables: Make existing alignment conventions more explicit
by Peter Stuge (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Julius Werner, Martin Roth, ron minnich. Peter Stuge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70158 ) Change subject: coreboot_tables: Make existing alignment conventions more explicit ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File src/commonlib/include/commonlib/coreboot_tables.h: https://review.coreboot.org/c/coreboot/+/70158/comment/15765d41_bbf101f0 PS2, Line 110: #define LB_ENTRY_ALIGN 4 Should this come before lb_uint64_t on line 107 and be used there too? File src/lib/coreboot_table.c: https://review.coreboot.org/c/coreboot/+/70158/comment/b7e05c4e_5121cef3 PS2, Line 80: assert(IS_ALIGNED(rec->size, LB_ENTRY_ALIGN)); What happens if assert() fails? Does any existing code in the same code path use assert() already? I don't like that there can be a runtime failure, since that is likely a catastrophical error. Can it be avoided by doing something else? Explicit serialization code would avoid it, but I do recognize that that is a larger and/or different change. https://review.coreboot.org/c/coreboot/+/70158/comment/3bff3fa3_18d57c90 PS2, Line 306: strlen(mainboard_part_number) + 1, LB_ENTRY_ALIGN); Isn't this (8->4) a functional change in all 7 instances? -- To view, visit https://review.coreboot.org/c/coreboot/+/70158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaeef29ef255047a855066469e03b5481812e5975 Gerrit-Change-Number: 70158 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 10:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: [test] Update libgnat
by build bot (Jenkins) (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Nico Huber. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70283 ) Change subject: [test] Update libgnat ...................................................................... Patch Set 3: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165158): https://review.coreboot.org/c/coreboot/+/70283/comment/8666cbca_7424f25b PS3, Line 9: update to gcc/ada/libgnat/ Possible unwrapped commit description (prefer a maximum 72 chars per line) File src/lib/gnat/s-stalib.ads: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165158): https://review.coreboot.org/c/coreboot/+/70283/comment/efe5772f_1761b20f PS3, Line 60: -- we never want to attempt initialiazation of virtual variables of this 'initialiazation' may be misspelled - perhaps 'initialization'? -- To view, visit https://review.coreboot.org/c/coreboot/+/70283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7545be873ecd28dfb78c03ab39ba699f4af21979 Gerrit-Change-Number: 70283 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 03 Dec 2022 07:49:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: [test] Update libgnat
by Elyes Haouas (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Nico Huber. Hello Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70283 to look at the new patch set (#2). Change subject: [test] Update libgnat ...................................................................... [test] Update libgnat update to gcc/ada/libgnat/ ( https://gcc.gnu.org/git/?p=gcc.git;a=tree;f=gcc/ada/libgnat;h=e865587273168… ) Change-Id: I7545be873ecd28dfb78c03ab39ba699f4af21979 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M gnat.adc M src/lib/gnat/Makefile.inc A src/lib/gnat/a-except.ads M src/lib/gnat/a-unccon.ads M src/lib/gnat/ada.ads M src/lib/gnat/g-souinf.ads M src/lib/gnat/gnat.ads M src/lib/gnat/i-c.adb M src/lib/gnat/i-c.ads M src/lib/gnat/interfac.ads M src/lib/gnat/s-atacco.ads A src/lib/gnat/s-exctab.ads A src/lib/gnat/s-imagen.adb A src/lib/gnat/s-imen16.ads A src/lib/gnat/s-imen32.ads D src/lib/gnat/s-imenne.adb D src/lib/gnat/s-imenne.ads A src/lib/gnat/s-imenu8.ads M src/lib/gnat/s-maccod.ads M src/lib/gnat/s-parame.ads A src/lib/gnat/s-stalib.ads M src/lib/gnat/s-stoele.adb M src/lib/gnat/s-stoele.ads A src/lib/gnat/s-traent.adb A src/lib/gnat/s-traent.ads M src/lib/gnat/s-unstyp.ads M src/lib/gnat/system.ads 27 files changed, 2,973 insertions(+), 273 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/70283/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7545be873ecd28dfb78c03ab39ba699f4af21979 Gerrit-Change-Number: 70283 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022