Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67321
to look at the new patch set (#8).
Change subject: util/intelp2m: Print the current project verion
......................................................................
util/intelp2m: Print the current project verion
Print the current project version in the console and in the generated
file with the pad configuration: version = major-minor; major = 1.0;
minor = last commit in the intelp2m directory.
Change-Id: Id2fd0757c003004af976309a44dbbfff0eb517a7
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/Makefile
M util/intelp2m/main.go
2 files changed, 52 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/67321/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/67321
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2fd0757c003004af976309a44dbbfff0eb517a7
Gerrit-Change-Number: 67321
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 )
Change subject: mb/google/poppy: Add support for a variant finalize function
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/poppy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70319/comment/d29a749c_31b4e542
PS3, Line 64: {
nit:
You can add something like this
void __weak variant_final(void)
{
/* nop */
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/70319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635
Gerrit-Change-Number: 70319
Gerrit-PatchSet: 3
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 19:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 )
Change subject: mb/google/poppy: Add support for a variant finalize function
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635
Gerrit-Change-Number: 70319
Gerrit-PatchSet: 3
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 19:28:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 )
Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
......................................................................
Patch Set 10:
(3 comments)
File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68820/comment/b8912c13_e8674649
PS9, Line 309: switch(sku_id)
> > space required before the open parenthesis '(' […]
Done
https://review.coreboot.org/c/coreboot/+/68820/comment/3725fa7b_79f8cb82
PS9, Line 309: switch(sku_id)
> > that open brace { should be on the previous line […]
Done
https://review.coreboot.org/c/coreboot/+/68820/comment/461db535_a222c11e
PS9, Line 330: gpio_output(GPP_C9,0);
> > space required after that ',' (ctx:VxV) […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91
Gerrit-Change-Number: 68820
Gerrit-PatchSet: 10
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 17:35:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 )
Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68820/comment/c314c858_102b3e83
PS9, Line 309: switch(sku_id)
> that open brace { should be on the previous line
Please fix.
https://review.coreboot.org/c/coreboot/+/68820/comment/b448ef38_83080e2d
PS9, Line 309: switch(sku_id)
> space required before the open parenthesis '('
Please fix.
https://review.coreboot.org/c/coreboot/+/68820/comment/09cacb89_d904fd3a
PS9, Line 330: gpio_output(GPP_C9,0);
> space required after that ',' (ctx:VxV)
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91
Gerrit-Change-Number: 68820
Gerrit-PatchSet: 9
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 17:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 )
Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup
......................................................................
Patch Set 9:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21eb85dc11e0ea0eb5de8a6092b01663d3c3df91
Gerrit-Change-Number: 68820
Gerrit-PatchSet: 9
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 17:30:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 )
Change subject: mb/google/poppy: Add support for a variant finalize function
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635
Gerrit-Change-Number: 70319
Gerrit-PatchSet: 2
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 17:29:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58748 )
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Obviously this patch can't be merged. […]
Good day, Martin! Thank you for your message, I understand the need to reduce the load on coreboot infrastructure and just replied here - https://review.coreboot.org/c/coreboot/+/58745/comments/5317bf46_d9bcae15 ; although only 8 changes of csb_patcher's 24 are "useless" to build - like this one above - I will be happy to do my part by cancelling their builds (if the git pushes won't be blocked by the lack of "signed-off-by-line"). Speaking of a fork idea:
To ensure the best possible user experience of "opensource AGESA board" users I am caring about, my intention - instead of traditional forking (the forks are always outdated) - is to stay as-close-as-possible to coreboot master to enjoy the benefits such as the improvements to common PCI-handling code and the updated payloads. To do that, I am going to "semi-fork" by composing a long list of "git revert's" (to remove the commits which drop our boards or somehow break them) . Although the users will have to apply all these git reverts (in addition to two current ones which downgrade a GCC to 8.3.0 version that is stable for us - see CB:59636 for more info), and I will have to do the additional maintenance of this list to stay compatible with the new commits arriving, in return the "opensource AGESA board" users will have a much fresher coreboot, so I am ready to volunteer for this during my free time. I have been supporting our community for many years already and can't let the people down, even though the unfortunate removal of our boards is making the things more time-consuming and tricky...
--
To view, visit https://review.coreboot.org/c/coreboot/+/58748
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5de87f3c1e054da146ebb58b441e433700f94e45
Gerrit-Change-Number: 58748
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 15:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment