Attention is currently required from: Julius Werner.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28017 )
Change subject: arm64: mmu: Spot check security state for TTB mapping ......................................................................
Patch Set 2:
(1 comment)
File src/arch/arm64/armv8/mmu.c:
https://review.coreboot.org/c/coreboot/+/28017/comment/4d48a54f_0a09f033 PS2, Line 324: assert_correct_ttb_mapping(_ettb - 1); that gives me using gcc-12.2:
CC romstage/arch/arm64/armv8/mmu.o src/arch/arm64/armv8/mmu.c: In function 'mmu_enable': src/arch/arm64/armv8/mmu.c:296:9: error: array subscript -1 is outside array bounds of 'u8[]' {aka 'unsigned char[]'} [-Werror=array-bounds] 296 | assert_correct_ttb_mapping(_ettb - 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from src/arch/arm64/armv8/mmu.c:6: src/include/symbols.h:14:19: note: at offset -1 into object '_ettb' of size [0, 9223372036854775807] 14 | extern u8 _e##name[]; \ | ^~ src/include/symbols.h:70:1: note: in expansion of macro 'DECLARE_REGION' 70 | DECLARE_REGION(ttb) | ^~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [Makefile:392 : build/romstage/arch/arm64/armv8/mmu.o] Erreur 1