Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, Amanda Hwang, David Lin.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 )
Change subject: drivers/generic/nau8315: Allow custom _HID from config
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi David, I would like to add the valid HID array and use the enum in the device tree like the kernel does instead of arbitrary HID. WDYT?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956
Gerrit-Change-Number: 69965
Gerrit-PatchSet: 1
Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com>
Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com>
Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 00:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, EricKY Cheng, Matt DeVillier, Paul Menzel, Eric Lai, Martin Roth, Eric Peers, LeilaCY Lin, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 )
Change subject: soc/amd/common/acpi: Implement DTTS Proposal
......................................................................
Patch Set 73: Code-Review+1
(1 comment)
File src/soc/amd/common/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/68471/comment/c20ed424_0b9ecf58
PS73, Line 36: \_SB.DTTS()
Why doesn't this need a `External(\_SB.DTTS, MethodObj)` at the start of the file?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622
Gerrit-Change-Number: 68471
Gerrit-PatchSet: 73
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 00:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Van Chen, Frank Wu, Alan Lee, Dtrain Hsu, Ian Feng, John Hsu, Eric Lai, Amanda Hwang, David Lin.
AlanKY Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 )
Change subject: drivers/generic/nau8315: Allow custom _HID from config
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/69965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956
Gerrit-Change-Number: 69965
Gerrit-PatchSet: 1
Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com>
Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 00:07:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment