coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[S] Change in coreboot[master]: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
by Wisley Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Chen Wisley, Nick Vaccaro. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70171 ) Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Please add a follow up to remove the another parameter when you have time to test it. OK -- To view, visit https://review.coreboot.org/c/coreboot/+/70171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Gerrit-Change-Number: 70171 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 03:14:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT
by Hsuan-ting Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen. Hello build bot (Jenkins), Hsuan Ting Chen, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70145 to look at the new patch set (#2). Change subject: commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT ...................................................................... commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT ELOG_CROS_DIAG_RESULT_* codes should be consistent with the enum definition of enumerated histograms. Hence add comments based on the requirements of enum histograms in histogram guidelines. BUG=b:4047421 TEST=none Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M src/commonlib/bsd/include/commonlib/bsd/elog.h 1 file changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/70145/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df Gerrit-Change-Number: 70145 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Chen Wisley, Nick Vaccaro, Wisley Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70171 ) Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Please add a follow up to remove the another parameter when you have time to test it. -- To view, visit https://review.coreboot.org/c/coreboot/+/70171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Gerrit-Change-Number: 70171 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:37:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Chen Wisley, Nick Vaccaro, Wisley Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70171 ) Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Gerrit-Change-Number: 70171 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:37:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
by Wisley Chen (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Chen Wisley, Nick Vaccaro, Eric Lai. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70171 ) Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/anahera/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70171/comment/8481740c_be2baa47 PS3, Line 69: .speed_config[0] = { > I think you only need one of the parameter. try remove rise_time_ns and fall_time_ns. Hi Eric, It's urgent case. We already use the setting and build coreboot. Elan help to measure and confirm all timing meets their SPEC. If we try to remove rise_time_ns/fall_time_ns, it could take time to measure again. If it's not must modification, hope you can understand Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/70171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Gerrit-Change-Number: 70171 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:32:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: skip external buses for D-states list
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Eran Mitrani. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70163 ) Change subject: soc/intel/alderlake: skip external buses for D-states list ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70163 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3785b2b2af85d96e2e1296b6cfdefcd72080b5fe Gerrit-Change-Number: 70163 Gerrit-PatchSet: 5 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:26:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi: Helper functions to add certain _DSD properties
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Lance Zhao, Tarun Tuli, Kapil Porwal, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70063 ) Change subject: acpi: Helper functions to add certain _DSD properties ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541 Gerrit-Change-Number: 70063 Gerrit-PatchSet: 8 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:19:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/block/{pcie/rtd3,usb4}: Use helper functions for _DSD
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Eran Mitrani, Kapil Porwal, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70065 ) Change subject: soc/intel/cmn/block/{pcie/rtd3,usb4}: Use helper functions for _DSD ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib57dea9b16e4590ca2d75ac1512fdaf773ec50f6 Gerrit-Change-Number: 70065 Gerrit-PatchSet: 6 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:16:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: Tarun Tuli, Chen Wisley, Nick Vaccaro, Wisley Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70171 ) Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/mainboard/google/brya/variants/anahera/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70171/comment/ce1a708e_528f0603 PS3, Line 69: .speed_config[0] = { I think you only need one of the parameter. try remove rise_time_ns and fall_time_ns. -- To view, visit https://review.coreboot.org/c/coreboot/+/70171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Gerrit-Change-Number: 70171 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:12:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/zydron: Add WiFi SAR table
by Eric Lai (Code Review) 01 Dec '22

01 Dec '22

Attention is currently required from: David Wu, Tarun Tuli, Ren Kuo, Nick Vaccaro, Tyler Wang. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70173 ) Change subject: mb/google/brya/var/zydron: Add WiFi SAR table ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d5f966c7af3ac6d9923d4f6c851bfb340f31fab Gerrit-Change-Number: 70173 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:10:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022