Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70319 )
Change subject: mb/google/poppy: Add support for a variant finalize function
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/poppy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70319/comment/d29a749c_31b4e542
PS3, Line 64: {
nit:
You can add something like this
void __weak variant_final(void)
{
/* nop */
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70319
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00c091051e3499ca94b286d7fbe0a7a8bd38e635
Gerrit-Change-Number: 70319
Gerrit-PatchSet: 3
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Sat, 03 Dec 2022 19:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment