coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: amdfwtool: Add the new entry type for new family morgana
by ritul guru (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao, Martin Roth. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69045 ) Change subject: amdfwtool: Add the new entry type for new family morgana ...................................................................... Patch Set 9: (2 comments) File util/amdfwtool/amdfwtool.h: https://review.coreboot.org/c/coreboot/+/69045/comment/2c2d1bd1_580cc233 PS9, Line 71: AMD_FW_TPMLITE = 0x5f, : AMD_FW_PSP_SMUSCS = 0x5f, What is AMD_FW_PSP_SMUSCS? its type value can't be same as TPMLITE.. https://review.coreboot.org/c/coreboot/+/69045/comment/2f28bc1d_d76a655d PS9, Line 77: AMD_FW_MPM = 0x86, can we explicit name it as AMD_FW_MPM_DRAM for more clarify -- To view, visit https://review.coreboot.org/c/coreboot/+/69045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7565c5eda75b332a48613440d7e4cfb388d5012f Gerrit-Change-Number: 69045 Gerrit-PatchSet: 9 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 07:23:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: Add new family morgana
by ritul guru (Code Review) 03 Dec '22

03 Dec '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69046 ) Change subject: amdfwtool: Add new family morgana ...................................................................... Patch Set 9: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/69046/comment/b51771ad_4bfd80b8 PS9, Line 707: 0xBC0E0200 0xBC0D0B00? -- To view, visit https://review.coreboot.org/c/coreboot/+/69046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib82f6c03b93d277f3f7f27ce57c1a41fdc103575 Gerrit-Change-Number: 69046 Gerrit-PatchSet: 9 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Sat, 03 Dec 2022 07:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel: Set DMAR IOAPIC entry based on hardware
by Elyes Haouas (Code Review) 02 Dec '22

02 Dec '22

Attention is currently required from: Angel Pons, Arthur Heymans, Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70269 ) Change subject: nb/intel: Set DMAR IOAPIC entry based on hardware ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccc9387734fd39e7ffe504c65d2441b580130eab Gerrit-Change-Number: 70269 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 05:53:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [test] crossgcc: Update GCC from 11.2 to 12.2
by Elyes Haouas (Code Review) 02 Dec '22

02 Dec '22

Hello build bot (Jenkins), Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67821 to look at the new patch set (#10). Change subject: [test] crossgcc: Update GCC from 11.2 to 12.2 ...................................................................... [test] crossgcc: Update GCC from 11.2 to 12.2 Change-Id: Ic02d5680929b56ad357c3a010cff7e1540001911 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-11.2.0_gnat.patch R util/crossgcc/patches/gcc-12.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-12.2.0_asan_shadow_offset_callback.patch A util/crossgcc/patches/gcc-12.2.0_gnat.patch R util/crossgcc/patches/gcc-12.2.0_libcpp.patch R util/crossgcc/patches/gcc-12.2.0_libgcc.patch D util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-12.2.0.tar.xz.cksum 10 files changed, 58 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/67821/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/67821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic02d5680929b56ad357c3a010cff7e1540001911 Gerrit-Change-Number: 67821 Gerrit-PatchSet: 10 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: [test] crossgcc: Update GCC from 11.2 to 12.2
by Elyes Haouas (Code Review) 02 Dec '22

02 Dec '22

Hello build bot (Jenkins), Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67821 to look at the new patch set (#9). Change subject: [test] crossgcc: Update GCC from 11.2 to 12.2 ...................................................................... [test] crossgcc: Update GCC from 11.2 to 12.2 It may fail to build as "-Wno-array-bounds" is a new option. Change-Id: Ic02d5680929b56ad357c3a010cff7e1540001911 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-11.2.0_gnat.patch R util/crossgcc/patches/gcc-12.2.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-12.2.0_asan_shadow_offset_callback.patch A util/crossgcc/patches/gcc-12.2.0_gnat.patch R util/crossgcc/patches/gcc-12.2.0_libcpp.patch R util/crossgcc/patches/gcc-12.2.0_libgcc.patch D util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-12.2.0.tar.xz.cksum 10 files changed, 60 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/67821/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/67821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic02d5680929b56ad357c3a010cff7e1540001911 Gerrit-Change-Number: 67821 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: [For Test] crossgcc: Update GCC from 11.2 to 12.2
by Elyes Haouas (Code Review) 02 Dec '22

02 Dec '22

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/67821 ) Change subject: [For Test] crossgcc: Update GCC from 11.2 to 12.2 ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/67821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic02d5680929b56ad357c3a010cff7e1540001911 Gerrit-Change-Number: 67821 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: restore

1 0

[S] Change in coreboot[master]: lib/gnat: Remove Compiler_Unit_Warning pragmas
by Elyes Haouas (Code Review) 02 Dec '22

02 Dec '22

Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67828 to look at the new patch set (#8). Change subject: lib/gnat: Remove Compiler_Unit_Warning pragmas ...................................................................... lib/gnat: Remove Compiler_Unit_Warning pragmas Fix the warning: unrecognized pragma "Compiler_Unit_Warning" [-gnatwg]: CC ramstage/mainboard/51nb/x210/static.o couldn't parse value '-1' for 'SEABIOS_DEBUG_LEVEL' GCC libgnat-x86_32/lib/gnat/a-unccon.o GCC libgnat-x86_32/lib/gnat/ada.o GCC libgnat-x86_32/lib/gnat/g-souinf.o GCC libgnat-x86_32/lib/gnat/gnat.o GCC libgnat-x86_32/lib/gnat/i-c.o GCC libgnat-x86_32/lib/gnat/interfac.o interfac.ads:36:08: warning: unrecognized pragma "Compiler_Unit_Warning" [-gnatwg] make: *** [Makefile:392 : build/libgnat-x86_32/lib/gnat/interfac.o] Erreur 1 Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/gnat/interfac.ads M src/lib/gnat/s-imenne.adb M src/lib/gnat/s-imenne.ads M src/lib/gnat/s-parame.ads M src/lib/gnat/s-stoele.adb M src/lib/gnat/s-stoele.ads M src/lib/gnat/s-unstyp.ads 7 files changed, 23 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/67828/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/67828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Gerrit-Change-Number: 67828 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: lib/gnat: Remove Compiler_Unit_Warning pragmas
by build bot (Jenkins) (Code Review) 02 Dec '22

02 Dec '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67828 ) Change subject: lib/gnat: Remove Compiler_Unit_Warning pragmas ...................................................................... Patch Set 7: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165154): https://review.coreboot.org/c/coreboot/+/67828/comment/6cd69db2_25ba7160 PS7, Line 12: GCC libgnat-x86_32/lib/gnat/interfac.o Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165154): https://review.coreboot.org/c/coreboot/+/67828/comment/e966ba80_ef711e47 PS7, Line 13: interfac.ads:36:08: warning: unrecognized pragma "Compiler_Unit_Warning" [-gnatwg] Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/67828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Gerrit-Change-Number: 67828 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Dec 2022 05:42:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lib/gnat: Remove Compiler_Unit_Warning pragmas
by Elyes Haouas (Code Review) 02 Dec '22

02 Dec '22

Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67828 to look at the new patch set (#7). Change subject: lib/gnat: Remove Compiler_Unit_Warning pragmas ...................................................................... lib/gnat: Remove Compiler_Unit_Warning pragmas Fix the warning: unrecognized pragma "Compiler_Unit_Warning" [-gnatwg]: GCC libgnat-x86_32/lib/gnat/i-c.o GCC libgnat-x86_32/lib/gnat/interfac.o interfac.ads:36:08: warning: unrecognized pragma "Compiler_Unit_Warning" [-gnatwg] make: *** [Makefile:392 : build/libgnat-x86_32/lib/gnat/interfac.o] Erreur 1 Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/gnat/interfac.ads M src/lib/gnat/s-imenne.adb M src/lib/gnat/s-imenne.ads M src/lib/gnat/s-parame.ads M src/lib/gnat/s-stoele.adb M src/lib/gnat/s-stoele.ads M src/lib/gnat/s-unstyp.ads 7 files changed, 17 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/67828/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/67828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Gerrit-Change-Number: 67828 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: lib/gnat: Remove Compiler_Unit_Warning pragmas
by Elyes Haouas (Code Review) 02 Dec '22

02 Dec '22

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/67828 ) Change subject: lib/gnat: Remove Compiler_Unit_Warning pragmas ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/67828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Gerrit-Change-Number: 67828 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022