Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao, Martin Roth.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69045 )
Change subject: amdfwtool: Add the new entry type for new family morgana
......................................................................
Patch Set 9:
(2 comments)
File util/amdfwtool/amdfwtool.h:
https://review.coreboot.org/c/coreboot/+/69045/comment/2c2d1bd1_580cc233
PS9, Line 71: AMD_FW_TPMLITE = 0x5f,
: AMD_FW_PSP_SMUSCS = 0x5f,
What is AMD_FW_PSP_SMUSCS? its type value can't be same as TPMLITE..
https://review.coreboot.org/c/coreboot/+/69045/comment/2f28bc1d_d76a655d
PS9, Line 77: AMD_FW_MPM = 0x86,
can we explicit name it as AMD_FW_MPM_DRAM for more clarify
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7565c5eda75b332a48613440d7e4cfb388d5012f
Gerrit-Change-Number: 69045
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Sat, 03 Dec 2022 07:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment