Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao, Martin Roth.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69045 )
Change subject: amdfwtool: Add the new entry type for new family morgana
......................................................................
Patch Set 9:
(3 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/69045/comment/16c84b21_a1a2de2c
PS9, Line 303: PSP_BOTH
this is required for only PSP_LVL2, not needed for L1 dir
https://review.coreboot.org/c/coreboot/+/69045/comment/94363d2d_31de7de7
PS9, Line 306: { .type = AMD_RIB, .level = PSP_LVL2 | PSP_BOTH_AB },
can add subprogram 0 and 1 for two different FWs
https://review.coreboot.org/c/coreboot/+/69045/comment/2aae52b1_a8eaf068
PS9, Line 402: { .type = AMD_BIOS_PMUD, .inst = 7, .subpr = 1, .level = BDT_BOTH },
need to add 11,12,13 instance as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7565c5eda75b332a48613440d7e4cfb388d5012f
Gerrit-Change-Number: 69045
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Sat, 03 Dec 2022 07:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment