Attention is currently required from: Martin L Roth.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58745 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Maybe mark them as WIP or even abandon them so that people don't spend time reviewing them as well.. […]
Good day, Martin! Thank you for your attention, I just discovered that - out of 24 changes used directly/indirectly by csb_patcher.sh - these 8 changes (1/3 of 24) don't change the coreboot sources themselves - and therefore (unlike the other 16 "worthy" changes), building these 8 won't provide any new information and is useless:
CB:64873 (csb_patcher.sh itself), CB:58745 (..._dgpu_....sh), CB:58748 (..._atombios_....sh), CB:48427 (..._irq_....sh), CB:44638 (..._cfgsb_....sh) , CB:64829 (config.lenovo_g505s...), CB:64831 (config.asus_am1i-a), CB:64832 (config.asus_a88xm-e)
I am sorry for the inconvenience - and, to help to reduce the workload on coreboot infrastracture, if removing a "signed-off-by" line won't block the git pushes (i.e. in a case when a fresh re-upload is needed) - of course I will do for these patches the next time. Unfortunately, the build queue at https://qa.coreboot.org/ is too long recently, i.e. at the moment it's 72 and I haven't even done anything yet... Thank you and have a nice weekends