Attention is currently required from: Shelley Chen, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 )
Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup ......................................................................
Patch Set 10:
(3 comments)
File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68820/comment/b8912c13_e8674649 PS9, Line 309: switch(sku_id)
space required before the open parenthesis '(' […]
Done
https://review.coreboot.org/c/coreboot/+/68820/comment/3725fa7b_79f8cb82 PS9, Line 309: switch(sku_id)
that open brace { should be on the previous line […]
Done
https://review.coreboot.org/c/coreboot/+/68820/comment/461db535_a222c11e PS9, Line 330: gpio_output(GPP_C9,0);
space required after that ',' (ctx:VxV) […]
Done