Attention is currently required from: Shelley Chen, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68820 )
Change subject: mb/google/poppy: Nami - invoke power cycle of FPMCU on startup ......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68820/comment/c314c858_102b3e83 PS9, Line 309: switch(sku_id)
that open brace { should be on the previous line
Please fix.
https://review.coreboot.org/c/coreboot/+/68820/comment/b448ef38_83080e2d PS9, Line 309: switch(sku_id)
space required before the open parenthesis '('
Please fix.
https://review.coreboot.org/c/coreboot/+/68820/comment/09cacb89_d904fd3a PS9, Line 330: gpio_output(GPP_C9,0);
space required after that ',' (ctx:VxV)
Please fix.