Hello build bot (Jenkins), Tim Wawrzynczak, Mice Lin, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44356
to look at the new patch set (#2).
Change subject: mb/google/volteer: Define stop_gpio for goodix touch screen
......................................................................
mb/google/volteer: Define stop_gpio for goodix touch screen
This applies to the goodix touch screen on both the volteer and
volteer2 variants: Define GPP_E3 as the stop_gpio for the touch screen
"Report_Switch" signal. Goodix defines a 1ms (minimum) delay after
stop off. In addition, no longer drive this GPIO high by default as it
is now controlled by the kernel through ACPI.
BUG=b:153705232
TEST=touch screen still functional on volteer; confirmed timings with
scope (VDD, RESET, REPORT_SWITCH)
Change-Id: I3ead9cf79812d08c4917be4585ed273050465a9b
Signed-off-by: Caveh Jalali <caveh(a)chromium.org>
---
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
M src/mainboard/google/volteer/variants/volteer2/gpio.c
M src/mainboard/google/volteer/variants/volteer2/overridetree.cb
4 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/44356/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/44356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ead9cf79812d08c4917be4585ed273050465a9b
Gerrit-Change-Number: 44356
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Mice Lin <mice_lin(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30168 )
Change subject: [RFC] arch/riscv/stdint.h: Check the size of (u)intptr_t
......................................................................
Patch Set 1:
> Patch Set 1:
>
> > Patch Set 1:
> >
> > It really isn't RISC-V specific, I just haven't figured out a better place.
>
> Do we have ARCH_DIR (or something like that) set up per stage? If so, we can add stdint.h to src/include/ and from there include the arch-specific, arch_stdint.h or something, then put your checks in src/include/stdint.h. Or it might be even better to collapse/move all the src/arch/<blah>/include/stdint.h into src/include/stdint.h and #if guard them based on rules.h.
already done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5583ba58eeca3a37229b41b6517adfc12b2fddce
Gerrit-Change-Number: 30168
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 12 Aug 2020 07:40:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment