HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30168 )
Change subject: [RFC] arch/riscv/stdint.h: Check the size of (u)intptr_t
......................................................................
Patch Set 1:
> Patch Set 1:
>
> > Patch Set 1:
> >
> > It really isn't RISC-V specific, I just haven't figured out a better place.
>
> Do we have ARCH_DIR (or something like that) set up per stage? If so, we can add stdint.h to src/include/ and from there include the arch-specific, arch_stdint.h or something, then put your checks in src/include/stdint.h. Or it might be even better to collapse/move all the src/arch/<blah>/include/stdint.h into src/include/stdint.h and #if guard them based on rules.h.
already done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5583ba58eeca3a37229b41b6517adfc12b2fddce
Gerrit-Change-Number: 30168
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 12 Aug 2020 07:40:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART2
......................................................................
mb/prodrive/hermes: Add multifunction device for UART2
Multifunction device at 19.0 needs to be enabled such that 19.2 gets
scanned.
Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4
Signed-off-by: Christian Walter <christian.walter(a)9elements.com>
---
M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/43481/1
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
index 6c6fe2d..48ab0fe 100644
--- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
+++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
@@ -177,7 +177,8 @@
device pci 14.3 on end # CNVi wifi
end
- device pci 19.2 on end # UART #2
+ device pci 19.0 hidden end
+ device pci 19.2 on end # UART #2
device pci 1b.4 on
smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "SLOT1" "SlotDataBusWidth4X"
--
To view, visit https://review.coreboot.org/c/coreboot/+/43481
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4
Gerrit-Change-Number: 43481
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-MessageType: newchange
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44260 )
Change subject: soc/intel/tigerlake: Add IRQs for LPSS uart
......................................................................
soc/intel/tigerlake: Add IRQs for LPSS uart
Values are taken from pci_irqs.asl.
The common code will make use of those defines to generate ACPI
SSDT code for LPSS uarts operating in "APCI mode".
Change-Id: I5ef93493965834cda30d70918e65de3129e547b7
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/soc/intel/tigerlake/include/soc/irq.h
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/44260/1
diff --git a/src/soc/intel/tigerlake/include/soc/irq.h b/src/soc/intel/tigerlake/include/soc/irq.h
index ad70290..f95f9f6 100644
--- a/src/soc/intel/tigerlake/include/soc/irq.h
+++ b/src/soc/intel/tigerlake/include/soc/irq.h
@@ -9,4 +9,8 @@
#define PCH_IRQ10 10
#define PCH_IRQ11 11
+#define LPSS_UART0_IRQ 16
+#define LPSS_UART1_IRQ 17
+#define LPSS_UART2_IRQ 33
+
#endif /* _SOC_IRQ_H_ */
--
To view, visit https://review.coreboot.org/c/coreboot/+/44260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ef93493965834cda30d70918e65de3129e547b7
Gerrit-Change-Number: 44260
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newchange