Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
soc/intel/common/block/sata: Add common sata driver
Enable PCI_COMMAND_MASTER for SATA controller.
BUG=b:154900210 TEST=Able to build and boot CML and TGL platform.
Change-Id: Icc6653c26900354df4ee6e5882c60cbe23a5685c Signed-off-by: Subrata Banik subrata.banik@intel.com --- A src/soc/intel/common/block/sata/Kconfig A src/soc/intel/common/block/sata/Makefile.inc A src/soc/intel/common/block/sata/sata.c M src/soc/intel/common/pch/Kconfig 4 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/44299/1
diff --git a/src/soc/intel/common/block/sata/Kconfig b/src/soc/intel/common/block/sata/Kconfig new file mode 100644 index 0000000..6b24f59 --- /dev/null +++ b/src/soc/intel/common/block/sata/Kconfig @@ -0,0 +1,4 @@ +config SOC_INTEL_COMMON_BLOCK_SATA + bool + help + Intel Processor common SATA support diff --git a/src/soc/intel/common/block/sata/Makefile.inc b/src/soc/intel/common/block/sata/Makefile.inc new file mode 100644 index 0000000..623d151 --- /dev/null +++ b/src/soc/intel/common/block/sata/Makefile.inc @@ -0,0 +1 @@ +ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_SATA) += sata.c diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c new file mode 100644 index 0000000..5a93ece --- /dev/null +++ b/src/soc/intel/common/block/sata/sata.c @@ -0,0 +1,75 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <device/device.h> +#include <device/pci.h> +#include <device/pci_ids.h> + +static void sata_final(struct device *dev) +{ + /* Set Bus Master */ + pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); +} + +static struct device_operations sata_ops = { + .read_resources = pci_dev_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .final = sata_final, + .ops_pci = &pci_dev_ops_pci, +}; + +static const unsigned short pci_device_ids[] = { + PCI_DEVICE_ID_INTEL_SPT_U_SATA, + PCI_DEVICE_ID_INTEL_SPT_U_Y_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_SPT_KBL_SATA, + PCI_DEVICE_ID_INTEL_LWB_SATA_AHCI, + PCI_DEVICE_ID_INTEL_LWB_SSATA_AHCI, + PCI_DEVICE_ID_INTEL_LWB_SATA_RAID, + PCI_DEVICE_ID_INTEL_LWB_SSATA_RAID, + PCI_DEVICE_ID_INTEL_LWB_SATA_AHCI_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SSATA_AHCI_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SATA_RAID_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SSATA_RAID_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SATA_ALT, + PCI_DEVICE_ID_INTEL_LWB_SATA_ALT_RST, + PCI_DEVICE_ID_INTEL_LWB_SSATA_ALT, + PCI_DEVICE_ID_INTEL_LWB_SSATA_ALT_RST, + PCI_DEVICE_ID_INTEL_CNL_SATA, + PCI_DEVICE_ID_INTEL_CNL_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_CNP_CMP_COMPAT_SATA, + PCI_DEVICE_ID_INTEL_CNP_H_SATA, + PCI_DEVICE_ID_INTEL_CNP_LP_SATA, + PCI_DEVICE_ID_INTEL_ICP_U_SATA, + PCI_DEVICE_ID_INTEL_CMP_SATA, + PCI_DEVICE_ID_INTEL_CMP_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_CMP_LP_SATA, + PCI_DEVICE_ID_INTEL_CMP_H_SATA, + PCI_DEVICE_ID_INTEL_CMP_H_HALO_SATA, + PCI_DEVICE_ID_INTEL_CMP_H_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_TGP_LP_SATA, + PCI_DEVICE_ID_INTEL_TGP_SATA, + PCI_DEVICE_ID_INTEL_TGP_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_TGP_COMPAT_SATA, + PCI_DEVICE_ID_INTEL_MCC_AHCI_SATA, + PCI_DEVICE_ID_INTEL_JSP_SATA_1, + PCI_DEVICE_ID_INTEL_JSP_SATA_2, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_1, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_2, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_3, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_4, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_5, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_6, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_1, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_2, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_3, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_4, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_5, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_6, + 0 +}; + +static const struct pci_driver pch_sata __pci_driver = { + .ops = &sata_ops, + .vendor = PCI_VENDOR_ID_INTEL, + .devices = pci_device_ids, +}; diff --git a/src/soc/intel/common/pch/Kconfig b/src/soc/intel/common/pch/Kconfig index 6e7f2f6..cca65d6 100644 --- a/src/soc/intel/common/pch/Kconfig +++ b/src/soc/intel/common/pch/Kconfig @@ -32,6 +32,7 @@ select SOC_INTEL_COMMON_BLOCK_PCR select SOC_INTEL_COMMON_BLOCK_PMC select SOC_INTEL_COMMON_BLOCK_RTC + select SOC_INTEL_COMMON_BLOCK_SATA select SOC_INTEL_COMMON_BLOCK_SMBUS select SOC_INTEL_COMMON_BLOCK_SPI select SOC_INTEL_COMMON_BLOCK_TCO
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 74: .devices = pci_device_ids, is it me, or does the alignment look off here?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 74: .devices = pci_device_ids,
is it me, or does the alignment look off here?
its one tab only
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 74: .devices = pci_device_ids,
its one tab only
yes, but when tabs are 8 characters wide, the tab on `devices` starts on the next tabstop (and the `= pci_device_ids` part is one tab too much to the right). I generally indent these with spaces because of this problem.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44299
to look at the new patch set (#4).
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
soc/intel/common/block/sata: Add common sata driver
Enable PCI_COMMAND_MASTER for SATA controller.
BUG=b:154900210 TEST=Able to build and boot CML and TGL platform.
Change-Id: Icc6653c26900354df4ee6e5882c60cbe23a5685c Signed-off-by: Subrata Banik subrata.banik@intel.com --- A src/soc/intel/common/block/sata/Kconfig A src/soc/intel/common/block/sata/Makefile.inc A src/soc/intel/common/block/sata/sata.c M src/soc/intel/common/pch/Kconfig 4 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/44299/4
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 74: .devices = pci_device_ids,
yes, but when tabs are 8 characters wide, the tab on `devices` starts on the next tabstop (and the ` […]
Ack
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/Kconfig:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 4: Intel Processor nit: Intel SoC?
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 2: nit: extra line?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/Kconfig:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 4: Intel Processor
nit: Intel SoC?
Or `Intel PCH` (not everything is a SoC)
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44299
to look at the new patch set (#5).
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
soc/intel/common/block/sata: Add common sata driver
Enable PCI_COMMAND_MASTER for SATA controller.
BUG=b:154900210 TEST=Able to build and boot CML and TGL platform.
Change-Id: Icc6653c26900354df4ee6e5882c60cbe23a5685c Signed-off-by: Subrata Banik subrata.banik@intel.com --- A src/soc/intel/common/block/sata/Kconfig A src/soc/intel/common/block/sata/Makefile.inc A src/soc/intel/common/block/sata/sata.c M src/soc/intel/common/pch/Kconfig 4 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/44299/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44299
to look at the new patch set (#6).
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
soc/intel/common/block/sata: Add common sata driver
Enable PCI_COMMAND_MASTER for SATA controller.
BUG=b:154900210 TEST=Able to build and boot CML and TGL platform.
Change-Id: Icc6653c26900354df4ee6e5882c60cbe23a5685c Signed-off-by: Subrata Banik subrata.banik@intel.com --- A src/soc/intel/common/block/sata/Kconfig A src/soc/intel/common/block/sata/Makefile.inc A src/soc/intel/common/block/sata/sata.c M src/soc/intel/common/pch/Kconfig 4 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/44299/6
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/Kconfig:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 4: Intel Processor
Or `Intel PCH` (not everything is a SoC)
Ack
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 2:
nit: extra line?
https://qa.coreboot.org/job/coreboot-gerrit/137939/testReport/junit/(root)/l...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 6: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44299/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44299/6//COMMIT_MSG@7 PS6, Line 7: sata SATA
https://review.coreboot.org/c/coreboot/+/44299/6//COMMIT_MSG@9 PS6, Line 9: Enable PCI_COMMAND_MASTER for SATA controller. Please give more background, why this driver is needed.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common sata driver ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44299/1/src/soc/intel/common/block/... PS1, Line 2:
https://qa.coreboot. […]
😎 Thanks!
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Sridhar Siricilla, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44299
to look at the new patch set (#7).
Change subject: soc/intel/common/block/sata: Add common SATA driver ......................................................................
soc/intel/common/block/sata: Add common SATA driver
Enable PCI_COMMAND_MASTER for SATA controller to ensure device can behave as a bus master. Otherwise, the device can not generate PCI accesses.
BUG=b:154900210 TEST=Able to build and boot CML and TGL platform.
Change-Id: Icc6653c26900354df4ee6e5882c60cbe23a5685c Signed-off-by: Subrata Banik subrata.banik@intel.com --- A src/soc/intel/common/block/sata/Kconfig A src/soc/intel/common/block/sata/Makefile.inc A src/soc/intel/common/block/sata/sata.c M src/soc/intel/common/pch/Kconfig 4 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/44299/7
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common SATA driver ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44299/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44299/6//COMMIT_MSG@7 PS6, Line 7: sata
SATA
Ack
https://review.coreboot.org/c/coreboot/+/44299/6//COMMIT_MSG@9 PS6, Line 9: Enable PCI_COMMAND_MASTER for SATA controller.
Please give more background, why this driver is needed.
Ack
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common SATA driver ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/7/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/44299/7/src/soc/intel/common/block/... PS7, Line 7: static void sata_final(struct device *dev) : { : /* Set Bus Master */ : pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); : } Not for this change, but I wonder if this should be done for all controllers i.e. not just SATA by using a common helper function.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common SATA driver ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44299/7/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/44299/7/src/soc/intel/common/block/... PS7, Line 7: static void sata_final(struct device *dev) : { : /* Set Bus Master */ : pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); : }
Not for this change, but I wonder if this should be done for all controllers i.e. […]
good feedback Furquan, let me come up with changes
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44299 )
Change subject: soc/intel/common/block/sata: Add common SATA driver ......................................................................
soc/intel/common/block/sata: Add common SATA driver
Enable PCI_COMMAND_MASTER for SATA controller to ensure device can behave as a bus master. Otherwise, the device can not generate PCI accesses.
BUG=b:154900210 TEST=Able to build and boot CML and TGL platform.
Change-Id: Icc6653c26900354df4ee6e5882c60cbe23a5685c Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44299 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Sridhar Siricilla sridhar.siricilla@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/soc/intel/common/block/sata/Kconfig A src/soc/intel/common/block/sata/Makefile.inc A src/soc/intel/common/block/sata/sata.c M src/soc/intel/common/pch/Kconfig 4 files changed, 81 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Sridhar Siricilla: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/sata/Kconfig b/src/soc/intel/common/block/sata/Kconfig new file mode 100644 index 0000000..c7253ae --- /dev/null +++ b/src/soc/intel/common/block/sata/Kconfig @@ -0,0 +1,4 @@ +config SOC_INTEL_COMMON_BLOCK_SATA + bool + help + Common SATA module for Intel PCH diff --git a/src/soc/intel/common/block/sata/Makefile.inc b/src/soc/intel/common/block/sata/Makefile.inc new file mode 100644 index 0000000..623d151 --- /dev/null +++ b/src/soc/intel/common/block/sata/Makefile.inc @@ -0,0 +1 @@ +ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_SATA) += sata.c diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c new file mode 100644 index 0000000..1889700 --- /dev/null +++ b/src/soc/intel/common/block/sata/sata.c @@ -0,0 +1,75 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <device/device.h> +#include <device/pci.h> +#include <device/pci_ids.h> + +static void sata_final(struct device *dev) +{ + /* Set Bus Master */ + pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); +} + +static struct device_operations sata_ops = { + .read_resources = pci_dev_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .final = sata_final, + .ops_pci = &pci_dev_ops_pci, +}; + +static const unsigned short pci_device_ids[] = { + PCI_DEVICE_ID_INTEL_SPT_U_SATA, + PCI_DEVICE_ID_INTEL_SPT_U_Y_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_SPT_KBL_SATA, + PCI_DEVICE_ID_INTEL_LWB_SATA_AHCI, + PCI_DEVICE_ID_INTEL_LWB_SSATA_AHCI, + PCI_DEVICE_ID_INTEL_LWB_SATA_RAID, + PCI_DEVICE_ID_INTEL_LWB_SSATA_RAID, + PCI_DEVICE_ID_INTEL_LWB_SATA_AHCI_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SSATA_AHCI_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SATA_RAID_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SSATA_RAID_SUPER, + PCI_DEVICE_ID_INTEL_LWB_SATA_ALT, + PCI_DEVICE_ID_INTEL_LWB_SATA_ALT_RST, + PCI_DEVICE_ID_INTEL_LWB_SSATA_ALT, + PCI_DEVICE_ID_INTEL_LWB_SSATA_ALT_RST, + PCI_DEVICE_ID_INTEL_CNL_SATA, + PCI_DEVICE_ID_INTEL_CNL_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_CNP_CMP_COMPAT_SATA, + PCI_DEVICE_ID_INTEL_CNP_H_SATA, + PCI_DEVICE_ID_INTEL_CNP_LP_SATA, + PCI_DEVICE_ID_INTEL_ICP_U_SATA, + PCI_DEVICE_ID_INTEL_CMP_SATA, + PCI_DEVICE_ID_INTEL_CMP_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_CMP_LP_SATA, + PCI_DEVICE_ID_INTEL_CMP_H_SATA, + PCI_DEVICE_ID_INTEL_CMP_H_HALO_SATA, + PCI_DEVICE_ID_INTEL_CMP_H_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_TGP_LP_SATA, + PCI_DEVICE_ID_INTEL_TGP_SATA, + PCI_DEVICE_ID_INTEL_TGP_PREMIUM_SATA, + PCI_DEVICE_ID_INTEL_TGP_COMPAT_SATA, + PCI_DEVICE_ID_INTEL_MCC_AHCI_SATA, + PCI_DEVICE_ID_INTEL_JSP_SATA_1, + PCI_DEVICE_ID_INTEL_JSP_SATA_2, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_1, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_2, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_3, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_4, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_5, + PCI_DEVICE_ID_INTEL_ADP_P_SATA_6, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_1, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_2, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_3, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_4, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_5, + PCI_DEVICE_ID_INTEL_ADP_S_SATA_6, + 0 +}; + +static const struct pci_driver pch_sata __pci_driver = { + .ops = &sata_ops, + .vendor = PCI_VENDOR_ID_INTEL, + .devices = pci_device_ids, +}; diff --git a/src/soc/intel/common/pch/Kconfig b/src/soc/intel/common/pch/Kconfig index 6e7f2f6..cca65d6 100644 --- a/src/soc/intel/common/pch/Kconfig +++ b/src/soc/intel/common/pch/Kconfig @@ -32,6 +32,7 @@ select SOC_INTEL_COMMON_BLOCK_PCR select SOC_INTEL_COMMON_BLOCK_PMC select SOC_INTEL_COMMON_BLOCK_RTC + select SOC_INTEL_COMMON_BLOCK_SATA select SOC_INTEL_COMMON_BLOCK_SMBUS select SOC_INTEL_COMMON_BLOCK_SPI select SOC_INTEL_COMMON_BLOCK_TCO
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)
-
Sridhar Siricilla (Code Review)
-
Subrata Banik (Code Review)