coreboot-gerrit August 2020

coreboot-gerrit@coreboot.org

1 participants
2457 discussions

Change in coreboot[master]: post_code: replace postcode constants with their defines in CAR stage
by Arthur Heymans (Code Review) 01 Aug '20

01 Aug '20

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43590 ) Change subject: post_code: replace postcode constants with their defines in CAR stage ...................................................................... Patch Set 7: (6 comments) Some suggestions on the P4 CAR init code that is not shared with other CAR init code. Given that some post codes might change after this it might be worth it to send a notification about this on the mailing list? OTOH CAR code rarely needs debugging these days... https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbu… File src/cpu/intel/car/p4-netburst/cache_as_ram.S: https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbu… PS7, Line 55: movl $MTRR_DEF_TYPE_MSR, %ecx : rdmsr : andl $(~0x00000cff), %eax : wrmsr : : post_code(0x22) This disables fixed and variable MTRR's. Maybe add a postcode define for that too? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbu… PS7, Line 118: post_code(0x24) maybe define POST_LAPIC_INIT_IPI_DONE ? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbu… PS7, Line 168: post_code(0x26) maybe define POST_LAPIC_START_IPI_DONE ? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbu… PS7, Line 184: post_code(0x27) POST_AP_INIT ? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbu… PS7, Line 191: post_code(0x28 POST_AP_INIT_VAR_MTRR https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbu… PS7, Line 199: post_code(0x29) POST_AP_HALT -- To view, visit https://review.coreboot.org/c/coreboot/+/43590 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied0d6b41deed6db5eb3b39514664eb9bcc322c20 Gerrit-Change-Number: 43590 Gerrit-PatchSet: 7 Gerrit-Owner: Sindhoor Tilak <sindhoor(a)sin9yt.net> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Aug 2020 17:21:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: post_code: exit_car.S postcodes replace
by Paul Menzel (Code Review) 01 Aug '20

01 Aug '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43592 ) Change subject: post_code: exit_car.S postcodes replace ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/c/coreboot/+/43592/7//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/43592/7//COMMIT_MSG@7 PS7, Line 7: post_code: exit_car.S postcodes replace Please make it a statement by adding a verb (in imperative mood). -- To view, visit https://review.coreboot.org/c/coreboot/+/43592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I099c906c531e5b0e12dd66a8981ff805d2d2e46b Gerrit-Change-Number: 43592 Gerrit-PatchSet: 7 Gerrit-Owner: Sindhoor Tilak <sindhoor(a)sin9yt.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Aug 2020 07:08:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add Alderlake platform support under IFDv2
by Subrata Banik (Code Review) 01 Aug '20

01 Aug '20

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39533 ) Change subject: util/ifdtool: Add Alderlake platform support under IFDv2 ...................................................................... util/ifdtool: Add Alderlake platform support under IFDv2 Change-Id: Ief8ab6ad280d8a2625404c19d57cd2a24f23cf13 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39533 Reviewed-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Wonkyu Kim: Looks good to me, approved diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index f64dc7e..7f4753d 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -210,6 +210,7 @@ PLATFORM_ICL, PLATFORM_TGL, PLATFORM_JSL, + PLATFORM_ADL, }; unsigned int i; @@ -1018,6 +1019,7 @@ case PLATFORM_SKLKBL: case PLATFORM_TGL: case PLATFORM_JSL: + case PLATFORM_ADL: /* CPU/BIOS can read descriptor and BIOS. */ fmba->flmstr1 |= (1 << REGION_DESC) << rd_shift; fmba->flmstr1 |= (1 << REGION_BIOS) << rd_shift; @@ -1689,6 +1691,8 @@ platform = PLATFORM_SKLKBL; } else if (!strcmp(optarg, "tgl")) { platform = PLATFORM_TGL; + } else if (!strcmp(optarg, "adl")) { + platform = PLATFORM_ADL; } else { fprintf(stderr, "Unknown platform: %s\n", optarg); exit(EXIT_FAILURE); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index 3b16d49..840d7fe 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -48,6 +48,7 @@ PLATFORM_JSL, PLATFORM_SKLKBL, PLATFORM_TGL, + PLATFORM_ADL, }; #define LAYOUT_LINELEN 80 -- To view, visit https://review.coreboot.org/c/coreboot/+/39533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief8ab6ad280d8a2625404c19d57cd2a24f23cf13 Gerrit-Change-Number: 39533 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/ifdtool: Make JSL platform entry for lock_descriptor
by Subrata Banik (Code Review) 01 Aug '20

01 Aug '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44057 ) Change subject: util/ifdtool: Make JSL platform entry for lock_descriptor ...................................................................... util/ifdtool: Make JSL platform entry for lock_descriptor Change-Id: Ia2ddb4eceab29810b22766a0f241ba4b11e79538 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M util/ifdtool/ifdtool.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/44057/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 3db3977..f64dc7e 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1017,6 +1017,7 @@ case PLATFORM_ICL: case PLATFORM_SKLKBL: case PLATFORM_TGL: + case PLATFORM_JSL: /* CPU/BIOS can read descriptor and BIOS. */ fmba->flmstr1 |= (1 << REGION_DESC) << rd_shift; fmba->flmstr1 |= (1 << REGION_BIOS) << rd_shift; -- To view, visit https://review.coreboot.org/c/coreboot/+/44057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ddb4eceab29810b22766a0f241ba4b11e79538 Gerrit-Change-Number: 44057 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: trogdor: SoC makefile BLOB support
by Julius Werner (Code Review) 01 Aug '20

01 Aug '20

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 ) Change subject: trogdor: SoC makefile BLOB support ...................................................................... Patch Set 86: (5 comments) https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/M… File src/soc/qualcomm/sc7180/Makefile.inc: https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/M… PS84, Line 70: SC7180_BLOB := $(top)/3rdparty/blobs/soc/qualcomm/sc7180 > Please fix this to point to 3rdparty/qc_blobs/sc7180 where the files now actually reside. Done https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/M… PS84, Line 78: none > Please make this $(CBFS_COMPRESS_FLAG) All of these others should be okay using $(CBFS_COMPRESS_FLAG), not $(CBFS_PRERAM_COMPRESS_FLAG). Only QcLib should need the PRERAM because it's so big (the difference under the hood is that LZ4 can decompress in-place while LZMA requires a scratch buffer in the CBFS_CACHE region to load the file). It should theoretically make things slightly more efficient. https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/M… PS84, Line 87: none > and this $(CBFS_PRERAM_COMPRESS_FLAG) Done https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/M… PS84, Line 107: BL31_FILE := $(SC7180_BLOB)/qtiseclib/bl31.elf > Please remove this whole file, this doesn't belong here. […] Done https://review.coreboot.org/c/coreboot/+/35508/86/src/soc/qualcomm/sc7180/M… File src/soc/qualcomm/sc7180/Makefile.inc: https://review.coreboot.org/c/coreboot/+/35508/86/src/soc/qualcomm/sc7180/M… PS86, Line 68: BL31_MAKEARGS += PLAT=sc7180 Sorry we also need a QTISECLIB_PATH=$(SC7180_BLOB)/qtiseclib/libqtisec.a as part of BL31_MAKEARGS (and then reorder SC7180_BLOB definition above it, of course). Forgot that one. -- To view, visit https://review.coreboot.org/c/coreboot/+/35508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1 Gerrit-Change-Number: 35508 Gerrit-PatchSet: 86 Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: ashk(a)codeaurora.org Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Aug 2020 01:48:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: post_code: add defines for missing postcode values
by Sindhoor Tilak (Code Review) 01 Aug '20

01 Aug '20

Sindhoor Tilak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42278 ) Change subject: post_code: add defines for missing postcode values ...................................................................... Abandoned Change is split stage wise -- To view, visit https://review.coreboot.org/c/coreboot/+/42278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02d09d0b2bad3f9a93fff54d11a5ba5e53fadbcc Gerrit-Change-Number: 42278 Gerrit-PatchSet: 13 Gerrit-Owner: Sindhoor Tilak <sindhoor(a)sin9yt.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: trogdor: SoC makefile BLOB support
by mturney mturney (Code Review) 01 Aug '20

01 Aug '20

Hello Ravi kumar, build bot (Jenkins), Patrick Georgi, Martin Roth, ashk(a)codeaurora.org, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35508 to look at the new patch set (#86). Change subject: trogdor: SoC makefile BLOB support ...................................................................... trogdor: SoC makefile BLOB support Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1 Signed-off-by: Ashwin Kumar <ashk(a)codeaurora.org> --- M src/soc/qualcomm/sc7180/Makefile.inc 1 file changed, 78 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35508/86 -- To view, visit https://review.coreboot.org/c/coreboot/+/35508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1 Gerrit-Change-Number: 35508 Gerrit-PatchSet: 86 Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: ashk(a)codeaurora.org Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2020