Change in coreboot[master]: post_code: replace postcode constants with their defines in CAR stage
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43590 ) Change subject: post_code: replace postcode constants with their defines in CAR stage ...................................................................... Patch Set 7: (6 comments) Some suggestions on the P4 CAR init code that is not shared with other CAR init code. Given that some post codes might change after this it might be worth it to send a notification about this on the mailing list? OTOH CAR code rarely needs debugging these days... https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... File src/cpu/intel/car/p4-netburst/cache_as_ram.S: https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 55: movl $MTRR_DEF_TYPE_MSR, %ecx : rdmsr : andl $(~0x00000cff), %eax : wrmsr : : post_code(0x22) This disables fixed and variable MTRR's. Maybe add a postcode define for that too? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 118: post_code(0x24) maybe define POST_LAPIC_INIT_IPI_DONE ? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 168: post_code(0x26) maybe define POST_LAPIC_START_IPI_DONE ? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 184: post_code(0x27) POST_AP_INIT ? https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 191: post_code(0x28 POST_AP_INIT_VAR_MTRR https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 199: post_code(0x29) POST_AP_HALT -- To view, visit https://review.coreboot.org/c/coreboot/+/43590 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied0d6b41deed6db5eb3b39514664eb9bcc322c20 Gerrit-Change-Number: 43590 Gerrit-PatchSet: 7 Gerrit-Owner: Sindhoor Tilak <sindhoor@sin9yt.net> Gerrit-Reviewer: Huang Jin <huang.jin@intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Aug 2020 17:21:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
Arthur Heymans (Code Review)