Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43590 )
Change subject: post_code: replace postcode constants with their defines in CAR stage ......................................................................
Patch Set 7:
(6 comments)
Some suggestions on the P4 CAR init code that is not shared with other CAR init code. Given that some post codes might change after this it might be worth it to send a notification about this on the mailing list? OTOH CAR code rarely needs debugging these days...
https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... File src/cpu/intel/car/p4-netburst/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 55: movl $MTRR_DEF_TYPE_MSR, %ecx : rdmsr : andl $(~0x00000cff), %eax : wrmsr : : post_code(0x22) This disables fixed and variable MTRR's. Maybe add a postcode define for that too?
https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 118: post_code(0x24) maybe define POST_LAPIC_INIT_IPI_DONE ?
https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 168: post_code(0x26) maybe define POST_LAPIC_START_IPI_DONE ?
https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 184: post_code(0x27) POST_AP_INIT ?
https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 191: post_code(0x28 POST_AP_INIT_VAR_MTRR
https://review.coreboot.org/c/coreboot/+/43590/7/src/cpu/intel/car/p4-netbur... PS7, Line 199: post_code(0x29) POST_AP_HALT