Some suggestions on the P4 CAR init code that is not shared with other CAR init code.
Given that some post codes might change after this it might be worth it to send a notification about this on the mailing list? OTOH CAR code rarely needs debugging these days...

View Change

6 comments:

• File src/cpu/intel/car/p4-netburst/cache_as_ram.S:

  • Patch Set #7, Line 55:

    movl	$MTRR_DEF_TYPE_MSR, %ecx
    	rdmsr
    	andl	$(~0x00000cff), %eax
    	wrmsr
    
    	post_code(0x22)
    

    This disables fixed and variable MTRR's. Maybe add a postcode define for that too?

  • Patch Set #7, Line 118: post_code(0x24)

    maybe define POST_LAPIC_INIT_IPI_DONE ?

  • Patch Set #7, Line 168: post_code(0x26)

    maybe define POST_LAPIC_START_IPI_DONE ?

  • Patch Set #7, Line 184: post_code(0x27)

    POST_AP_INIT ?

  • Patch Set #7, Line 191: post_code(0x28

    POST_AP_INIT_VAR_MTRR

  • Patch Set #7, Line 199: post_code(0x29)

    POST_AP_HALT

To view, visit change 43590. To unsubscribe, or for help writing mail filters, visit settings.