Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44356 )
Change subject: mb/google/volteer: Define stop_gpio for goodix touch screen ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44356/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44356/1//COMMIT_MSG@11 PS1, Line 11: defins
defines
Done
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... PS1, Line 93: 120
have you tried 10ms here?
no, i haven't tried to optimize these values. i'm not even sure where they came from other than the likely copy-paste from other projects.
i did find an interesting reference here: https://review.coreboot.org/c/coreboot/+/36655 which leads me to believe that we should not lightly tinker with these values.
at this point, my touchscreen sample size is 1 and it's a loose panel. we should wait for a stable reference platform to do the tuning.
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... PS1, Line 98: 12
same, have you tried 10 here?
Ack
-
Caveh Jalali (Code Review)