coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Kenji Yu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/blobs/+/86251/comment/3819cd27_d067a232?usp=e… : PS5, Line 9: 1. remove -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 5 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 08:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: tests: Add unit tests for CFR
by Patrick Rudolph (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78506?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: tests: Add unit tests for CFR ...................................................................... tests: Add unit tests for CFR Add unit-tests for CFR with a coverage of 96.74%. Change-Id: I758b157c97362a01fa89a8ad9d79bb154cbfb2c0 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- A src/commonlib/bsd/cfr_parser.c A src/commonlib/bsd/include/commonlib/bsd/cfr_parser.h M tests/drivers/Makefile.mk A tests/drivers/cfr.c 4 files changed, 1,063 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/78506/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/78506?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I758b157c97362a01fa89a8ad9d79bb154cbfb2c0 Gerrit-Change-Number: 78506 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Kenji Yu (Code Review) 02 Feb '25

02 Feb '25

Kenji Yu has uploaded a new patch set (#5). ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v3.0 1. Update sspm.bin to disable waking up SPM function. TEST=Build pass BUG=b:387181201, b:385829129 Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/51/86251/5 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 5 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Kenji Yu (Code Review) 02 Feb '25

02 Feb '25

Kenji Yu has uploaded a new patch set (#4). ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v3.0 1. Update sspm.bin to disable waking up SPM function. TEST=Build pass BUG=b:387181201 385829129 Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/51/86251/4 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 4 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Kenji Yu (Code Review) 02 Feb '25

02 Feb '25

Kenji Yu has uploaded a new patch set (#3). ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v3.0 1. Update sspm.bin to disable waking up SPM function. TEST=Build pass BUG=b:387181201 Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/51/86251/3 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 3 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Kenji Yu (Code Review) 02 Feb '25

02 Feb '25

Kenji Yu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v3.0 1. Update sspm.bin to disable waking up SPM function. Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/51/86251/2 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 2 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v2.0
by Kenji Yu (Code Review) 02 Feb '25

02 Feb '25

Kenji Yu has uploaded this change for review. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v2.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v2.0 1. Update sspm.bin to disable waking up SPM function. Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/51/86251/1 diff --git a/soc/mediatek/mt8196/sspm.bin b/soc/mediatek/mt8196/sspm.bin old mode 100644 new mode 100755 index 099712d..2e7d54f --- a/soc/mediatek/mt8196/sspm.bin +++ b/soc/mediatek/mt8196/sspm.bin Binary files differ diff --git a/soc/mediatek/mt8196/sspm.bin.md5 b/soc/mediatek/mt8196/sspm.bin.md5 index bff7731..9663b03 100644 --- a/soc/mediatek/mt8196/sspm.bin.md5 +++ b/soc/mediatek/mt8196/sspm.bin.md5 @@ -1 +1 @@ -3cdf43a33dbdb417d8da460c61e0caef *sspm.bin +f6cd83a73a4e633ab8d531622e765d98 *sspm.bin diff --git a/soc/mediatek/mt8196/sspm_release_notes.txt b/soc/mediatek/mt8196/sspm_release_notes.txt index e7876db..15b2635 100644 --- a/soc/mediatek/mt8196/sspm_release_notes.txt +++ b/soc/mediatek/mt8196/sspm_release_notes.txt @@ -1,5 +1,8 @@ ** Build from MediaTek Internal ** +# Version 3.0 +1. Update sspm.bin to disable waking up SPM function. + # Version 2.0 1. Update sspm.bin to support SLBC function. -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 1 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: tree: Use true, false for DspEnable
by Elyes Haouas (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Elyes Haouas, Jonathon Hall, Piotr Król. Hello Jonathon Hall, Maxim Polyakov, Michał Żygowski, Piotr Król, Sean Rhodes, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86189?usp=email to look at the new patch set (#2). Change subject: tree: Use true, false for DspEnable ...................................................................... tree: Use true, false for DspEnable DspEnable is a boolean, so use true false instead of 0 1. Change-Id: I5bab9db3632848f92732160bb821dda8cdb14281 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/51nb/x210/devicetree.cb M src/mainboard/acer/aspire_vn7_572g/devicetree.cb M src/mainboard/google/eve/devicetree.cb M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb M src/mainboard/intel/kblrvp/variants/rvp3/overridetree.cb M src/mainboard/intel/kunimitsu/devicetree.cb M src/mainboard/intel/saddlebrook/devicetree.cb M src/mainboard/libretrend/lt1000/devicetree.cb M src/mainboard/protectli/vault_kbl/devicetree.cb M src/mainboard/purism/librem_skl/devicetree.cb M src/mainboard/razer/blade_stealth_kbl/devicetree.cb 20 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/86189/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5bab9db3632848f92732160bb821dda8cdb14281 Gerrit-Change-Number: 86189 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Remove Wno-packed-not-aligned flag
by Elyes Haouas (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Felix Singer, Julius Werner, Martin L Roth, Paul Menzel. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84562?usp=email ) Change subject: Makefile.mk: Remove Wno-packed-not-aligned flag ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/84562?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8759603ff7b2c75e4a863a25c796781544be14ed Gerrit-Change-Number: 84562 Gerrit-PatchSet: 22 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Feb 2025 06:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: xcompile: Use Walloc-size GCC option
by Elyes Haouas (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84074?usp=email ) Change subject: xcompile: Use Walloc-size GCC option ...................................................................... Patch Set 23: (1 comment) Patchset: PS23: Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/84074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5d36b073bb5b4cccb0cf2b67b43edb3f97f168c Gerrit-Change-Number: 84074 Gerrit-PatchSet: 23 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 03 Feb 2025 06:25:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025