coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[M] Change in coreboot[main]: mb/google/trulo/var/uldrenite: Add fw_config probe for touchscreen
by John Su (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86144?usp=email ) Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for touchscreen ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Could reviewers help to review this CL? -- To view, visit https://review.coreboot.org/c/coreboot/+/86144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I63512e85052bce974ffb0b738164bea440bd413c Gerrit-Change-Number: 86144 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Feb 2025 09:16:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
by Jarried Lin (Code Review) 03 Feb '25

03 Feb '25

Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/blobs/+/86253?usp=email ) Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ...................................................................... soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 The initialization of mtk_fsp_ramstage in the ramstage includes: - UFS mphy settings. - DPAC (Device Access Permission Control) settings. - MMinfra (Multimedia Infrastrucutre) settings. - SMPU (Security Memory Protection Unit) settings. - Advanced CPU frequency control. TEST=Build pass BUG=b:373797027 Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/mtk_fsp_ramstage.elf A soc/mediatek/mt8196/mtk_fsp_ramstage.elf.md5 A soc/mediatek/mt8196/mtk_fsp_ramstage_release_notes.txt 4 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/53/86253/1 diff --git a/soc/mediatek/mt8196/README.md b/soc/mediatek/mt8196/README.md index be063d5..67899ec 100644 --- a/soc/mediatek/mt8196/README.md +++ b/soc/mediatek/mt8196/README.md @@ -8,6 +8,7 @@ - gpueb_fw.img - pi_img.img - mtk_fsp_romstage.elf +- mtk_fsp_ramstage.elf -------------------------------------------------------------------------------- # MCUPM introduction @@ -257,3 +258,27 @@ `$ strings mtk_fsp_romstage.elf | grep "interface version"` -------------------------------------------------------------------------------- +# mtk_fsp_ramstage.elf introduction +It is a new blob named MediaTek firmware support package (mtk-fsp) in ramstage that includes: + +- UFS mphy settings. +- DPAC (Device Access Permission Control) settings. +- MMinfra (Multimedia Infrastrucutre) settings. +- SMPU (Security Memory Protection Unit) settings. +- Advanced CPU frequency control. + +## Who uses it +Coreboot loads `mtk_fsp_ramstage.elf` during the first bootup. + +## How to load `mtk_fsp_ramstage.elf` +Coreboot locates `mtk_fsp_ramstage.elf` file, locates the entry point `_start()`, +passes a `mtk_fsp_param` struct argument 'param_type', 'param_szie' and 'param' +to it, and calls _start() to execute 'mtk_fsp_ramstage.elf' + +## Return values +0 on success; non-zero on failure. + +## Version +`$ strings mtk_fsp_ramstage.elf | grep "interface version"` + +-------------------------------------------------------------------------------- diff --git a/soc/mediatek/mt8196/mtk_fsp_ramstage.elf b/soc/mediatek/mt8196/mtk_fsp_ramstage.elf new file mode 100644 index 0000000..783eb66 --- /dev/null +++ b/soc/mediatek/mt8196/mtk_fsp_ramstage.elf Binary files differ diff --git a/soc/mediatek/mt8196/mtk_fsp_ramstage.elf.md5 b/soc/mediatek/mt8196/mtk_fsp_ramstage.elf.md5 new file mode 100644 index 0000000..3e6085f --- /dev/null +++ b/soc/mediatek/mt8196/mtk_fsp_ramstage.elf.md5 @@ -0,0 +1 @@ +3b4068efe7b6c5aebc2379985c5316e4 *mtk_fsp_ramstage.elf diff --git a/soc/mediatek/mt8196/mtk_fsp_ramstage_release_notes.txt b/soc/mediatek/mt8196/mtk_fsp_ramstage_release_notes.txt new file mode 100644 index 0000000..d546d0d --- /dev/null +++ b/soc/mediatek/mt8196/mtk_fsp_ramstage_release_notes.txt @@ -0,0 +1,7 @@ +# 1.0 + +1. An official build from ChromeOS version 16180.0.0. + +2. Included changes: + +- CL:*7980493 mt8196/kraken_v3: Fix incorrect use of %p -- To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Gerrit-Change-Number: 86253 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
by jason-ch chen (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Yidi Lin, Yu-Ping Wu. jason-ch chen has posted comments on this change by jason-ch chen. ( https://review.coreboot.org/c/blobs/+/86248?usp=email ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Please also update the release note file. done -- To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Gerrit-Change-Number: 86248 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 09:13:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
by jason-ch chen (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Yu-Ping Wu, jason-ch chen. Hello Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/86248?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 ...................................................................... soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 - Fix error handler for infra timeout in SSPM. The error handler for infra timeout in SSPM was not handled properly, causing the ISR to get stuck. As a result, tasks without ISR would not continue to operate. - Enable SSPM debug configs BUG=b:360756645, b:374015969 TEST=get "MediaTek SSPM firmware: version 2.0.2" by strings sspm.bin | grep version Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Signed-off-by: jason-ch chen <jason-ch.chen(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8186/sspm.bin M soc/mediatek/mt8186/sspm.bin.md5 M soc/mediatek/mt8186/sspm_release_notes.txt 3 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/48/86248/2 -- To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Gerrit-Change-Number: 86248 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: acpi: Zero-out MADT before filling it
by Patrick Rudolph (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Cliff Huang, Lance Zhao, Tim Wawrzynczak, Vladimir Serbinenko. Patrick Rudolph has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/86246?usp=email ) Change subject: acpi: Zero-out MADT before filling it ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86246?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie5dc0720183b8ba07561341003f28a86ffce911e Gerrit-Change-Number: 86246 Gerrit-PatchSet: 3 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 09:03:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: add TF-A static library path
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Gavin Liu, Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email ) Change subject: soc/mediatek/mt8196: add TF-A static library path ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86252/comment/c1ecd1e5_89c094be?us… : PS1, Line 7: add Add https://review.coreboot.org/c/coreboot/+/86252/comment/84025526_30653459?us… : PS1, Line 9: Add TF-A static library path to build argument. BL31 build argument. -- To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Gerrit-Change-Number: 86252 Gerrit-PatchSet: 1 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 08:59:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Jarried Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Kenji Yu, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/blobs/+/86251/comment/bb94f9f8_0561d0e8?usp=e… : PS5, Line 9: 1. > remove Done -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 6 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 08:19:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Kenji Yu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Kenji Yu, Yu-Ping Wu. Hello Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/86251?usp=email to look at the new patch set (#6). Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v3.0 Update sspm.bin to disable waking up SPM function. TEST=Build pass BUG=b:387181201, b:385829129 Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/51/86251/6 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 6 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: add TF-A static library path
by Gavin Liu (Code Review) 03 Feb '25

03 Feb '25

Gavin Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email ) Change subject: soc/mediatek/mt8196: add TF-A static library path ...................................................................... soc/mediatek/mt8196: add TF-A static library path Add TF-A static library path to build argument. BUG=b:317009620 TEST=Build pass with and without static library. boot ok. Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Signed-off-by: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86252/1 diff --git a/src/soc/mediatek/mt8196/Makefile.mk b/src/soc/mediatek/mt8196/Makefile.mk index d780ebd..0bcd81f 100644 --- a/src/soc/mediatek/mt8196/Makefile.mk +++ b/src/soc/mediatek/mt8196/Makefile.mk @@ -93,6 +93,12 @@ MT8196_BLOB_DIR := 3rdparty/blobs/soc/mediatek/mt8196 +MTKLIB_PATH := $(top)/$(MT8196_BLOB_DIR)/libmtk.a + +ifneq ($(wildcard $(MTKLIB_PATH)),) +BL31_MAKEARGS += MTKLIB_PATH=$(MTKLIB_PATH) +endif + mcu-firmware-files := \ $(CONFIG_DPM_DM_FIRMWARE) \ $(CONFIG_DPM_PM_FIRMWARE) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Gerrit-Change-Number: 86252 Gerrit-PatchSet: 1 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Yu-Ping Wu, jason-ch chen. Yidi Lin has posted comments on this change by jason-ch chen. ( https://review.coreboot.org/c/blobs/+/86248?usp=email ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please also update the release note file. -- To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Gerrit-Change-Number: 86248 Gerrit-PatchSet: 1 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 08:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025