coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in blobs[main]: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: jason-ch chen. Yidi Lin has posted comments on this change by jason-ch chen. ( https://review.coreboot.org/c/blobs/+/86248?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/blobs/+/86248/comment/79a5e008_5d4cdb79?usp=e… : PS2, Line 14: BRANCH=corsola -- To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Gerrit-Change-Number: 86248 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 13:32:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Kenji Yu. Yidi Lin has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/blobs/+/86251/comment/b64c537a_f2e1b8b0?usp=e… : PS6, Line 11: TEST=Build pass BRANCH=rauru -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 6 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 13:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86253?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/blobs/+/86253/comment/639756e7_17e6fe39?usp=e… : PS2, Line 15: BRANCH=rauru -- To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Gerrit-Change-Number: 86253 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 13:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86253?usp=email ) Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Gerrit-Change-Number: 86253 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 13:30:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add TF-A static library path
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Gavin Liu, Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email ) Change subject: soc/mediatek/mt8196: Add TF-A static library path ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86252/comment/c26057f9_ceb0945f?us… : PS1, Line 96: libmtk.a > We have already pushed the corresponding tf-a patch. If we change the naming, it maybe affect tf-a. […] We only need `lib` prefix. We can rename it to `libbl31.a` or `libtf-a.a` ? -- To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Gerrit-Change-Number: 86252 Gerrit-PatchSet: 2 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 13:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: intel/acpi: Put BSP as the first entry
by Vladimir Serbinenko (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Patrick Rudolph. Vladimir Serbinenko has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/86247?usp=email ) Change subject: intel/acpi: Put BSP as the first entry ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/common/block/acpi/cpu_hybrid.c: https://review.coreboot.org/c/coreboot/+/86247/comment/021af1cf_db3a3524?us… : PS3, Line 40: The > The comment is no longer true as the BSP/first entry might be an efficient core. […] Changed the comment and changed the code that relied on it -- To view, visit https://review.coreboot.org/c/coreboot/+/86247?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I520a2e080c9f07a5866729ae2283990d20c0d691 Gerrit-Change-Number: 86247 Gerrit-PatchSet: 4 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 13:26:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

[S] Change in coreboot[main]: intel/acpi: Put BSP as the first entry
by Vladimir Serbinenko (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Vladimir Serbinenko. Hello Intel coreboot Reviewers, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86247?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: intel/acpi: Put BSP as the first entry ...................................................................... intel/acpi: Put BSP as the first entry Linux complains in dmesg as a firmware bug that BSP is not the first entry. NetBSD hangs and OpenBSD panics early on boot. With this patch I was able to boot NetBSD and OpenBSD on darp10-b when loaded in GRUB. Note: vanilla bootloaders for NetBSD and OpenBSD still result in an apparent hang for an unknown reason. Change-Id: I520a2e080c9f07a5866729ae2283990d20c0d691 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- M src/soc/intel/common/block/acpi/cpu_hybrid.c 1 file changed, 23 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/86247/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/86247?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I520a2e080c9f07a5866729ae2283990d20c0d691 Gerrit-Change-Number: 86247 Gerrit-PatchSet: 4 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add TF-A static library path
by Gavin Liu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Gavin Liu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email ) Change subject: soc/mediatek/mt8196: Add TF-A static library path ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86252/comment/e92cabb0_8a832b87?us… : PS1, Line 7: add > Add Done https://review.coreboot.org/c/coreboot/+/86252/comment/af251f05_763eddff?us… : PS1, Line 9: Add TF-A static library path to build argument. > BL31 build argument. Done File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86252/comment/35d71ff9_942de681?us… : PS1, Line 96: MTKLIB_PATH > `BL31_LIB` Done https://review.coreboot.org/c/coreboot/+/86252/comment/1fbd63ca_66b08608?us… : PS1, Line 96: libmtk.a > We should use more specific file name in the blobs repo. How about `bl31_lib. […] We have already pushed the corresponding tf-a patch. If we change the naming, it maybe affect tf-a. The naming is reference other platform in coreboot. -- To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Gerrit-Change-Number: 86252 Gerrit-PatchSet: 2 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 13:10:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add TF-A static library path
by Gavin Liu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Gavin Liu, Hung-Te Lin. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86252?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8196: Add TF-A static library path ...................................................................... soc/mediatek/mt8196: Add TF-A static library path Add TF-A static library path to BL31 build argument. BUG=b:317009620 TEST=Build pass with and without static library. boot ok. Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Signed-off-by: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86252/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Gerrit-Change-Number: 86252 Gerrit-PatchSet: 2 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86253?usp=email ) Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ...................................................................... Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Gerrit-Change-Number: 86253 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 12:51:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025