coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[M] Change in coreboot[main]: mb/amd/birman_plus/ec: Rectify ECRAM register bits
by Felix Held (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Ana Carolina Cabral. Felix Held has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/86084?usp=email ) Change subject: mb/amd/birman_plus/ec: Rectify ECRAM register bits ...................................................................... Patch Set 14: (1 comment) File src/mainboard/amd/birman_plus/ec.c: https://review.coreboot.org/c/coreboot/+/86084/comment/8029545f_74e423fe?us… : PS13, Line 36: _N > Done no, this should be EC7_WL_RADIO_DIS -- To view, visit https://review.coreboot.org/c/coreboot/+/86084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1a13d99a55a4aa02a5cb0e67ffa4ed555f91a471 Gerrit-Change-Number: 86084 Gerrit-PatchSet: 14 Gerrit-Owner: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 11:24:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
by Jarried Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86253?usp=email ) Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ...................................................................... Patch Set 2: (2 comments) File soc/mediatek/mt8196/README.md: https://review.coreboot.org/c/blobs/+/86253/comment/4fbfaf4d_73aca1ea?usp=e… : PS1, Line 275: param_szie > `param_size` Done File soc/mediatek/mt8196/mtk_fsp_ramstage_release_notes.txt: https://review.coreboot.org/c/blobs/+/86253/comment/a659a768_1a4216e6?usp=e… : PS1, Line 7: - CL:*7980493 mt8196/kraken_v3: Fix incorrect use of %p > Please list all ramstage patches here. Done -- To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Gerrit-Change-Number: 86253 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:52:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
by Jarried Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Jarried Lin, Yidi Lin. Hello Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/86253?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ...................................................................... soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 The initialization of mtk_fsp_ramstage in the ramstage includes: - UFS mphy settings. - DPAC (Device Access Permission Control) settings. - MMinfra (Multimedia Infrastrucutre) settings. - SMPU (Security Memory Protection Unit) settings. - Advanced CPU frequency control. TEST=Build pass BUG=b:373797027 Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/mtk_fsp_ramstage.elf A soc/mediatek/mt8196/mtk_fsp_ramstage.elf.md5 A soc/mediatek/mt8196/mtk_fsp_ramstage_release_notes.txt 4 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/53/86253/2 -- To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Gerrit-Change-Number: 86253 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[L] Change in coreboot[main]: [wip]crossgcc: upgrade binutils version to 2.44
by Elyes Haouas (Code Review) 03 Feb '25

03 Feb '25

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86254?usp=email ) Change subject: [wip]crossgcc: upgrade binutils version to 2.44 ...................................................................... [wip]crossgcc: upgrade binutils version to 2.44 Change-Id: Ic78053f55c59de7af16fca0265d0d23fadfb20f6 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/patches/binutils-2.43.1_as-ipxe.patch D util/crossgcc/patches/binutils-2.43.1_no-makeinfo.patch D util/crossgcc/sum/binutils-2.43.1.tar.xz.cksum A util/crossgcc/sum/binutils-2.44.tar.xz.cksum 5 files changed, 2 insertions(+), 277 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/86254/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 1b0c89a..c10087b 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -40,7 +40,7 @@ MPC_VERSION=1.3.1 GCC_VERSION=14.2.0 LIBSTDCXX_VERSION="${GCC_VERSION}" -BINUTILS_VERSION=2.43.1 +BINUTILS_VERSION=2.44 IASL_VERSION=20241212 # CLANG version number CLANG_VERSION=18.1.8 diff --git a/util/crossgcc/patches/binutils-2.43.1_as-ipxe.patch b/util/crossgcc/patches/binutils-2.43.1_as-ipxe.patch deleted file mode 100644 index fb15cce..0000000 --- a/util/crossgcc/patches/binutils-2.43.1_as-ipxe.patch +++ /dev/null @@ -1,34 +0,0 @@ -From 6984bd861cc595e56d26ea033851d9174e855129 Mon Sep 17 00:00:00 2001 -From: Himanshu Sahdev aka CunningLearner <sahdev.himan(a)gmail.com> -Date: Mon, 26 Aug 2019 16:57:13 +0530 -Subject: [PATCH] as: facilitate tests based on /dev/null - -Signed-off-by: Himanshu Sahdev <himanshusah(a)hcl.com> - ---- - gas/as.c | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - -diff --git a/gas/as.c b/gas/as.c -index 728811bc..78b4802c 100644 ---- a/gas/as.c -+++ b/gas/as.c -@@ -1364,13 +1364,14 @@ main (int argc, char ** argv) - char ** argv_orig = argv; - struct stat sob; - -+ const char *dev_null_file="/dev/null"; - gas_early_init (&argc, &argv); - - /* Call parse_args before gas_init so that switches like - --hash-size can be honored. */ - parse_args (&argc, &argv); - -- if (argc > 1 && stat (out_file_name, &sob) == 0) -+ if (argc > 1 && stat (out_file_name, &sob) == 0 && strcmp(out_file_name,dev_null_file)!=0) - { - int i; - --- -2.17.1 - diff --git a/util/crossgcc/patches/binutils-2.43.1_no-makeinfo.patch b/util/crossgcc/patches/binutils-2.43.1_no-makeinfo.patch deleted file mode 100644 index c43ab0e..0000000 --- a/util/crossgcc/patches/binutils-2.43.1_no-makeinfo.patch +++ /dev/null @@ -1,241 +0,0 @@ -It fails to compile when using "MAKEINFO = @MAKEINFO@": -binutils-gdb/missing: 81: makeinfo: not found -WARNING: 'makeinfo' is missing on your system. - You should only need it if you modified a '.texi' file, or - any other file indirectly affecting the aspect of the manual. - You might want to install the Texinfo package: - <http://www.gnu.org/software/texinfo/> - The spurious makeinfo call might also be the consequence of - using a buggy 'make' (AIX, DU, IRIX), in which case you might - want to install GNU make: - <http://www.gnu.org/software/make/> -make[4]: *** [Makefile:507: as.info] Error 127 -Current patch will change that to "MAKEINFO = true" -diff -ur binutils-2.41.orig/bfd/Makefile.in binutils-2.40/bfd/Makefile.in ---- binutils-2.41.orig/bfd/Makefile.in 2022-08-05 11:53:59.000000000 +0200 -+++ binutils-2.40/bfd/Makefile.in 2022-08-20 05:46:39.960039957 +0200 -@@ -379,7 +379,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ - MSGFMT = @MSGFMT@ -diff -ur binutils-2.41.orig/binutils/Makefile.in binutils-2.40/binutils/Makefile.in ---- binutils-2.41.orig/binutils/Makefile.in 2022-08-05 11:56:21.000000000 +0200 -+++ binutils-2.40/binutils/Makefile.in 2022-08-20 05:46:38.563035937 +0200 -@@ -532,7 +532,7 @@ - LTLIBICONV = @LTLIBICONV@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ - MSGFMT = @MSGFMT@ -diff -ur binutils-2.41.orig/etc/Makefile.in binutils-2.40/etc/Makefile.in ---- binutils-2.41.orig/etc/Makefile.in 2022-07-08 11:46:47.000000000 +0200 -+++ binutils-2.40/etc/Makefile.in 2022-08-20 05:46:38.525035827 +0200 -@@ -154,7 +154,7 @@ - LIBS = @LIBS@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - PACKAGE = @PACKAGE@ - PACKAGE_BUGREPORT = @PACKAGE_BUGREPORT@ -diff -ur binutils-2.41.orig/gas/Makefile.in binutils-2.40/gas/Makefile.in ---- binutils-2.41.orig/gas/Makefile.in 2022-08-05 11:55:17.000000000 +0200 -+++ binutils-2.40/gas/Makefile.in 2022-08-20 05:46:38.535035856 +0200 -@@ -408,7 +408,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ - MSGFMT = @MSGFMT@ -diff -ur binutils-2.41.orig/gold/Makefile.in binutils-2.40/gold/Makefile.in ---- binutils-2.41.orig/gold/Makefile.in 2022-07-08 11:58:08.000000000 +0200 -+++ binutils-2.40/gold/Makefile.in 2022-08-20 05:46:38.522035819 +0200 -@@ -558,7 +558,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MERGE_CONSTANTS_FLAG = @MERGE_CONSTANTS_FLAG@ - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ -diff -ur binutils-2.41.orig/gold/testsuite/Makefile.in binutils-2.40/gold/testsuite/Makefile.in ---- binutils-2.41.orig/gold/testsuite/Makefile.in 2022-07-08 11:58:08.000000000 +0200 -+++ binutils-2.40/gold/testsuite/Makefile.in 2022-08-20 05:46:38.524035824 +0200 -@@ -2644,7 +2644,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MERGE_CONSTANTS_FLAG = @MERGE_CONSTANTS_FLAG@ - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ -diff -ur binutils-2.41.orig/gprof/Makefile.in binutils-2.40/gprof/Makefile.in ---- binutils-2.41.orig/gprof/Makefile.in 2022-08-05 11:59:11.000000000 +0200 -+++ binutils-2.40/gprof/Makefile.in 2022-08-20 05:46:39.964039969 +0200 -@@ -351,7 +351,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ - MSGFMT = @MSGFMT@ -diff -ur binutils-2.41.orig/gprofng/doc/Makefile.in binutils-2.40/gprofng/doc/Makefile.in ---- binutils-2.41.orig/gprofng/doc/Makefile.in 2022-08-05 11:59:31.000000000 +0200 -+++ binutils-2.40/gprofng/doc/Makefile.in 2022-08-20 05:46:39.252037920 +0200 -@@ -271,7 +271,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - NM = @NM@ - NMEDIT = @NMEDIT@ -diff -ur binutils-2.41.orig/gprofng/gp-display-html/Makefile.in binutils-2.40/gprofng/gp-display-html/Makefile.in ---- binutils-2.41.orig/gprofng/gp-display-html/Makefile.in 2022-08-05 11:59:33.000000000 +0200 -+++ binutils-2.40/gprofng/gp-display-html/Makefile.in 2022-08-20 05:46:39.479038573 +0200 -@@ -234,7 +234,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - NM = @NM@ - NMEDIT = @NMEDIT@ -diff -ur binutils-2.41.orig/gprofng/libcollector/Makefile.in binutils-2.40/gprofng/libcollector/Makefile.in ---- binutils-2.41.orig/gprofng/libcollector/Makefile.in 2022-08-05 11:59:38.000000000 +0200 -+++ binutils-2.40/gprofng/libcollector/Makefile.in 2022-08-20 05:46:38.965037094 +0200 -@@ -341,7 +341,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - NM = @NM@ - NMEDIT = @NMEDIT@ -diff -ur binutils-2.41.orig/gprofng/Makefile.in binutils-2.40/gprofng/Makefile.in ---- binutils-2.41.orig/gprofng/Makefile.in 2022-08-05 11:59:30.000000000 +0200 -+++ binutils-2.40/gprofng/Makefile.in 2022-08-20 05:46:38.574035968 +0200 -@@ -289,7 +289,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - NM = @NM@ - NMEDIT = @NMEDIT@ -diff -ur binutils-2.41.orig/gprofng/src/Makefile.in binutils-2.40/gprofng/src/Makefile.in ---- binutils-2.41.orig/gprofng/src/Makefile.in 2022-08-05 11:59:34.000000000 +0200 -+++ binutils-2.40/gprofng/src/Makefile.in 2022-08-20 05:46:38.573035965 +0200 -@@ -358,7 +358,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - NM = @NM@ - NMEDIT = @NMEDIT@ -diff -ur binutils-2.41.orig/ld/Makefile.in binutils-2.40/ld/Makefile.in ---- binutils-2.41.orig/ld/Makefile.in 2022-08-05 11:56:53.000000000 +0200 -+++ binutils-2.40/ld/Makefile.in 2022-08-20 05:46:38.536035859 +0200 -@@ -432,7 +432,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ - MSGFMT = @MSGFMT@ -diff -ur binutils-2.41.orig/libctf/Makefile.in binutils-2.40/libctf/Makefile.in ---- binutils-2.41.orig/libctf/Makefile.in 2022-07-08 12:02:15.000000000 +0200 -+++ binutils-2.40/libctf/Makefile.in 2022-08-20 05:46:39.771039414 +0200 -@@ -425,7 +425,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - NM = @NM@ - NMEDIT = @NMEDIT@ -diff -ur binutils-2.41.orig/libiberty/Makefile.in binutils-2.40/libiberty/Makefile.in ---- binutils-2.41.orig/libiberty/Makefile.in 2022-07-08 11:46:48.000000000 +0200 -+++ binutils-2.40/libiberty/Makefile.in 2022-08-20 05:46:39.961039960 +0200 -@@ -57,7 +57,7 @@ - CFLAGS = @CFLAGS@ - CPPFLAGS = @CPPFLAGS@ - RANLIB = @RANLIB@ @RANLIB_PLUGIN_OPTION@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - PERL = @PERL@ - - PICFLAG = @PICFLAG@ -diff -ur binutils-2.41.orig/Makefile.in binutils-2.40/Makefile.in ---- binutils-2.41.orig/Makefile.in 2022-08-05 13:00:56.000000000 +0200 -+++ binutils-2.40/Makefile.in 2022-08-20 05:46:38.549035896 +0200 -@@ -399,7 +399,7 @@ - FLEX = @FLEX@ - LEX = @LEX@ - M4 = @M4@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - EXPECT = @EXPECT@ - RUNTEST = @RUNTEST@ - -diff -ur binutils-2.41.orig/Makefile.tpl binutils-2.40/Makefile.tpl ---- binutils-2.41.orig/Makefile.tpl 2022-07-08 11:46:47.000000000 +0200 -+++ binutils-2.40/Makefile.tpl 2022-08-20 05:46:38.535035856 +0200 -@@ -402,7 +402,7 @@ - FLEX = @FLEX@ - LEX = @LEX@ - M4 = @M4@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - EXPECT = @EXPECT@ - RUNTEST = @RUNTEST@ - -diff -ur binutils-2.41.orig/opcodes/Makefile.in binutils-2.40/opcodes/Makefile.in ---- binutils-2.41.orig/opcodes/Makefile.in 2022-08-05 11:54:59.000000000 +0200 -+++ binutils-2.40/opcodes/Makefile.in 2022-08-20 05:46:38.522035819 +0200 -@@ -324,7 +324,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - MKINSTALLDIRS = @MKINSTALLDIRS@ - MSGFMT = @MSGFMT@ -diff -ur binutils-2.41.orig/zlib/Makefile.in binutils-2.40/zlib/Makefile.in ---- binutils-2.41.orig/zlib/Makefile.in 2022-07-08 11:56:28.000000000 +0200 -+++ binutils-2.40/zlib/Makefile.in 2022-08-20 05:46:38.571035960 +0200 -@@ -321,7 +321,7 @@ - LN_S = @LN_S@ - LTLIBOBJS = @LTLIBOBJS@ - MAINT = @MAINT@ --MAKEINFO = @MAKEINFO@ -+MAKEINFO = true - MKDIR_P = @MKDIR_P@ - NM = @NM@ - NMEDIT = @NMEDIT@ diff --git a/util/crossgcc/sum/binutils-2.43.1.tar.xz.cksum b/util/crossgcc/sum/binutils-2.43.1.tar.xz.cksum deleted file mode 100644 index 80914b7..0000000 --- a/util/crossgcc/sum/binutils-2.43.1.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -86bfee61d18cb9ea84ca700ecb820d97bb4e92a7 tarballs/binutils-2.43.1.tar.xz diff --git a/util/crossgcc/sum/binutils-2.44.tar.xz.cksum b/util/crossgcc/sum/binutils-2.44.tar.xz.cksum new file mode 100644 index 0000000..fd3669a --- /dev/null +++ b/util/crossgcc/sum/binutils-2.44.tar.xz.cksum @@ -0,0 +1 @@ +c8c9f5ae46ab9e3722c71821982d2c270e267748 tarballs/binutils-2.44.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/86254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic78053f55c59de7af16fca0265d0d23fadfb20f6 Gerrit-Change-Number: 86254 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: jason-ch chen. Yidi Lin has posted comments on this change by jason-ch chen. ( https://review.coreboot.org/c/blobs/+/86248?usp=email ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Gerrit-Change-Number: 86248 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:19:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86253?usp=email ) Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0 ...................................................................... Patch Set 1: (2 comments) File soc/mediatek/mt8196/README.md: https://review.coreboot.org/c/blobs/+/86253/comment/6c61554b_4eb88070?usp=e… : PS1, Line 275: param_szie `param_size` File soc/mediatek/mt8196/mtk_fsp_ramstage_release_notes.txt: https://review.coreboot.org/c/blobs/+/86253/comment/8cc5e82d_705e7425?usp=e… : PS1, Line 7: - CL:*7980493 mt8196/kraken_v3: Fix incorrect use of %p Please list all ramstage patches here. -- To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1 Gerrit-Change-Number: 86253 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Yidi Lin, jason-ch chen. Yu-Ping Wu has posted comments on this change by jason-ch chen. ( https://review.coreboot.org/c/blobs/+/86248?usp=email ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Gerrit-Change-Number: 86248 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Yidi Lin, jason-ch chen. Yu-Ping Wu has posted comments on this change by jason-ch chen. ( https://review.coreboot.org/c/blobs/+/86248?usp=email ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905 Gerrit-Change-Number: 86248 Gerrit-PatchSet: 2 Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:13:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: tests: Add unit tests for CFR
by Jakub "Kuba" Czapiga (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Julius Werner, Patrick Rudolph. Jakub "Kuba" Czapiga has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/78506?usp=email ) Change subject: tests: Add unit tests for CFR ...................................................................... Patch Set 5: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78506/comment/22f28d21_5e56d0b6?us… : PS5, Line 7: tests: Add unit tests for CFR This CL does not only add unit-tests but also the base implementation. I think this commit message should reflect that. :) File src/commonlib/bsd/cfr_parser.c: https://review.coreboot.org/c/coreboot/+/78506/comment/4b3eb92d_d213ca01?us… : PS5, Line 21: case CFR_TAG_OPTION_ENUM: : return sizeof(struct lb_cfr_numeric_option); : case CFR_TAG_OPTION_NUMBER: : return sizeof(struct lb_cfr_numeric_option); : case CFR_TAG_OPTION_BOOL: : return sizeof(struct lb_cfr_numeric_option); Is there a reason for these case statements to be separate? They can look like that: ``` case CFR_TAG_OPTION_ENUM: case CFR_TAG_OPTION_NUMBER: case CFR_TAG_OPTION_BOOL: return sizeof(struct lb_cfr_numeric_option); ``` https://review.coreboot.org/c/coreboot/+/78506/comment/b64f309c_d8684dad?us… : PS5, Line 109: ret = cfr_iterate(&child, callback, priv); How deep can recursion be here? If someone passes a long enough parent->child->child->... chain then it can cause stack overflow. I think this should be limited to a safe value. @jwerner@chromium.org WDYT? https://review.coreboot.org/c/coreboot/+/78506/comment/0b325106_b79d1d52?us… : PS5, Line 144: // FIXME checksum Sorry, but I cannot allow the input parsing code to be submitted w/o checksum checking if there is one. Please implement this feature. -- To view, visit https://review.coreboot.org/c/coreboot/+/78506?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I758b157c97362a01fa89a8ad9d79bb154cbfb2c0 Gerrit-Change-Number: 78506 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: add TF-A static library path
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Gavin Liu, Hung-Te Lin. Yu-Ping Wu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email ) Change subject: soc/mediatek/mt8196: add TF-A static library path ...................................................................... Patch Set 1: (2 comments) File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86252/comment/3e2788f8_e38e407b?us… : PS1, Line 96: MTKLIB_PATH `BL31_LIB` https://review.coreboot.org/c/coreboot/+/86252/comment/13f390e3_22907dc9?us… : PS1, Line 96: libmtk.a We should use more specific file name in the blobs repo. How about `bl31_lib.a`? -- To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Gerrit-Change-Number: 86252 Gerrit-PatchSet: 1 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:12:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025