coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: intel/acpi: Put BSP as the first entry
by Patrick Rudolph (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Vladimir Serbinenko. Patrick Rudolph has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/86247?usp=email ) Change subject: intel/acpi: Put BSP as the first entry ...................................................................... Patch Set 3: (2 comments) File src/soc/intel/common/block/acpi/cpu_hybrid.c: https://review.coreboot.org/c/coreboot/+/86247/comment/f6eec103_491dd148?us… : PS3, Line 40: The The comment is no longer true as the BSP/first entry might be an efficient core. Not sure if that break assumptions made within other OS. https://review.coreboot.org/c/coreboot/+/86247/comment/fd6c9505_66b83f7c?us… : PS3, Line 53: /* While technically correct I wonder how it can happen. It looks like the BSP runs on the efficient core instead of performance core at boot? -- To view, visit https://review.coreboot.org/c/coreboot/+/86247?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I520a2e080c9f07a5866729ae2283990d20c0d691 Gerrit-Change-Number: 86247 Gerrit-PatchSet: 3 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:12:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Yidi Lin (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Kenji Yu. Yidi Lin has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 6 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:10:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Kenji Yu, Yidi Lin. Yu-Ping Wu has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... Patch Set 6: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 6 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v3.0
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Kenji Yu, Yidi Lin. Yu-Ping Wu has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0 ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3 Gerrit-Change-Number: 86251 Gerrit-PatchSet: 6 Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:07:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek: Utilize REGION() and REGION_END() macros
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Yu-Ping Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86116?usp=email ) Change subject: soc/mediatek: Utilize REGION() and REGION_END() macros ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86116?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad5a129a558e8902fbfd4adb9c34d9d5e5cba25f Gerrit-Change-Number: 86116 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: symbols: Add REGION() and REGION_END() macros
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Yu-Ping Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86115?usp=email ) Change subject: symbols: Add REGION() and REGION_END() macros ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86115?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80275a74a4015e72eaab204982b915e4435a339 Gerrit-Change-Number: 86115 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: symbols: Add REGION() and REGION_END() macros
by Yu-Ping Wu (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Julius Werner. Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86115?usp=email ) Change subject: symbols: Add REGION() and REGION_END() macros ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hmm... does it? I think it would just make them follow the macro definition to the source but that doesn't really help either. On seeing `_sram`, inexperienced people would try to search for that word in the code base and found nothing. On seeing `REGION(sram)` and the definition of those macros, IMO it would be easier to figure out what to grep. > For symbols prefixed with underscores I think there at least exists a lot of precedent among various C code bases to represent linker script symbols that way. Okay, I didn't know that. If that's the case and you don't think this patch improves anything, I'm going to abandon this. -- To view, visit https://review.coreboot.org/c/coreboot/+/86115?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80275a74a4015e72eaab204982b915e4435a339 Gerrit-Change-Number: 86115 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Feb 2025 10:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoga and pujjogatwin: Modify WWAN EM060 power ...
by Subrata Banik (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Luca Lai, Nick Vaccaro. Subrata Banik has posted comments on this change by Luca Lai. ( https://review.coreboot.org/c/coreboot/+/86249?usp=email ) Change subject: mb/google/nissa/var/pujjoga and pujjogatwin: Modify WWAN EM060 power on sequence ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4e7acf41da004d990529f9ddb0fc5a32ba03b3b Gerrit-Change-Number: 86249 Gerrit-PatchSet: 2 Gerrit-Owner: Luca Lai <luca.lai(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Luca Lai <luca.lai(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 09:58:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/trulo/var/uldrenite: Add fw_config probe for touchscreen
by Subrata Banik (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro. Subrata Banik has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86144?usp=email ) Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for touchscreen ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I63512e85052bce974ffb0b738164bea440bd413c Gerrit-Change-Number: 86144 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Feb 2025 09:57:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER
by Elyes Haouas (Code Review) 03 Feb '25

03 Feb '25

Attention is currently required from: Sergii Dmytruk. Elyes Haouas has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/67065?usp=email ) Change subject: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER ...................................................................... Patch Set 43: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67065/comment/3a3484e8_ad49fdd9?us… : PS43, Line 17: will be done in a follow-up change Is it still active? -- To view, visit https://review.coreboot.org/c/coreboot/+/67065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id88baef5ecb1f8ffd74a7f464bbbaaaea0ca643d Gerrit-Change-Number: 67065 Gerrit-PatchSet: 43 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Feb 2025 09:34:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025