coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: drivers/intel/i210/Makefile.inc: Remove a link path to itself
by Elyes Haouas (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70468 ) Change subject: drivers/intel/i210/Makefile.inc: Remove a link path to itself ...................................................................... Patch Set 13: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70468/comment/51a6ef3e_c88dc903 PS11, Line 7: link path to itself > I didn't find better. […] Ack File src/drivers/intel/i210/Makefile.inc: https://review.coreboot.org/c/coreboot/+/70468/comment/7e2e255d_7d67a378 PS13, Line 6: CFLAGS_x86_32 += -Isrc/drivers/intel/i210 > Hmmm, tried this? […] yes for sure! build/auto.conf:1558:notice: override: reassigning to symbol LAPIC_ACCESS_MODE MAKE building with libflashrom support Package flashrom was not found in the pkg-config search path. Perhaps you should add the directory containing `flashrom.pc' to the PKG_CONFIG_PATH environment variable Package 'flashrom', required by 'virtual:world', not found vboot SHA256 built with tight loops (slower, smaller code size) CC firmware/2lib/2api.o cc1: error: src/drivers/intel/i210: No such file or directory [-Werror=missing-include-dirs] cc1: error: src/vendorcode/siemens/hwilib: No such file or directory [-Werror=missing-include-dirs] cc1: error: firmware/lib/cryptolib/include: No such file or directory [-Werror=missing-include-dirs] cc1: error: firmware/lib20/include: No such file or directory [-Werror=missing-include-dirs] cc1: all warnings being treated as errors -- To view, visit https://review.coreboot.org/c/coreboot/+/70468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94b0f99353ed3a582ea590cbc6b12dec6294c75d Gerrit-Change-Number: 70468 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 22:42:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/baytrail: add _HRV to GPIO ACPI devices
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71200 ) Change subject: soc/intel/baytrail: add _HRV to GPIO ACPI devices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa6e1b3f68537e012e4a58175d5334a8aa2f4178 Gerrit-Change-Number: 71200 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:45:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/baytrail: add _HRV to I2C ACPI devices
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71199 ) Change subject: soc/intel/baytrail: add _HRV to I2C ACPI devices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I590acd1f1b75f6bf2bf278e67eec1dcc24bcc15d Gerrit-Change-Number: 71199 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:45:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/samus: Set hidden flag for RT5677AA ACPI device
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71198 ) Change subject: mb/google/samus: Set hidden flag for RT5677AA ACPI device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2eb4b3aeed50b9f3ee9f73a57d6585068aa31fbb Gerrit-Change-Number: 71198 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:45:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/slippy/peppy: Set cypress TP IRQ to Level vs Edge
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71197 ) Change subject: mb/google/slippy/peppy: Set cypress TP IRQ to Level vs Edge ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecf6cb919bf16ec9180ca050e7eafe55247337ed Gerrit-Change-Number: 71197 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:45:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/drallion: Use runtime detection for touchscreens
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71193 ) Change subject: mb/google/drallion: Use runtime detection for touchscreens ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67c3d1fc3d34e9b67ddb26afcaad3a47ffa92e2f Gerrit-Change-Number: 71193 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:44:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/drallion: Set touchpad/screen IRQs to LEVEL vs EDGE
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71192 ) Change subject: mb/google/drallion: Set touchpad/screen IRQs to LEVEL vs EDGE ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1bdbf017bc7480f59cec85c70d6e71dac294dcd2 Gerrit-Change-Number: 71192 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:44:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/drallion: Implement touchscreen power sequencing
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71191 ) Change subject: mb/google/drallion: Implement touchscreen power sequencing ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6825345f35a7415020e77edf781139f0c9b5f875 Gerrit-Change-Number: 71191 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/drallion: Add method to set GPIOs in romstage
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71190 ) Change subject: mb/google/drallion: Add method to set GPIOs in romstage ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ad0c18a8b61e59a943a453882bf74762bac4700 Gerrit-Change-Number: 71190 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:43:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Define a more suitable MRC training text message
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Anil Kumar K, Tarun Tuli, Jérémy Compostella, Paul Menzel, Nick Vaccaro. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70796 ) Change subject: mb/google/brya: Define a more suitable MRC training text message ...................................................................... Patch Set 26: Code-Review+1 (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/70796/comment/e68a546c_7a880d39 PS23, Line 335: config MEMORY_TRAINING_TEXT > The second line needs to get centered, not aligned with the left of the first line […] Might be better to handle this in C code as an array of strings. One would center and print each line individually. -- To view, visit https://review.coreboot.org/c/coreboot/+/70796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie71cd86746427789b3694d41224bf2c170af0f91 Gerrit-Change-Number: 70796 Gerrit-PatchSet: 26 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:43:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023