coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: soc/intel/alderlake: Move ME spec structure to its header file
by Subrata Banik (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71625 ) Change subject: soc/intel/alderlake: Move ME spec structure to its header file ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: good job @Dinesh -- To view, visit https://review.coreboot.org/c/coreboot/+/71625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic14305b0479a8c57531d9930946eded7ac518b09 Gerrit-Change-Number: 71625 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Mon, 02 Jan 2023 09:17:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/alderlake: Move ME spec structure to its header file
by Dinesh Gehlot (Code Review) 02 Jan '23

02 Jan '23

Dinesh Gehlot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71625 ) Change subject: soc/intel/alderlake: Move ME spec structure to its header file ...................................................................... soc/intel/alderlake: Move ME spec structure to its header file This patch moves ME host firmware status register structure to ME header file. It also marks unused structure fields to reserved. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ic14305b0479a8c57531d9930946eded7ac518b09 --- M src/soc/intel/alderlake/include/soc/me.h M src/soc/intel/alderlake/me.c 2 files changed, 77 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/71625/1 diff --git a/src/soc/intel/alderlake/include/soc/me.h b/src/soc/intel/alderlake/include/soc/me.h index e094af6..f029991 100644 --- a/src/soc/intel/alderlake/include/soc/me.h +++ b/src/soc/intel/alderlake/include/soc/me.h @@ -3,41 +3,79 @@ #ifndef _ALDERLAKE_ME_H_ #define _ALDERLAKE_ME_H_ -#include <stdint.h> - /* ME Host Firmware Status register 1 */ union me_hfsts1 { - u32 data; + uint32_t data; struct { - u32 working_state: 4; - u32 mfg_mode: 1; - u32 fpt_bad: 1; - u32 operation_state: 3; - u32 fw_init_complete: 1; - u32 ft_bup_ld_flr: 1; - u32 update_in_progress: 1; - u32 error_code: 4; - u32 operation_mode: 4; - u32 reset_count: 4; - u32 boot_options_present: 1; - u32 invoke_enhance_dbg_mode: 1; - u32 bist_test_state: 1; - u32 bist_reset_request: 1; - u32 current_power_source: 2; - u32 reserved: 1; - u32 d0i3_support_valid: 1; + uint32_t working_state : 4; + uint32_t mfg_mode : 1; + uint32_t fpt_bad : 1; + uint32_t operation_state : 3; + uint32_t fw_init_complete : 1; + uint32_t ft_bup_ld_flr : 1; + uint32_t update_in_progress : 1; + uint32_t error_code : 4; + uint32_t operation_mode : 4; + uint32_t reserved_0 : 4; + uint32_t boot_options_present : 1; + uint32_t invoke_enhance_dbg_mode: 1; + uint32_t reserved_1 : 5; + uint32_t d0i3_support_valid : 1; + } __packed fields; +}; + +/* Host Firmware Status Register 2 */ +union me_hfsts2 { + uint32_t data; + struct { + uint32_t reserved_0 : 4; + uint32_t cpu_replaced : 1; + uint32_t reserved_1 : 3; + uint32_t cpu_replaced_valid : 1; + uint32_t low_power_state : 1; + uint32_t reserved_2 : 22; } __packed fields; }; /* ME Host Firmware Status Register 3 */ union me_hfsts3 { - u32 data; + uint32_t data; struct { - u32 reserved_0: 4; - u32 fw_sku: 3; - u32 reserved_7_10: 4; - u32 rpmc_status: 3; - u32 resered_14_31: 18; + uint32_t reserved_0 : 4; + uint32_t fw_sku : 3; + uint32_t reserved_1 : 25; } __packed fields; }; + + +/* Host Firmware Status Register 4 */ +union me_hfsts4 { + uint32_t data; + struct { + uint32_t rsvd0; + } __packed fields; +}; + +/* Host Firmware Status Register 5 */ +union me_hfsts5 { + uint32_t data; + struct { + uint32_t rsvd0; + } __packed fields; +}; + +/* Host Firmware Status Register 6 */ +union me_hfsts6 { + u32 data; + struct { + uint32_t reserved_0 : 1; + uint32_t cpu_debug_disable : 1; + uint32_t reserved_1 : 19; + uint32_t manuf_lock : 1; + uint32_t reserved_2 : 8; + uint32_t fpf_soc_lock : 1; + uint32_t txt_support : 1; + } __packed fields; +}; + #endif /* _ALDERLAKE_ME_H_ */ diff --git a/src/soc/intel/alderlake/me.c b/src/soc/intel/alderlake/me.c index 8b5e94f..6239eb2 100644 --- a/src/soc/intel/alderlake/me.c +++ b/src/soc/intel/alderlake/me.c @@ -6,87 +6,6 @@ #include <soc/me.h> #include <stdint.h> -/* Host Firmware Status Register 2 */ -union me_hfsts2 { - uint32_t data; - struct { - uint32_t nftp_load_failure : 1; - uint32_t icc_prog_status : 2; - uint32_t invoke_mebx : 1; - uint32_t cpu_replaced : 1; - uint32_t rsvd0 : 1; - uint32_t mfs_failure : 1; - uint32_t warm_reset_rqst : 1; - uint32_t cpu_replaced_valid : 1; - uint32_t low_power_state : 1; - uint32_t me_power_gate : 1; - uint32_t ipu_needed : 1; - uint32_t forced_safe_boot : 1; - uint32_t rsvd1 : 1; - uint32_t cse_to_be_disabled : 1; - uint32_t listener_change : 1; - uint32_t status_data : 8; - uint32_t current_pmevent : 4; - uint32_t phase : 4; - } __packed fields; -}; - -/* Host Firmware Status Register 4 */ -union me_hfsts4 { - uint32_t data; - struct { - uint32_t rsvd0 : 9; - uint32_t enforcement_flow : 1; - uint32_t sx_resume_type : 1; - uint32_t rsvd1 : 1; - uint32_t tpms_disconnected : 1; - uint32_t rvsd2 : 1; - uint32_t fwsts_valid : 1; - uint32_t boot_guard_self_test : 1; - uint32_t rsvd3 : 16; - } __packed fields; -}; - -/* Host Firmware Status Register 5 */ -union me_hfsts5 { - uint32_t data; - struct { - uint32_t acm_active : 1; - uint32_t valid : 1; - uint32_t result_code_source : 1; - uint32_t error_status_code : 5; - uint32_t acm_done_sts : 1; - uint32_t timeout_count : 7; - uint32_t scrtm_indicator : 1; - uint32_t rsvd0 : 14; - uint32_t start_enforcement : 1; - } __packed fields; -}; - -/* Host Firmware Status Register 6 */ -union me_hfsts6 { - uint32_t data; - struct { - uint32_t force_boot_guard_acm : 1; - uint32_t cpu_debug_disable : 1; - uint32_t bsp_init_disable : 1; - uint32_t protect_bios_env : 1; - uint32_t rsvd0 : 2; - uint32_t error_enforce_policy : 2; - uint32_t measured_boot : 1; - uint32_t verified_boot : 1; - uint32_t rsvd1 : 11; - uint32_t manuf_lock : 1; - uint32_t key_manifest_id : 4; - uint32_t boot_policy_status : 1; - uint32_t error : 1; - uint32_t boot_guard_disable : 1; - uint32_t fpf_disable : 1; - uint32_t fpf_soc_lock : 1; - uint32_t txt_support : 1; - } __packed fields; -}; - static bool is_manuf_mode(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6) { /* -- To view, visit https://review.coreboot.org/c/coreboot/+/71625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic14305b0479a8c57531d9930946eded7ac518b09 Gerrit-Change-Number: 71625 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/common/block/smbus/Kconfig: Drop unused ACPI driver Kconfig...
by Elyes Haouas (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Martin L Roth, Paul Menzel, Michael Niewöhner. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69331 ) Change subject: soc/intel/common/block/smbus/Kconfig: Drop unused ACPI driver Kconfig symbol ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Can we make some progress? -- To view, visit https://review.coreboot.org/c/coreboot/+/69331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic46e1663609068439069f666beca17ed76c679f0 Gerrit-Change-Number: 69331 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 07:39:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode
by Elyes Haouas (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Lance Zhao, Nico Huber, David Hendricks, Tim Wawrzynczak, Eric Lai, Elyes Haouas. Hello Lance Zhao, build bot (Jenkins), Nico Huber, Jonathan Zhang, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68593 to look at the new patch set (#4). Change subject: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode ...................................................................... acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode Change-Id: I222478572a9e5efadd6719a164558833298e4c99 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/Kconfig M src/vendorcode/Makefile.inc A src/vendorcode/facebook/Kconfig 3 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/68593/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/68593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99 Gerrit-Change-Number: 68593 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode
by Elyes Haouas (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Lance Zhao, Nico Huber, David Hendricks, Tim Wawrzynczak, Eric Lai, Elyes Haouas. Hello Lance Zhao, build bot (Jenkins), Nico Huber, Jonathan Zhang, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68593 to look at the new patch set (#3). Change subject: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode ...................................................................... acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode Change-Id: I222478572a9e5efadd6719a164558833298e4c99 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/Kconfig M src/vendorcode/Makefile.inc A src/vendorcode/facebook/Kconfig 3 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/68593/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99 Gerrit-Change-Number: 68593 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: Add minimal GNAT run time system (RTS)
by Elyes Haouas (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Nico Huber. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11836 ) Change subject: Add minimal GNAT run time system (RTS) ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: > I got this error: "interfac. […] any update on current topic? -- To view, visit https://review.coreboot.org/c/coreboot/+/11836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6522abf093f0a516b9ae18ddc69131bd721dc0c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Adrian-Ken Rueegsegger <ken(a)codelabs.ch> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Reto Buerki <reet(a)codelabs.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 07:18:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2022.10"
by build bot (Jenkins) (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Martin L Roth, Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71065 ) Change subject: payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2022.10" ...................................................................... Patch Set 3: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167494): https://review.coreboot.org/c/coreboot/+/71065/comment/99496e95_0bf3a140 PS3, Line 9: U-Boot v2022.10 was released on Mon 03 October 2022: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/71065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24 Gerrit-Change-Number: 71065 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Jan 2023 07:00:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2022.10"
by Elyes Haouas (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Martin L Roth, Stefan Reinauer. Hello build bot (Jenkins), Martin L Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71065 to look at the new patch set (#3). Change subject: payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2022.10" ...................................................................... payloads/U-Boot: Upgrade from U-Boot "v2021.07" to "v2022.10" U-Boot v2022.10 was released on Mon 03 October 2022: https://source.denx.de/u-boot/u-boot/-/blob/master/doc/develop/release_cycl… Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M payloads/external/U-Boot/Kconfig 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/71065/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1c6f83bd12e959c29fad1b121c85eb0cf898e24 Gerrit-Change-Number: 71065 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Remove USB2_8 Connection
by Subrata Banik (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71237 ) Change subject: mb/google/rex: Remove USB2_8 Connection ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > we shall land this with proto 1 cls. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/71237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f03d600acd8ceaa5a5630fc19c1c7e34a4ea28f Gerrit-Change-Number: 71237 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Mon, 02 Jan 2023 06:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Revise config for the Proto 1 build
by Subrata Banik (Code Review) 02 Jan '23

02 Jan '23

Attention is currently required from: Tarun Tuli, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70867 ) Change subject: mb/google/rex: Revise config for the Proto 1 build ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > We will hold this CL till 1st of Jan (before dropping Proto 0 support) Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/70867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f04c644b8a392feb2609f906bc9db945bf5fce2 Gerrit-Change-Number: 70867 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Jan 2023 06:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023