coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: nb/intel/i440bx: Specify supported memory type
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70575 ) Change subject: nb/intel/i440bx: Specify supported memory type ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If94037f2b010527440795e6920dd7a533c52f606 Gerrit-Change-Number: 70575 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:48:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/e7505: Specify supported memory type
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70574 ) Change subject: nb/intel/e7505: Specify supported memory type ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70574 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idda0a8330463205efe5ec5faa82a1f458894e521 Gerrit-Change-Number: 70574 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:48:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: intel/ironlake: Specify supported memory type
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71584 ) Change subject: intel/ironlake: Specify supported memory type ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71584/comment/fa3161f6_9ce74fbe PS1, Line 7: intel/ironlake: Specify supported memory type `nb/intel/ironlake` File src/northbridge/intel/ironlake/Kconfig: https://review.coreboot.org/c/coreboot/+/71584/comment/38e10633_e863c7b9 PS1, Line 6: if NORTHBRIDGE_INTEL_IRONLAKE : : config NORTHBRIDGE_SPECIFIC_OPTIONS : def_bool y Seems unrelated -- To view, visit https://review.coreboot.org/c/coreboot/+/71584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1bf132f248d1f3c42d32f884f09687964a0c6f2 Gerrit-Change-Number: 71584 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:48:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/haswell: Specify supported memory type
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71583 ) Change subject: nb/intel/haswell: Specify supported memory type ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/haswell/Kconfig: https://review.coreboot.org/c/coreboot/+/71583/comment/bb67531a_48ebd3e2 PS2, Line 18: select USE_DDR4 Haswell does *not* support DDR4. The server platforms do, but they're a completely different beast (not supported in coreboot yet). -- To view, visit https://review.coreboot.org/c/coreboot/+/71583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I885cc00c8bfcfaaabb2ce2b0269172d8d7a88db5 Gerrit-Change-Number: 71583 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:48:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/haswell: Specify supported memory type
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71583 ) Change subject: nb/intel/haswell: Specify supported memory type ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/haswell/Kconfig: https://review.coreboot.org/c/coreboot/+/71583/comment/303e42cb_e58a494a PS2, Line 6: if NORTHBRIDGE_INTEL_HASWELL : : config NORTHBRIDGE_SPECIFIC_OPTIONS : def_bool y Seems to be unrelated -- To view, visit https://review.coreboot.org/c/coreboot/+/71583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I885cc00c8bfcfaaabb2ce2b0269172d8d7a88db5 Gerrit-Change-Number: 71583 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Docs/releases: Update 4.17 & 4.18 notes to remove RESOURCE_ALLOCATOR_V3
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Jason Glenesk, Martin L Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71581 ) Change subject: Docs/releases: Update 4.17 & 4.18 notes to remove RESOURCE_ALLOCATOR_V3 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File Documentation/releases/coreboot-4.17-relnotes.md: https://review.coreboot.org/c/coreboot/+/71581/comment/79c4b145_a7b5c42f PS1, Line 302: V4 Hmmm, some paragraphs spell `V3` and `V4` in uppercase, whereas others spell `v3` and `v4` in lowercase. It'd be nice to make it consistent. -- To view, visit https://review.coreboot.org/c/coreboot/+/71581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35607a86242c37e1578874b3a79ff0387a55b146 Gerrit-Change-Number: 71581 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 15:57:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/releases: Start getting ready for the 4.19 release
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Felix Singer, Jason Glenesk, Martin L Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71590 ) Change subject: Documentation/releases: Start getting ready for the 4.19 release ...................................................................... Patch Set 1: Code-Review+1 (7 comments) File Documentation/releases/coreboot-4.19-relnotes.md: https://review.coreboot.org/c/coreboot/+/71590/comment/84382603_c063b93d PS1, Line 13: relevent typo: relev*a*nt https://review.coreboot.org/c/coreboot/+/71590/comment/84999c3b_d42392bc PS1, Line 42: optoins typo: options https://review.coreboot.org/c/coreboot/+/71590/comment/d2e1cccc_0079cde6 PS1, Line 46: nit: remove one space https://review.coreboot.org/c/coreboot/+/71590/comment/c26a9c26_aafd8033 PS1, Line 64: * AMD: Mayan for Morgana SoC : * GIGABYTE: GA-H61M-DS2 : * Google: Crystaldrift : * Google: Gladios : * Google: Marasov : * Google: Voltorb : * Intel: Meteorlake-P RVP : * Siemens: MC_EHL3 : * Star Labs: StarBook Mk VI (i3-1220P and i7-1260P) : * System76: darp8 : * System76: galp6 nit: Please be consistent with the spacing after the colon: some lines have one space, whereas others have two. https://review.coreboot.org/c/coreboot/+/71590/comment/5af84833_a58bf6ff PS1, Line 114: * src/soc/intel/xeon_sp/lbg This isn't a new platform, it's just a result of restructuring the code as part of CB:70009. It'd be better to drop it. https://review.coreboot.org/c/coreboot/+/71590/comment/d8655c73_da253576 PS1, Line 110: New SoCs : ------------------- : : * src/soc/amd/glinda : * src/soc/intel/xeon_sp/lbg : : : Removed processors : ------------------- : : * src/cpu/amd/agesa/family14 : * src/cpu/amd/agesa/family15tn : * src/cpu/amd/agesa/family16kb nit: drop the `src/` prefix? https://review.coreboot.org/c/coreboot/+/71590/comment/c9656524_e3435097 PS1, Line 124: Also list dropped northbridges/southbridges? -- To view, visit https://review.coreboot.org/c/coreboot/+/71590 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3edbf3ebc74ebae5896196b43dd5be014f27a0ec Gerrit-Change-Number: 71590 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 15:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Create markarth variant
by Chao Gui (Code Review) 01 Jan '23

01 Jan '23

Chao Gui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71610 ) Change subject: mb/google/skyrim: Create markarth variant ...................................................................... mb/google/skyrim: Create markarth variant Create the markarth variant of the skyrim reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:262092858 BRANCH=None TEST=util/abuild/abuild -p none -t google/skyrim -x -a make sure the build includes GOOGLE_MARKARTH Change-Id: Ifbace841ca56d8659aaffdc31fb2bc4367d96f82 Signed-off-by: Chao Gui <chaogui(a)google.com> --- M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/skyrim/Kconfig.name A src/mainboard/google/skyrim/variants/markarth/include/variant/ec.h A src/mainboard/google/skyrim/variants/markarth/overridetree.cb 4 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/71610/1 diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index 5eee2d6..493ecb5 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -91,6 +91,7 @@ default "Morthal" if BOARD_GOOGLE_MORTHAL default "Frostflow" if BOARD_GOOGLE_FROSTFLOW default "Crystaldrift" if BOARD_GOOGLE_CRYSTALDRIFT + default "Markarth" if BOARD_GOOGLE_MARKARTH config OVERRIDE_DEVICETREE string @@ -103,6 +104,7 @@ default "morthal" if BOARD_GOOGLE_MORTHAL default "frostflow" if BOARD_GOOGLE_FROSTFLOW default "crystaldrift" if BOARD_GOOGLE_CRYSTALDRIFT + default "markarth" if BOARD_GOOGLE_MARKARTH config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/skyrim/Kconfig.name b/src/mainboard/google/skyrim/Kconfig.name index 23aea48..e7c6505 100644 --- a/src/mainboard/google/skyrim/Kconfig.name +++ b/src/mainboard/google/skyrim/Kconfig.name @@ -26,3 +26,7 @@ config BOARD_GOOGLE_CRYSTALDRIFT bool "-> Crystaldrift" select BOARD_GOOGLE_BASEBOARD_SKYRIM + +config BOARD_GOOGLE_MARKARTH + bool "-> Markarth" + select BOARD_GOOGLE_BASEBOARD_SKYRIM diff --git a/src/mainboard/google/skyrim/variants/markarth/include/variant/ec.h b/src/mainboard/google/skyrim/variants/markarth/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/skyrim/variants/markarth/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/skyrim/variants/markarth/overridetree.cb b/src/mainboard/google/skyrim/variants/markarth/overridetree.cb new file mode 100644 index 0000000..7a56f93 --- /dev/null +++ b/src/mainboard/google/skyrim/variants/markarth/overridetree.cb @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/mendocino + device domain 0 on end +end # chip soc/amd/mendocino -- To view, visit https://review.coreboot.org/c/coreboot/+/71610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbace841ca56d8659aaffdc31fb2bc4367d96f82 Gerrit-Change-Number: 71610 Gerrit-PatchSet: 1 Gerrit-Owner: Chao Gui <chaogui(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/braswell/Makefile.inc: Remove path to non-existent directories
by Elyes Haouas (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71554 ) Change subject: soc/intel/braswell/Makefile.inc: Remove path to non-existent directories ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/braswell/Makefile.inc: https://review.coreboot.org/c/coreboot/+/71554/comment/c4058ce3_e8d82c5a PS2, Line 67: CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARDDIR) > I think that the way is not wrong, however, none of boards (braswell) has a blob directory ... Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I420b60341dfd0119b14e8492722af62e49fceff8 Gerrit-Change-Number: 71554 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 01 Jan 2023 14:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: WIP: mb/hp/t620: Add new board HP T620
by build bot (Jenkins) (Code Review) 01 Jan '23

01 Jan '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71609 ) Change subject: WIP: mb/hp/t620: Add new board HP T620 ...................................................................... Patch Set 1: (7 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167483): https://review.coreboot.org/c/coreboot/+/71609/comment/4e8210d6_03126b1b PS1, Line 11: This work was done during a coreboot hacking party! Board is AMD Fam16kb Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167483): https://review.coreboot.org/c/coreboot/+/71609/comment/780c7e08_c222e1d7 PS1, Line 36: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167483): https://review.coreboot.org/c/coreboot/+/71609/comment/1e7b4ef3_3d862f7a PS1, Line 41: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167483): https://review.coreboot.org/c/coreboot/+/71609/comment/8cf3383d_d1d09ff0 PS1, Line 48: cbfs_master_header 0x0 cbfs header 32 none Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167483): https://review.coreboot.org/c/coreboot/+/71609/comment/fd6d5ab0_743b310f PS1, Line 59: fallback/romstage 0x20e00 stage 386080 none Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167483): https://review.coreboot.org/c/coreboot/+/71609/comment/6ea45b66_0a5784d5 PS1, Line 69: ... Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167483): https://review.coreboot.org/c/coreboot/+/71609/comment/c5040dba_fe1a0107 PS1, Line 80: [DEBUG] smbios_write_tables: 5fe8e000 Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/71609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaa724f393194f762d55263a74b04c9fde93e53f Gerrit-Change-Number: 71609 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Jan 2023 11:16:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023