coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[S] Change in coreboot[master]: mb/starlabs/*: Reserve the alt century byte in CMOS
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69323 ) Change subject: mb/starlabs/*: Reserve the alt century byte in CMOS ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: > Angel said that it should be reserved, but then I think he retracted it? I'll abandon, we've got nee […] Yes, this was out of confusion. Nowadays the usage of the alt-century byte is disabled when using CMOS for options, so there's no conflict. -- To view, visit https://review.coreboot.org/c/coreboot/+/69323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0237772fb2f705065c833dc721184295c75884ea Gerrit-Change-Number: 69323 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake/acpi: Only use SCM for ChromeOS
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Martin L Roth, John Zhao, Tim Wawrzynczak. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64561 ) Change subject: soc/intel/alderlake/acpi: Only use SCM for ChromeOS ...................................................................... Patch Set 7: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac31d37c0873f41f7b14e1051fe214466d1ebdd8 Gerrit-Change-Number: 64561 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/intel/car/romstage: Clear graphics before exiting romstage
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Bora Guvendik, Zhixing Ma, Anil Kumar K, Hannah Williams, Cliff Huang, Tarun Tuli, Nico Huber, Michał Żygowski, Jérémy Compostella, Paul Menzel, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70302 ) Change subject: cpu/intel/car/romstage: Clear graphics before exiting romstage ...................................................................... Patch Set 35: Code-Review+1 (2 comments) File src/cpu/intel/car/romstage.c: https://review.coreboot.org/c/coreboot/+/70302/comment/6358e000_33069cd5 PS22, Line 72: #if CONFIG(SOC_INTEL_COMMON_BLOCK_GRAPHICS) > Thanks. Didn't realize it was a issue of not finding the header, rather than the function itself. […] If you always provide the declaration for `early_graphics_stop()`, you can remove the preprocessor guards. The problem is that the included header is in the `soc/intel/` namespace. As the functionality seems quite generic (one could implement these functions for an Aspeed BMC too, for instance), it would make sense to move the header to `drivers/gfx/early_graphics.h` or similar. File src/cpu/intel/car/romstage.c: https://review.coreboot.org/c/coreboot/+/70302/comment/c90e54d8_9b555939 PS35, Line 14: #if CONFIG(SOC_INTEL_COMMON_BLOCK_GRAPHICS) You should remove this guard to remove the other guards. -- To view, visit https://review.coreboot.org/c/coreboot/+/70302 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31b6470478177938f988afe11febaadd165c4b52 Gerrit-Change-Number: 70302 Gerrit-PatchSet: 35 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:13:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/x86/topology: Add code to fill in topology on struct path
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Shuming Chu (Shuming), Arthur Heymans, Kyösti Mälkki, TangYiwei. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 ) Change subject: cpu/x86/topology: Add code to fill in topology on struct path ...................................................................... Patch Set 15: (2 comments) File src/cpu/x86/topology.c: https://review.coreboot.org/c/coreboot/+/69222/comment/d52c4c48_e854c359 PS15, Line 36: >= > Not sure ">=" is correct here. I suppose it should be "<". This looks wrong indeed. https://review.coreboot.org/c/coreboot/+/69222/comment/355f4437_c9832327 PS15, Line 48: == > Also here. It should be "!=". This seems fine, it skips the SMT level -- To view, visit https://review.coreboot.org/c/coreboot/+/69222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9 Gerrit-Change-Number: 69222 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: TangYiwei Gerrit-Comment-Date: Sun, 01 Jan 2023 18:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: nb/intel/gm45: Wedge DDR2 SPD support in
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Nico Huber, Paul Menzel, Nicholas Chin, Swift Geek (Sebastian Grzywna), Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34826 ) Change subject: nb/intel/gm45: Wedge DDR2 SPD support in ...................................................................... Patch Set 15: (3 comments) File src/northbridge/intel/gm45/raminit.c: https://review.coreboot.org/c/coreboot/+/34826/comment/12a7bdbf_dd4315f1 PS15, Line 232: test_dimm(sysinfo, dimm, 6, 0xff, 0x40 > I think it's assuming that if the data width isn't 64 bits then it's probably 72 bits which would be […] Seems likely, yes https://review.coreboot.org/c/coreboot/+/34826/comment/8c8c6f96_f5e9cf60 PS15, Line 233: !test_dimm(sysinfo, dimm, 11, 0xff, 0x00)) : die("Chipset doesn't support ECC RAM\n"); > if (dimm_info.flags.is_ecc) […] Does gm45 code have dimm_info? https://review.coreboot.org/c/coreboot/+/34826/comment/2e43ae54_276635f6 PS15, Line 334: typedef struct { : int dimm_mask; : struct spd_dimminfo { : unsigned int rows; : unsigned int cols; : unsigned int chip_capacity; : unsigned int banks; : unsigned int ranks; : unsigned int cas_latencies; : unsigned int tAAmin; : unsigned int tCKmin; : unsigned int width; : unsigned int tRAS; : unsigned int tRP; : unsigned int tRCD; : unsigned int tWR; : unsigned int page_size; : unsigned int raw_card; : } channel[2]; : } spdinfo_t; > [out of topic] […] It's not needed in any other file. -- To view, visit https://review.coreboot.org/c/coreboot/+/34826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I265938d58c30264fd5d4f7b89da7b689058b8cf8 Gerrit-Change-Number: 34826 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:06:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/intel/i210/Makefile.inc: Remove a link path to itself
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70468 ) Change subject: drivers/intel/i210/Makefile.inc: Remove a link path to itself ...................................................................... Patch Set 13: (1 comment) File src/drivers/intel/i210/Makefile.inc: https://review.coreboot.org/c/coreboot/+/70468/comment/bcaea693_5c7eb577 PS13, Line 6: CFLAGS_x86_32 += -Isrc/drivers/intel/i210 Hmmm, tried this? CPPFLAGS_common += -I$(src)/drivers/intel/i210 -- To view, visit https://review.coreboot.org/c/coreboot/+/70468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94b0f99353ed3a582ea590cbc6b12dec6294c75d Gerrit-Change-Number: 70468 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 18:03:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/intel/gma: Hook up libgfxinit in romstage
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

1 0

[M] Change in coreboot[master]: drivers/intel/gma: Hook up libgfxinit in romstage
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Bora Guvendik, Zhixing Ma, Anil Kumar K, Hannah Williams, Cliff Huang, Tarun Tuli, Nico Huber, Michał Żygowski, Jérémy Compostella, Paul Menzel, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70276 ) Change subject: drivers/intel/gma: Hook up libgfxinit in romstage ...................................................................... Patch Set 19: (2 comments) File src/drivers/intel/gma/Kconfig: https://review.coreboot.org/c/coreboot/+/70276/comment/77614eea_b0dfd373 PS13, Line 95: SOC_INTEL_ALDERLAKE > Agreed. Suggest separating cleanup of existing block from this patch train though as out of scope. Let's keep it like this for now. File src/drivers/intel/gma/Kconfig: https://review.coreboot.org/c/coreboot/+/70276/comment/cc048285_350f6fbb PS15, Line 105: If : libgfxinit is used for both romstage and ramstage this : address should be the same than the one allocated by the PCI : resource allocator in ramstage. > The issue is that libhwbase decides of which driver to build and use at build time based on HWBASE_S […] For now, you can tell coreboot to report BAR0 as a fixed resource. This avoids surprises later on in case something regarding allocation changes, e.g. PCIe bridges at 00.01.x being populated or not. https://gist.github.com/Th3Fanbus/2f3c65aaccc0e1002a852951eb6d682d should do the trick. A long-term solution could be to replace the `HWBASE_STATIC_MMIO` and `HWBASE_DYNAMIC_MMIO` Kconfig options with stage-dependent implementations of some function. For instance, have a function that returns the base address; the romstage implementation returns a fixed base address and the ramstage implementation reads the value from the PCI config space registers. -- To view, visit https://review.coreboot.org/c/coreboot/+/70276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c2101de10dc5df54fe873e43bbe0f1c4dccff44 Gerrit-Change-Number: 70276 Gerrit-PatchSet: 19 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:56:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/intel/gma: Hook up libgfxinit in romstage
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Bora Guvendik, Zhixing Ma, Anil Kumar K, Hannah Williams, Cliff Huang, Tarun Tuli, Nico Huber, Michał Żygowski, Jérémy Compostella, Paul Menzel, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70276 ) Change subject: drivers/intel/gma: Hook up libgfxinit in romstage ...................................................................... Patch Set 19: (1 comment) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/70276/comment/51105b6e_20e48278 PS15, Line 64: cache-as-ram : stage > Marking this to leave it as EARLY for now unless anyone has very strong objections. […] Sounds good. -- To view, visit https://review.coreboot.org/c/coreboot/+/70276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c2101de10dc5df54fe873e43bbe0f1c4dccff44 Gerrit-Change-Number: 70276 Gerrit-PatchSet: 19 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:50:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i440bx: Specify supported memory type
by Angel Pons (Code Review) 01 Jan '23

01 Jan '23

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70575 ) Change subject: nb/intel/i440bx: Specify supported memory type ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: This patch seems a bit silly right now, but if the ultimate goal is to get rid of the `NO_` options, then it seems reasonable enough. -- To view, visit https://review.coreboot.org/c/coreboot/+/70575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If94037f2b010527440795e6920dd7a533c52f606 Gerrit-Change-Number: 70575 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 01 Jan 2023 17:49:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023